From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"mpe@ellerman.id.au" <mpe@ellerman.id.au>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH 3/3] powerpc/mm: Use VMALLOC_START to validate addr
Date: Mon, 27 Jun 2022 12:19:52 +0530 [thread overview]
Message-ID: <87y1xiy50v.fsf@linux.ibm.com> (raw)
In-Reply-To: <e69ac23f-5847-2acc-418e-5bd93864ed54@csgroup.eu>
Christophe Leroy <christophe.leroy@csgroup.eu> writes:
> Le 23/06/2022 à 14:29, Aneesh Kumar K.V a écrit :
>> Instead of high_memory use VMALLOC_START to validate that the address is
>> not in the vmalloc range.
>>
>> Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
>> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
>> ---
>> arch/powerpc/include/asm/page.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/include/asm/page.h b/arch/powerpc/include/asm/page.h
>> index e5f75c70eda8..256cad69e42e 100644
>> --- a/arch/powerpc/include/asm/page.h
>> +++ b/arch/powerpc/include/asm/page.h
>> @@ -134,7 +134,7 @@ static inline bool pfn_valid(unsigned long pfn)
>>
>> #define virt_addr_valid(vaddr) ({ \
>> unsigned long _addr = (unsigned long)vaddr; \
>> - _addr >= PAGE_OFFSET && _addr < (unsigned long)high_memory && \
>> + _addr >= PAGE_OFFSET && _addr < (unsigned long)VMALLOC_START && \
>> pfn_valid(virt_to_pfn(_addr)); \
>> })
>>
>
> What about booke/64 ?
>
> The test will be _addr >= 0xc000000000000000 && _addr <
> 0x8000000000000000 so the test will be always false.
>
Ok, I didn't realize that booke/64 have vmalloc range below direct map.
I guess we should drop patch 3.
-aneesh
prev parent reply other threads:[~2022-06-27 6:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 12:29 [PATCH 1/3] powerpc/memhotplug: Add add_pages override for PPC Aneesh Kumar K.V
2022-06-23 12:29 ` [PATCH 2/3] powerpc/mm: Update max/min_low_pfn in the same function Aneesh Kumar K.V
2022-06-23 12:29 ` [PATCH 3/3] powerpc/mm: Use VMALLOC_START to validate addr Aneesh Kumar K.V
2022-06-24 2:45 ` Michael Ellerman
2022-06-27 4:44 ` Aneesh Kumar K.V
2022-06-24 11:51 ` Christophe Leroy
2022-06-27 4:49 ` Aneesh Kumar K.V
2022-06-27 5:42 ` Christophe Leroy
2022-06-27 6:49 ` Aneesh Kumar K.V [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1xiy50v.fsf@linux.ibm.com \
--to=aneesh.kumar@linux.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhocko@suse.com \
--cc=mpe@ellerman.id.au \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).