linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Ram Pai <linuxram@us.ibm.com>
Cc: Dave Hansen <dave.hansen@intel.com>,
	linux-api@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-mm@kvack.org
Subject: Re: pkeys: Reserve PKEY_DISABLE_READ
Date: Wed, 05 Dec 2018 14:00:59 +0100	[thread overview]
Message-ID: <87zhtki0vo.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <20181204062318.GC11930@ram.oc3035372033.ibm.com> (Ram Pai's message of "Mon, 3 Dec 2018 22:23:18 -0800")

* Ram Pai:

> Ok. here is a patch, compiled but not tested. See if this meets the
> specifications.
>
> -----------------------------------------------------------------------------------
>
> commit 3dc06e73f3795921265d5d1d935e428deab01616
> Author: Ram Pai <linuxram@us.ibm.com>
> Date:   Tue Dec 4 00:04:11 2018 -0500
>
>     pkeys: add support of PKEY_DISABLE_READ

Thanks.  In the x86 code, the translation of PKEY_DISABLE_READ |
PKEY_DISABLE_WRITE to PKEY_DISABLE_ACCESS appears to be missing.  I
believe the existing code produces PKEY_DISABLE_WRITE, which is wrong.

Rest looks okay to me (again not tested).

Thanks,
Florian

  reply	other threads:[~2018-12-05 13:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <877ehnbwqy.fsf@oldenburg.str.redhat.com>
2018-11-08 19:22 ` pkeys: Reserve PKEY_DISABLE_READ Ram Pai
2018-11-12 10:29   ` Florian Weimer
     [not found] ` <2d62c9e2-375b-2791-32ce-fdaa7e7664fd@intel.com>
     [not found]   ` <87bm6zaa04.fsf@oldenburg.str.redhat.com>
     [not found]     ` <6f9c65fb-ea7e-8217-a4cc-f93e766ed9bb@intel.com>
     [not found]       ` <87k1ln8o7u.fsf@oldenburg.str.redhat.com>
2018-11-08 20:12         ` Ram Pai
2018-11-08 20:23           ` Florian Weimer
2018-11-09 18:09             ` Ram Pai
2018-11-12 12:00               ` Florian Weimer
2018-11-27 10:23                 ` Ram Pai
2018-11-27 11:57                   ` Florian Weimer
2018-11-27 15:31                     ` Dave Hansen
2018-11-29 11:37                       ` Florian Weimer
2018-12-03  4:02                         ` Ram Pai
2018-12-03 15:52                           ` Florian Weimer
2018-12-04  6:23                             ` Ram Pai
2018-12-05 13:00                               ` Florian Weimer [this message]
2018-12-05 20:23                                 ` Ram Pai
2018-12-05 16:21                           ` Andy Lutomirski
2018-12-05 20:36                             ` Ram Pai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhtki0vo.fsf@oldenburg2.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=dave.hansen@intel.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=linuxram@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).