* Re: [PATCH -next] powerpc/pseries: Fix platform_no_drv_owner.cocci warnings
2019-02-18 12:59 [PATCH -next] powerpc/pseries: Fix platform_no_drv_owner.cocci warnings YueHaibing
@ 2019-02-18 12:53 ` Julia Lawall
2019-02-18 13:21 ` YueHaibing
2019-02-18 13:39 ` [PATCH v2 " YueHaibing
1 sibling, 1 reply; 5+ messages in thread
From: Julia Lawall @ 2019-02-18 12:53 UTC (permalink / raw)
To: YueHaibing
Cc: kernel-janitors, linux-kernel, Oliver O'Halloran,
Paul Mackerras, Dan Williams, linuxppc-dev
On Mon, 18 Feb 2019, YueHaibing wrote:
> Remove .owner field if calls are used which set it automatically
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> arch/powerpc/platforms/pseries/papr_scm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c
> index bba281b1fe1b..e3f5c1a01950 100644
> --- a/arch/powerpc/platforms/pseries/papr_scm.c
> +++ b/arch/powerpc/platforms/pseries/papr_scm.c
> @@ -21,6 +21,7 @@
> (1ul << ND_CMD_GET_CONFIG_DATA) | \
> (1ul << ND_CMD_SET_CONFIG_DATA))
>
> +
No need to add a blank line.
julia
> struct papr_scm_priv {
> struct platform_device *pdev;
> struct device_node *dn;
> @@ -358,7 +359,6 @@ static struct platform_driver papr_scm_driver = {
> .remove = papr_scm_remove,
> .driver = {
> .name = "papr_scm",
> - .owner = THIS_MODULE,
> .of_match_table = papr_scm_match,
> },
> };
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH -next] powerpc/pseries: Fix platform_no_drv_owner.cocci warnings
@ 2019-02-18 12:59 YueHaibing
2019-02-18 12:53 ` Julia Lawall
2019-02-18 13:39 ` [PATCH v2 " YueHaibing
0 siblings, 2 replies; 5+ messages in thread
From: YueHaibing @ 2019-02-18 12:59 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
Oliver O'Halloran, Dan Williams
Cc: linuxppc-dev, kernel-janitors, YueHaibing, linux-kernel
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
arch/powerpc/platforms/pseries/papr_scm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c
index bba281b1fe1b..e3f5c1a01950 100644
--- a/arch/powerpc/platforms/pseries/papr_scm.c
+++ b/arch/powerpc/platforms/pseries/papr_scm.c
@@ -21,6 +21,7 @@
(1ul << ND_CMD_GET_CONFIG_DATA) | \
(1ul << ND_CMD_SET_CONFIG_DATA))
+
struct papr_scm_priv {
struct platform_device *pdev;
struct device_node *dn;
@@ -358,7 +359,6 @@ static struct platform_driver papr_scm_driver = {
.remove = papr_scm_remove,
.driver = {
.name = "papr_scm",
- .owner = THIS_MODULE,
.of_match_table = papr_scm_match,
},
};
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH -next] powerpc/pseries: Fix platform_no_drv_owner.cocci warnings
2019-02-18 12:53 ` Julia Lawall
@ 2019-02-18 13:21 ` YueHaibing
0 siblings, 0 replies; 5+ messages in thread
From: YueHaibing @ 2019-02-18 13:21 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors, linux-kernel, Oliver O'Halloran,
Paul Mackerras, Dan Williams, linuxppc-dev
On 2019/2/18 20:53, Julia Lawall wrote:
>
>
> On Mon, 18 Feb 2019, YueHaibing wrote:
>
>> Remove .owner field if calls are used which set it automatically
>> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> arch/powerpc/platforms/pseries/papr_scm.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c
>> index bba281b1fe1b..e3f5c1a01950 100644
>> --- a/arch/powerpc/platforms/pseries/papr_scm.c
>> +++ b/arch/powerpc/platforms/pseries/papr_scm.c
>> @@ -21,6 +21,7 @@
>> (1ul << ND_CMD_GET_CONFIG_DATA) | \
>> (1ul << ND_CMD_SET_CONFIG_DATA))
>>
>> +
>
> No need to add a blank line.
Yes, will fix it.
>
> julia
>
>> struct papr_scm_priv {
>> struct platform_device *pdev;
>> struct device_node *dn;
>> @@ -358,7 +359,6 @@ static struct platform_driver papr_scm_driver = {
>> .remove = papr_scm_remove,
>> .driver = {
>> .name = "papr_scm",
>> - .owner = THIS_MODULE,
>> .of_match_table = papr_scm_match,
>> },
>> };
>>
>>
>>
>>
>
> .
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 -next] powerpc/pseries: Fix platform_no_drv_owner.cocci warnings
2019-02-18 12:59 [PATCH -next] powerpc/pseries: Fix platform_no_drv_owner.cocci warnings YueHaibing
2019-02-18 12:53 ` Julia Lawall
@ 2019-02-18 13:39 ` YueHaibing
2019-11-14 9:08 ` Michael Ellerman
1 sibling, 1 reply; 5+ messages in thread
From: YueHaibing @ 2019-02-18 13:39 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
Oliver O'Halloran, Dan Williams
Cc: linuxppc-dev, kernel-janitors, YueHaibing, linux-kernel
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
arch/powerpc/platforms/pseries/papr_scm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c
index bba281b1fe1b..679bf2420bc1 100644
--- a/arch/powerpc/platforms/pseries/papr_scm.c
+++ b/arch/powerpc/platforms/pseries/papr_scm.c
@@ -358,7 +358,6 @@ static struct platform_driver papr_scm_driver = {
.remove = papr_scm_remove,
.driver = {
.name = "papr_scm",
- .owner = THIS_MODULE,
.of_match_table = papr_scm_match,
},
};
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 -next] powerpc/pseries: Fix platform_no_drv_owner.cocci warnings
2019-02-18 13:39 ` [PATCH v2 " YueHaibing
@ 2019-11-14 9:08 ` Michael Ellerman
0 siblings, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2019-11-14 9:08 UTC (permalink / raw)
To: YueHaibing, Benjamin Herrenschmidt, Paul Mackerras,
Oliver O'Halloran, Dan Williams
Cc: kernel-janitors, YueHaibing, linuxppc-dev, linux-kernel
On Mon, 2019-02-18 at 13:39:50 UTC, YueHaibing wrote:
> Remove .owner field if calls are used which set it automatically
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/42974f357dbf05d649ff62719de21995e7cfee79
cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-11-14 10:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-18 12:59 [PATCH -next] powerpc/pseries: Fix platform_no_drv_owner.cocci warnings YueHaibing
2019-02-18 12:53 ` Julia Lawall
2019-02-18 13:21 ` YueHaibing
2019-02-18 13:39 ` [PATCH v2 " YueHaibing
2019-11-14 9:08 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).