From: Andy Fleming <afleming@freescale.com>
To: Timur Tabi <timur@freescale.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] phylib: update mdiobus_alloc() to allocate extra private space
Date: Thu, 15 Dec 2011 12:06:01 -0500 [thread overview]
Message-ID: <8ABCAC4C-1D11-41AD-AE46-96EB9D40588D@freescale.com> (raw)
In-Reply-To: <1323967895-5205-1-git-send-email-timur@freescale.com>
On Dec 15, 2011, at 11:51 AM, Timur Tabi wrote:
> Augment mdiobus_alloc() to take a parameter indicating the number of =
extra
> bytes to allocate for private data. Almost all callers of =
mdiobus_alloc()
> separately allocate a private data structure. By allowing =
mdiobus_alloc()
> to allocate extra memory, the two allocations can be merged into one.
>=20
> This patch does not change any of the callers to actually take =
advantage
> of this feature, however. That change can be made by the individual
> maintainers at their leisure. For now, all callers ask for zero =
additional
> bytes, which mimics the previous behavior.
Why? Doesn't this just obfuscate things a little, while providing no =
immediate benefit?
Andy=
next prev parent reply other threads:[~2011-12-15 17:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 16:51 [PATCH] phylib: update mdiobus_alloc() to allocate extra private space Timur Tabi
2011-12-15 17:06 ` Andy Fleming [this message]
2011-12-15 17:12 ` Timur Tabi
2011-12-16 20:32 ` David Miller
2011-12-16 20:37 ` Timur Tabi
2011-12-16 20:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ABCAC4C-1D11-41AD-AE46-96EB9D40588D@freescale.com \
--to=afleming@freescale.com \
--cc=davem@davemloft.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).