RE: Bug in drivers/serial/of_serial.c?

["Alon Ziv" <alonz@discretix.com>]

Hi,

On Thursday, November 19, 2009, Arnd wrote:
> In that case, add another entry for the device encoded in the firmware
> itself. The ns16550 entry should be the second one after a more
specific
> one telling which device it is exactly.
>=20

Is the following better?

---
[PATCH] Xilinx 16550 UART is actually 16550A-compatible

diff --git a/drivers/serial/of_serial.c b/drivers/serial/of_serial.c
index 02406ba..40bf8f4 100644
--- a/drivers/serial/of_serial.c
+++ b/drivers/serial/of_serial.c
@@ -161,6 +161,7 @@ static int of_platform_serial_remove(struct
of_device *ofdev)
 static struct of_device_id __devinitdata of_platform_serial_table[] =3D =
{
 	{ .type =3D "serial", .compatible =3D "ns8250",   .data =3D (void
*)PORT_8250, },
 	{ .type =3D "serial", .compatible =3D "ns16450",  .data =3D (void
*)PORT_16450, },
+	{ .type =3D "serial", .compatible =3D "xlnx,xps-uart16550-2.00.b",
=2Edata =3D (void *)PORT_16550A, },
 	{ .type =3D "serial", .compatible =3D "ns16550",  .data =3D (void
*)PORT_16550, },
 	{ .type =3D "serial", .compatible =3D "ns16750",  .data =3D (void
*)PORT_16750, },
 	{ .type =3D "serial", .compatible =3D "ns16850",  .data =3D (void
*)PORT_16850, },
*************************************************************************=
*********************
IMPORTANT: The contents of this email and any attachments are confidentia=
l. They are intended for the=20
named recipient(s) only.
If you have received this email in error, please notify the system manage=
r or the sender immediately and do=20
not disclose the contents to anyone or make copies thereof.