linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
To: Balbir Singh <bsingharora@gmail.com>,
	benh@kernel.crashing.org, mpe@ellerman.id.au
Cc: linuxppc-dev@lists.ozlabs.org, paulus@samba.org, anton@samba.org,
	npiggin@gmail.com
Subject: Re: [PATCH v4 02/12] powerpc: move set_soft_enabled() and rename
Date: Wed, 21 Dec 2016 09:02:09 +0530	[thread overview]
Message-ID: <8e2b36c8-5cb3-0ed4-65f4-45be81da0f4e@linux.vnet.ibm.com> (raw)
In-Reply-To: <f09a9213-9e85-eee0-e212-bd3ee2a3569e@gmail.com>



On Tuesday 20 December 2016 02:33 PM, Balbir Singh wrote:
>
> On 19/12/16 19:06, Madhavan Srinivasan wrote:
>> Move set_soft_enabled() from powerpc/kernel/irq.c to
>> asm/hw_irq.c, to force updates to paca-soft_enabled
>> done via these access function. Add "memory" clobber
>> to hint compiler since paca->soft_enabled memory is the target
>> here
>> +static inline notrace void soft_enabled_set(unsigned long enable)
>> +{
>> +	__asm__ __volatile__("stb %0,%1(13)"
>> +	: : "r" (enable), "i" (offsetof(struct paca_struct, soft_enabled))
>> +	: "memory");
>> +}
>> +
> Can't we just rewrite this in "C"?
>
> local_paca->soft_enabled = enable

Yes we did discussed this  and parked it to handle in the follow on 
patchset.
Nick did suggest something of this sort,

__asm__ __volatile__("stb %1,%0" : "=m" (local_paca->soft_enabled) : "r" 
(enable));



> Balbir Singh.
>

  parent reply	other threads:[~2016-12-21  3:32 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-19  8:06 [PATCH v4 00/12]powerpc: "paca->soft_enabled" based local atomic operation implementation Madhavan Srinivasan
2016-12-19  8:06 ` [PATCH v4 01/12] powerpc: Add #defs for paca->soft_enabled flags Madhavan Srinivasan
2016-12-20  7:31   ` Balbir Singh
2016-12-21  3:22     ` Madhavan Srinivasan
2016-12-19  8:06 ` [PATCH v4 02/12] powerpc: move set_soft_enabled() and rename Madhavan Srinivasan
2016-12-20  9:03   ` Balbir Singh
2016-12-20  9:32     ` Benjamin Herrenschmidt
2016-12-20 13:58       ` Balbir Singh
2016-12-21  3:32     ` Madhavan Srinivasan [this message]
2016-12-19  8:06 ` [PATCH v4 03/12] powerpc: Use soft_enabled_set api to update paca->soft_enabled Madhavan Srinivasan
2016-12-19  8:07 ` [PATCH v4 04/12] powerpc: Add soft_enabled manipulation functions Madhavan Srinivasan
2016-12-19  8:07 ` [PATCH v4 05/12] powerpc: reverse the soft_enable logic Madhavan Srinivasan
2016-12-19  8:07 ` [PATCH v4 06/12] powerpc: Avoid using EXCEPTION_PROLOG_1 macro in MASKABLE_* Madhavan Srinivasan
2016-12-19  8:07 ` [PATCH v4 07/12] powerpc: Add support to take additional parameter in MASKABLE_* macro Madhavan Srinivasan
2016-12-20  2:36   ` Nicholas Piggin
2016-12-21  6:14     ` Madhavan Srinivasan
2016-12-19  8:07 ` [PATCH v4 08/12] powerpc: Add support to mask perf interrupts and replay them Madhavan Srinivasan
2016-12-19  8:07 ` [PATCH v4 09/12] powerpc:Add new kconfig IRQ_DEBUG_SUPPORT Madhavan Srinivasan
2016-12-19  8:07 ` [PATCH v4 10/12] powerpc: Add new set of soft_enabled_ functions Madhavan Srinivasan
2016-12-20  2:42   ` Nicholas Piggin
2016-12-19  8:07 ` [PATCH v4 11/12] powerpc: rewrite local_t using soft_irq Madhavan Srinivasan
2016-12-19  8:07 ` [PATCH v4 12/12] powerpc: Rename soft_enabled to soft_disabled_mask Madhavan Srinivasan
2016-12-20  2:58   ` Nicholas Piggin
2017-01-04  9:33     ` Madhavan Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e2b36c8-5cb3-0ed4-65f4-45be81da0f4e@linux.vnet.ibm.com \
    --to=maddy@linux.vnet.ibm.com \
    --cc=anton@samba.org \
    --cc=benh@kernel.crashing.org \
    --cc=bsingharora@gmail.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).