From: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@ozlabs.org, maddy@linux.ibm.com, paulus@samba.org
Subject: Re: [PATCH] powerpc/perf: Add missing break in power7_marked_instr_event()
Date: Mon, 24 Sep 2018 12:35:16 +0530 [thread overview]
Message-ID: <8f147e4f-321b-d730-0a0a-f6cee8254dd0@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180920144715.GA23155@gate.crashing.org>
On Thursday 20 September 2018 08:17 PM, Segher Boessenkool wrote:
> On Thu, Sep 20, 2018 at 03:29:22PM +0530, Madhavan Srinivasan wrote:
>> On Thursday 20 September 2018 03:11 PM, Michael Ellerman wrote:
>>> In power7_marked_instr_event() there is a switch case that is missing
>>> a break or an explicit fallthrough, it's not immediately clear which
>>> it should be.
>> Just curious to know, how did you find this. Static code checker compiled
>> or any specific compiler warnings or just by code read?
> Newer GCC warns about suspicious fallthroughs (-Wimplicit-fallthrough,
> which is in -Wextra).
>
Nice good to know.
Maddy
> Segher
>
next prev parent reply other threads:[~2018-09-24 7:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 9:41 [PATCH] powerpc/perf: Add missing break in power7_marked_instr_event() Michael Ellerman
2018-09-20 9:59 ` Madhavan Srinivasan
2018-09-20 14:47 ` Segher Boessenkool
2018-09-24 7:03 ` Michael Ellerman
2018-09-24 7:05 ` Madhavan Srinivasan [this message]
2018-10-04 6:14 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f147e4f-321b-d730-0a0a-f6cee8254dd0@linux.vnet.ibm.com \
--to=maddy@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).