From: Balbir Singh <bsingharora@gmail.com>
To: Santosh Sivaraj <santosh@fossix.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Mahesh Salgaonkar <mahesh@linux.ibm.com>,
Nicholas Piggin <npiggin@gmail.com>,
Chandan Rajendra <chandan@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Reza Arbab <arbab@linux.ibm.com>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH v9 4/7] extable: Add function to search only kernel exception table
Date: Wed, 14 Aug 2019 19:22:00 +1000 [thread overview]
Message-ID: <916d5741-a0bd-8860-4a38-7a5ef677214a@gmail.com> (raw)
In-Reply-To: <20190812092236.16648-5-santosh@fossix.org>
On 12/8/19 7:22 pm, Santosh Sivaraj wrote:
> Certain architecture specific operating modes (e.g., in powerpc machine
> check handler that is unable to access vmalloc memory), the
> search_exception_tables cannot be called because it also searches the
> module exception tables if entry is not found in the kernel exception
> table.
>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Nicholas Piggin <npiggin@gmail.com>
> Signed-off-by: Santosh Sivaraj <santosh@fossix.org>
> Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
> ---
> include/linux/extable.h | 2 ++
> kernel/extable.c | 11 +++++++++--
> 2 files changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/extable.h b/include/linux/extable.h
> index 41c5b3a25f67..81ecfaa83ad3 100644
> --- a/include/linux/extable.h
> +++ b/include/linux/extable.h
> @@ -19,6 +19,8 @@ void trim_init_extable(struct module *m);
>
> /* Given an address, look for it in the exception tables */
> const struct exception_table_entry *search_exception_tables(unsigned long add);
> +const struct exception_table_entry *
> +search_kernel_exception_table(unsigned long addr);
>
Can we find a better name search_kernel still sounds like all of the kernel.
Can we rename it to search_kernel_linear_map_extable?
> #ifdef CONFIG_MODULES
> /* For extable.c to search modules' exception tables. */
> diff --git a/kernel/extable.c b/kernel/extable.c
> index e23cce6e6092..f6c9406eec7d 100644
> --- a/kernel/extable.c
> +++ b/kernel/extable.c
> @@ -40,13 +40,20 @@ void __init sort_main_extable(void)
> }
> }
>
> +/* Given an address, look for it in the kernel exception table */
> +const
> +struct exception_table_entry *search_kernel_exception_table(unsigned long addr)
> +{
> + return search_extable(__start___ex_table,
> + __stop___ex_table - __start___ex_table, addr);
> +}
> +
> /* Given an address, look for it in the exception tables. */
> const struct exception_table_entry *search_exception_tables(unsigned long addr)
> {
> const struct exception_table_entry *e;
>
> - e = search_extable(__start___ex_table,
> - __stop___ex_table - __start___ex_table, addr);
> + e = search_kernel_exception_table(addr);
> if (!e)
> e = search_module_extables(addr);
> return e;
>
next prev parent reply other threads:[~2019-08-14 9:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 9:22 [PATCH v9 0/7] powerpc: implement machine check safe memcpy Santosh Sivaraj
2019-08-12 9:22 ` [PATCH v9 1/7] powerpc/mce: Schedule work from irq_work Santosh Sivaraj
2019-08-13 4:46 ` Mahesh Jagannath Salgaonkar
2019-08-14 9:02 ` Balbir Singh
2019-08-12 9:22 ` [PATCH v9 2/7] powerpc/mce: Fix MCE handling for huge pages Santosh Sivaraj
2019-08-12 13:55 ` Sasha Levin
2019-08-13 0:40 ` Santosh Sivaraj
2019-08-12 9:22 ` [PATCH v9 3/7] powerpc/mce: Make machine_check_ue_event() static Santosh Sivaraj
2019-08-12 9:22 ` [PATCH v9 4/7] extable: Add function to search only kernel exception table Santosh Sivaraj
2019-08-14 9:22 ` Balbir Singh [this message]
2019-08-14 9:39 ` Santosh Sivaraj
2019-08-12 9:22 ` [PATCH v9 5/7] powerpc/memcpy: Add memcpy_mcsafe for pmem Santosh Sivaraj
2019-08-12 9:22 ` [PATCH v9 6/7] powerpc/mce: Handle UE event for memcpy_mcsafe Santosh Sivaraj
2019-08-14 8:11 ` Mahesh Jagannath Salgaonkar
2019-08-14 9:38 ` Balbir Singh
2019-08-15 0:15 ` Santosh Sivaraj
2019-08-12 9:22 ` [PATCH v9 7/7] powerpc: add machine check safe copy_to_user Santosh Sivaraj
2019-08-14 9:40 ` Balbir Singh
2019-08-15 0:07 ` Santosh Sivaraj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=916d5741-a0bd-8860-4a38-7a5ef677214a@gmail.com \
--to=bsingharora@gmail.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=arbab@linux.ibm.com \
--cc=chandan@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=mingo@kernel.org \
--cc=npiggin@gmail.com \
--cc=santosh@fossix.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).