From: "Pravin Bathija" <pbathija@amcc.com>
To: "Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"James Bottomley" <James.Bottomley@suse.de>
Cc: Eric.Moore@lsi.com, linux-scsi@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: RE: [PATCH] [SCSI] mpt fusion: Fix 32 bit platforms with 64 bit resources.
Date: Thu, 5 Nov 2009 21:49:41 -0800 [thread overview]
Message-ID: <9D1E2BDCB5C57B46B56E6D80843439EB09350F76@SDCEXCHANGE01.ad.amcc.com> (raw)
In-Reply-To: 1257451218.13611.114.camel@pasglop
[-- Attachment #1: Type: text/plain, Size: 1789 bytes --]
-----Original Message-----
From: Benjamin Herrenschmidt [mailto:benh@kernel.crashing.org]
Sent: Thu 11/5/2009 12:00 PM
To: James Bottomley
Cc: Josh Boyer; Eric.Moore@lsi.com; Pravin Bathija; linux-scsi@vger.kernel.org; linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] [SCSI] mpt fusion: Fix 32 bit platforms with 64 bit resources.
On Thu, 2009-11-05 at 10:07 -0600, James Bottomley wrote:
> > > ioc->memmap = mem;
> > >- dinitprintk(ioc, printk(MYIOC_s_INFO_FMT "mem = %p, mem_phys = %lx\n",
> > >- ioc->name, mem, mem_phys));
> > >+ dinitprintk(ioc, printk(MYIOC_s_INFO_FMT "mem = %p, mem_phys = %llx\n",
> > >+ ioc->name, mem, (u64)mem_phys));
> > >
> > > ioc->mem_phys = mem_phys;
> > > ioc->chip = (SYSIF_REGS __iomem *)mem;
> > >
> > > /* Save Port IO values in case we need to do downloadboot */
> > >- ioc->pio_mem_phys = port;
> > >+ port = ioremap(port_phys, psize);
> > >+ if (port == NULL) {
> > >+ printk(MYIOC_s_ERR_FMT " : ERROR - Unable to map adapter"
> > >+ " port !\n", ioc->name);
> > >+ return -EINVAL;
>
> So this looks problematic on a few platforms ... what happens to
> platforms that have no IO space? They automatically fail here and it
> looks like the adapter never attaches.
> Yup, that part of the patch looks wrong.
> However, a mechanical replacement of unsigned long's with
> resource_size_t to hold physical addresses should be fine despite the
> lack of feedback from LSI.
> Pravin, that ioremap definitely seems like it has nothing to do there,
> port IO is already remapped for you by the core PCI code and should work
> "as is". Please respin without that change.
> Cheers,
>Ben.
Thanks for the input. Will make the suggested changes and re-submit the patch.
Regards,
Pravin
[-- Attachment #2: Type: text/html, Size: 2991 bytes --]
next prev parent reply other threads:[~2009-11-06 6:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-15 22:25 [PATCH] [SCSI] mpt fusion: Fix 32 bit platforms with 64 bit resources pbathija
2009-11-05 13:43 ` Josh Boyer
2009-11-05 16:07 ` James Bottomley
2009-11-05 16:25 ` Josh Boyer
2009-11-05 20:00 ` Benjamin Herrenschmidt
2009-11-06 4:59 ` Desai, Kashyap
2009-11-06 5:49 ` Pravin Bathija [this message]
2009-11-06 5:57 ` Pravin Bathija
-- strict thread matches above, loose matches on Subject: below --
2009-12-03 1:51 Pravin Bathija
2009-12-03 2:59 ` Benjamin Herrenschmidt
2009-12-03 5:26 ` Desai, Kashyap
2009-12-03 8:56 ` Wolfgang Denk
2009-12-03 23:21 ` Pravin Bathija
2009-12-03 23:48 ` Benjamin Herrenschmidt
2009-12-10 15:43 ` James Bottomley
2009-12-10 16:36 ` Anatolij Gustschin
2009-11-18 0:16 pbathija
2009-11-18 5:41 ` Benjamin Herrenschmidt
2009-09-09 0:15 pbathija
2009-09-15 10:29 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9D1E2BDCB5C57B46B56E6D80843439EB09350F76@SDCEXCHANGE01.ad.amcc.com \
--to=pbathija@amcc.com \
--cc=Eric.Moore@lsi.com \
--cc=James.Bottomley@suse.de \
--cc=benh@kernel.crashing.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).