linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
To: Joel Stanley <joel@jms.id.au>
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>,
	linuxppc-dev@lists.ozlabs.org,
	Athira Rajeev <atrajeev@linux.ibm.com>
Subject: Re: [PATCH v2] powerpc/perf: Give generic PMU a nice name
Date: Fri, 10 Jun 2022 13:16:20 +0530	[thread overview]
Message-ID: <A506984B-31A6-43E2-8F1F-9F01621539A1@linux.vnet.ibm.com> (raw)
In-Reply-To: <20220610044006.2095806-1-joel@jms.id.au>



> On 10-Jun-2022, at 10:10 AM, Joel Stanley <joel@jms.id.au> wrote:
> 
> When booting on a machine that uses the compat pmu driver we see this:
> 
> [    0.071192] GENERIC_COMPAT performance monitor hardware support registered
> 
> Which is a bit shouty. Give it a nicer name.
> 
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> v2: Go with ISAv3
> 
> arch/powerpc/perf/generic-compat-pmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/perf/generic-compat-pmu.c b/arch/powerpc/perf/generic-compat-pmu.c
> index f3db88aee4dd..16392962c511 100644
> --- a/arch/powerpc/perf/generic-compat-pmu.c
> +++ b/arch/powerpc/perf/generic-compat-pmu.c
> @@ -292,7 +292,7 @@ static int generic_compute_mmcr(u64 event[], int n_ev,
> }
> 
> static struct power_pmu generic_compat_pmu = {
> -	.name			= "GENERIC_COMPAT",
> +	.name			= "ISAv3",


Looks good.


Reviewed-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>

> 	.n_counter		= MAX_PMU_COUNTERS,
> 	.add_fields		= ISA207_ADD_FIELDS,
> 	.test_adder		= ISA207_TEST_ADDER,
> -- 
> 2.35.1
> 


  reply	other threads:[~2022-06-10  7:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-10  4:40 [PATCH v2] powerpc/perf: Give generic PMU a nice name Joel Stanley
2022-06-10  7:46 ` Athira Rajeev [this message]
2022-07-29 13:01 ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A506984B-31A6-43E2-8F1F-9F01621539A1@linux.vnet.ibm.com \
    --to=atrajeev@linux.vnet.ibm.com \
    --cc=atrajeev@linux.ibm.com \
    --cc=joel@jms.id.au \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).