From: Madalin-Cristian Bucur <madalin.bucur@freescale.com>
To: David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Scott Wood <scottwood@freescale.com>,
Liberman Igal <Igal.Liberman@freescale.com>,
"ppc@mindchasers.com" <ppc@mindchasers.com>,
"joe@perches.com" <joe@perches.com>,
"pebolle@tiscali.nl" <pebolle@tiscali.nl>,
"joakim.tjernlund@transmode.se" <joakim.tjernlund@transmode.se>
Subject: RE: [v2 8/9] dpaa_eth: add debugfs entries
Date: Tue, 11 Aug 2015 11:00:39 +0000 [thread overview]
Message-ID: <BL2PR03MB545A863C210E5BFC9DFC128E67F0@BL2PR03MB545.namprd03.prod.outlook.com> (raw)
In-Reply-To: <20150807.153716.1393797980617992919.davem@davemloft.net>
> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
>=20
> From: Madalin Bucur <madalin.bucur@freescale.com>
> Date: Wed, 5 Aug 2015 18:41:28 +0300
>=20
> > Export per CPU counters through debugfs.
> >
> > Signed-off-by: Madalin Bucur <madalin.bucur@freescale.com>
>=20
> This is absolutely inappropriate.
>=20
> You can export these just fine via ethtool statistics. There is zero rea=
son
> to add ugly debugfs crap for something like this.
If you have such a strong adversity about the debugfs, then I'll export the=
se
debug counters through ethtool statistics in the next version.
Madalin
next prev parent reply other threads:[~2015-08-11 11:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 15:41 [v2 0/9] dpaa_eth: Add the Freescale DPAA Ethernet driver Madalin Bucur
2015-08-05 15:41 ` [v2 1/9] devres: add devm_alloc_percpu() Madalin Bucur
2015-08-05 15:41 ` [v2 2/9] dpaa_eth: add support for DPAA Ethernet Madalin Bucur
2015-08-08 17:38 ` Florian Fainelli
2015-08-05 15:41 ` [v2 3/9] dpaa_eth: add support for S/G frames Madalin Bucur
2015-08-05 15:41 ` [v2 4/9] dpaa_eth: add driver's Tx queue selection mechanism Madalin Bucur
2015-08-05 15:41 ` [v2 5/9] dpaa_eth: add ethtool functionality Madalin Bucur
2015-08-05 15:41 ` [v2 6/9] dpaa_eth: add sysfs exports Madalin Bucur
2015-08-05 15:41 ` [v2 7/9] dpaa_eth: add debugfs counters Madalin Bucur
2015-08-05 15:41 ` [v2 8/9] dpaa_eth: add debugfs entries Madalin Bucur
2015-08-07 22:37 ` David Miller
2015-08-11 11:00 ` Madalin-Cristian Bucur [this message]
2015-08-05 15:41 ` [v2 9/9] dpaa_eth: add trace points Madalin Bucur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL2PR03MB545A863C210E5BFC9DFC128E67F0@BL2PR03MB545.namprd03.prod.outlook.com \
--to=madalin.bucur@freescale.com \
--cc=Igal.Liberman@freescale.com \
--cc=davem@davemloft.net \
--cc=joakim.tjernlund@transmode.se \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=ppc@mindchasers.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).