From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F475C6FD1D for ; Tue, 21 Mar 2023 01:12:50 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4PgYW438DNz3cfB for ; Tue, 21 Mar 2023 12:12:48 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=TDLldTic; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::432; helo=mail-wr1-x432.google.com; envelope-from=shengjiu.wang@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=TDLldTic; dkim-atps=neutral Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Pg5c805s5z3c6V for ; Mon, 20 Mar 2023 18:15:35 +1100 (AEDT) Received: by mail-wr1-x432.google.com with SMTP id t15so9298004wrz.7 for ; Mon, 20 Mar 2023 00:15:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679296530; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=dY92vEzHOiV+rG421ld252/xmXBkyzgS2OHqebmaw2Y=; b=TDLldTicqspc9s1Psp4WFXM8D1A71UjYcc3DBGVJ8aJLJVzaffglVufgUdf93s0Lcq 6Mhyjsg5miExtKZtuIXP6xYILZ5YBNWrhnVHD7bkfnWQxZ9/e0x0tvlf96KppEpGhIQB wJJBRoDGe9Pptc+dbY6caRmGejyJJJHlS/kVnGxP7enYui5mONkTHqWllfUKE0Yij/EY tmB6j3vxRwi2kwYT4D+QokKuGoMFIYi4yxJb0OjxDxfxeFUF1wfkpY13HnCqwPgA7pd1 rcGg/ADwMUPM+hXSaYQC+loTBcAtI7ak+FmdwpmxHDPhJUjFyPkNirlQRKtcX7rAPv0W OXKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679296530; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dY92vEzHOiV+rG421ld252/xmXBkyzgS2OHqebmaw2Y=; b=hm+JNz0PdT8yJTaVzeEsmCStXsLDqQjXPrsg/9cbSkRnm7leVN5dBpflTqxqB+/Oo9 ZeJA/gaMy6E+Pey2d56yNSeeuJMp7yn560/rw4FUfJk0ofyzTI3KtZl+HTiP7IbZDMLE eZl22GyQv+bdsbc9IqvX83XBu2c9WmMzqf2n56GxgVDYyRBzQrs+o1LByrDacUv4/Vj4 eESt8QwOTwinAuRxOwSWQn+pksmY7dSBHTejpFp1GpC2PWp8Wu5qU+cnp9pYGi6jmEEi cdtjc9mhOzXdkQoc7cv8N3uTVrPGRrma2Gku2K0g0VeswhFs/1lK/RKeAVzAizj5rLti pVHA== X-Gm-Message-State: AO0yUKVTFDSef6RwBAjBmEfLDTOx89yiwMECIBs/CbKlkurn2jEmv1lD 0i0yDXqqFZ5k6n7GGFxDdEVoDg4fAy8h6dyXC+s= X-Google-Smtp-Source: AK7set8bjiLJmu3eUzsHxI8KBE9iHVveKhlY4rBBQM8zc10nf1T3fnhAqGB41UEVlQTJakshmB93LPsWh9KA8n+x5Vs= X-Received: by 2002:a5d:588c:0:b0:2cf:e75a:eaf0 with SMTP id n12-20020a5d588c000000b002cfe75aeaf0mr3099156wrf.0.1679296530304; Mon, 20 Mar 2023 00:15:30 -0700 (PDT) MIME-Version: 1.0 References: <20230316123611.3495597-1-alexander.stein@ew.tq-group.com> In-Reply-To: <20230316123611.3495597-1-alexander.stein@ew.tq-group.com> From: Shengjiu Wang Date: Mon, 20 Mar 2023 15:15:18 +0800 Message-ID: Subject: Re: [PATCH 1/2] ASoC: fsl: define a common DRIVER_NAME To: Alexander Stein Content-Type: multipart/alternative; boundary="00000000000029534405f74fb180" X-Mailman-Approved-At: Tue, 21 Mar 2023 12:11:57 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Xiubo Li , linuxppc-dev@lists.ozlabs.org, Takashi Iwai , Liam Girdwood , Jaroslav Kysela , Nicolin Chen , Mark Brown , Fabio Estevam Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" --00000000000029534405f74fb180 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 16, 2023 at 8:36=E2=80=AFPM Alexander Stein < alexander.stein@ew.tq-group.com> wrote: > Instead of copying the driver name manually, use a common define. > No functional change. > > Signed-off-by: Alexander Stein > Acked-by: Shengjiu Wang Best regards wang shengjiu > --- > sound/soc/fsl/fsl-asoc-card.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.= c > index cdfca9fd1eb0..e956abfd50f8 100644 > --- a/sound/soc/fsl/fsl-asoc-card.c > +++ b/sound/soc/fsl/fsl-asoc-card.c > @@ -28,6 +28,8 @@ > #include "../codecs/wm8994.h" > #include "../codecs/tlv320aic31xx.h" > > +#define DRIVER_NAME "fsl-asoc-card" > + > #define CS427x_SYSCLK_MCLK 0 > > #define RX 0 > @@ -915,7 +917,7 @@ MODULE_DEVICE_TABLE(of, fsl_asoc_card_dt_ids); > static struct platform_driver fsl_asoc_card_driver =3D { > .probe =3D fsl_asoc_card_probe, > .driver =3D { > - .name =3D "fsl-asoc-card", > + .name =3D DRIVER_NAME, > .pm =3D &snd_soc_pm_ops, > .of_match_table =3D fsl_asoc_card_dt_ids, > }, > @@ -924,5 +926,5 @@ module_platform_driver(fsl_asoc_card_driver); > > MODULE_DESCRIPTION("Freescale Generic ASoC Sound Card driver with ASRC")= ; > MODULE_AUTHOR("Nicolin Chen "); > -MODULE_ALIAS("platform:fsl-asoc-card"); > +MODULE_ALIAS("platform:" DRIVER_NAME); > MODULE_LICENSE("GPL"); > -- > 2.34.1 > > --00000000000029534405f74fb180 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Mar 16, 2023 at 8:36=E2=80=AF= PM Alexander Stein <a= lexander.stein@ew.tq-group.com> wrote:
Instead of copying the driver name manually, = use a common define.
No functional change.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com>

Best regards
wang shengjiu=C2=A0
---
=C2=A0sound/soc/fsl/fsl-asoc-card.c | 6 ++++--
=C2=A01 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c<= br> index cdfca9fd1eb0..e956abfd50f8 100644
--- a/sound/soc/fsl/fsl-asoc-card.c
+++ b/sound/soc/fsl/fsl-asoc-card.c
@@ -28,6 +28,8 @@
=C2=A0#include "../codecs/wm8994.h"
=C2=A0#include "../codecs/tlv320aic31xx.h"

+#define DRIVER_NAME "fsl-asoc-card"
+
=C2=A0#define CS427x_SYSCLK_MCLK 0

=C2=A0#define RX 0
@@ -915,7 +917,7 @@ MODULE_DEVICE_TABLE(of, fsl_asoc_card_dt_ids);
=C2=A0static struct platform_driver fsl_asoc_card_driver =3D {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 .probe =3D fsl_asoc_card_probe,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 .driver =3D {
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0.name =3D "fsl= -asoc-card",
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0.name =3D DRIVER_NA= ME,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 .pm =3D &snd_so= c_pm_ops,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 .of_match_table =3D= fsl_asoc_card_dt_ids,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 },
@@ -924,5 +926,5 @@ module_platform_driver(fsl_asoc_card_driver);

=C2=A0MODULE_DESCRIPTION("Freescale Generic ASoC Sound Card driver wit= h ASRC");
=C2=A0MODULE_AUTHOR("Nicolin Chen <nicoleotsuka@gmail.com>");
-MODULE_ALIAS("platform:fsl-asoc-card");
+MODULE_ALIAS("platform:" DRIVER_NAME);
=C2=A0MODULE_LICENSE("GPL");
--
2.34.1

--00000000000029534405f74fb180--