From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7B1CC433DF for ; Thu, 21 May 2020 11:32:23 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 519CA2072C for ; Thu, 21 May 2020 11:32:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MqYN+vMi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 519CA2072C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49SSC86XThzDqpr for ; Thu, 21 May 2020 21:32:20 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::742; helo=mail-qk1-x742.google.com; envelope-from=shengjiu.wang@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=MqYN+vMi; dkim-atps=neutral Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49SS942r5nzDqR3 for ; Thu, 21 May 2020 21:30:29 +1000 (AEST) Received: by mail-qk1-x742.google.com with SMTP id i5so6742315qkl.12 for ; Thu, 21 May 2020 04:30:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=mVnGuA/c41po031/Zyo9z05iki6LpXCl3bw26UlV5Og=; b=MqYN+vMiHTEaW4UwLRy16WRoYfu+LJ4pOncpItD4O1GRnxH8TmktN6T6b2PcHxyEwB /Ls2IApWVfXgN0RNquNulhQ49MIzfMO2KbQlpew/gmesTLhSAFACIhd9NN5hvF8aTXrJ 9dGZyhMELfyMK2fbiMTxbSKpZ8EVlDN75FSZjN4lYOI29EfHTi0l6te+3DGNqlishUcI ufFCYzDFtCRCTDhyOG4tSbItgT3oIdpuWbG9YF8aGWnFAtPl3K8qizsCVOk3/weuXndt nd8yUP/5mHGC7HDR1cjV9fJCWbl4EUH4bqfDeIq+Fhmmrdj99nMfB4lAH2i7rVf5TT9v sLsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=mVnGuA/c41po031/Zyo9z05iki6LpXCl3bw26UlV5Og=; b=MXCo4qEBiQQibrI/EYPMzBq1ziP5JwRKbkxAQJNqKzEiMe+t+AkXNDXTP4iXjCqSGW hAQIzRcbPQ1zkR8AhslQxKoI2DzbQOoQJ8VjO/ybmR2Zhn5Wr8qqSwrai1j77+yOgyYX ahdV7o+ODS+xciddnSO851Opl8c8Eoou8I099T1v8IQoRPon2yRoTI+yRAPIFy1GbVdF BhbEFGkibjxkkguNgpedO2S6fgN7y9R/OZ9sUc8/bX7O+9bZ94bEyrsZk43LkCxmXPr2 V+sPkxMIu63/C+1Hi1gjbJIqMnBTxydrOoHZuBgCkYtKVpXriYFxja0WdGKxVFBkmXe+ jk7A== X-Gm-Message-State: AOAM531nIcU2NcYbYmCsVWQ6grHEQTRZINaddPtYmD8G/+qid2TSsNTF ItH1DkPz7VGvaXyxZTLTNzMUaeq2cbsUEuQnYXI= X-Google-Smtp-Source: ABdhPJyt/PrPu0HyLCBNIAlcBPVwQP3EdSaZpX3l0+ThMZQ3Nc11G0djVdAg3aM+jm8BukBsG/8Iq0VgME50WXdM3Aw= X-Received: by 2002:a37:a50d:: with SMTP id o13mr9327701qke.121.1590060626064; Thu, 21 May 2020 04:30:26 -0700 (PDT) MIME-Version: 1.0 References: <1589881301-4143-1-git-send-email-shengjiu.wang@nxp.com> <0866cd8cdb0c22f0b2a6814c4dafa29202aad5f3.camel@pengutronix.de> <53258cd99caaf1199036737f8fad6cc097939567.camel@pengutronix.de> <20200520123850.GE4823@sirena.org.uk> In-Reply-To: <20200520123850.GE4823@sirena.org.uk> From: Shengjiu Wang Date: Thu, 21 May 2020 19:30:04 +0800 Message-ID: Subject: Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe To: Mark Brown Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sumit Semwal , linaro-mm-sig@lists.linaro.org, Linux-ALSA , linuxppc-dev@lists.ozlabs.org, linux-kernel , Timur Tabi , Xiubo Li , shawnguo@kernel.org, Shengjiu Wang , Takashi Iwai , Liam Girdwood , dri-devel@lists.freedesktop.org, perex@perex.cz, Nicolin Chen , linux-imx@nxp.com, kernel@pengutronix.de, linux-media@vger.kernel.org, Fabio Estevam , s.hauer@pengutronix.de, linux-arm-kernel@lists.infradead.org, Lucas Stach Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, May 20, 2020 at 8:38 PM Mark Brown wrote: > > On Wed, May 20, 2020 at 07:22:19PM +0800, Shengjiu Wang wrote: > > > I see some driver also request dma channel in open() or hw_params(). > > how can they avoid the defer probe issue? > > for example=EF=BC=9A > > sound/arm/pxa2xx-pcm-lib.c > > sound/soc/sprd/sprd-pcm-dma.c > > Other drivers having problems means those drivers should be fixed, not > that we should copy the problems. In the case of the PXA driver that's > very old code which predates deferred probe by I'd guess a decade. Thanks. For the FE-BE case, do you have any suggestion for how fix it? With DMA1->ASRC->DMA2->ESAI case, the DMA1->ASRC->DMA2 is in FE, ESAI is in BE. When ESAI drvier probe, DMA3 channel is created with ESAI's "dma:tx" (DMA3 channel is not used in this FE-BE case). When FE-BE startup, DMA2 channel is created, it needs the ESAI's "dma:tx", so the warning comes out. best regards wang shengjiu