From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6189AC169C4 for ; Mon, 11 Feb 2019 12:29:57 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9389620818 for ; Mon, 11 Feb 2019 12:29:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="ZzSiAq60" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9389620818 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 43ylV96nM0zDqQV for ; Mon, 11 Feb 2019 23:29:53 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=google.com (client-ip=2607:f8b0:4864:20::644; helo=mail-pl1-x644.google.com; envelope-from=andreyknvl@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="ZzSiAq60"; dkim-atps=neutral Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 43ylPG1dYnzDqMW for ; Mon, 11 Feb 2019 23:25:37 +1100 (AEDT) Received: by mail-pl1-x644.google.com with SMTP id bj4so2573846plb.7 for ; Mon, 11 Feb 2019 04:25:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=sCyib29/TDyxQaimgzlPTWBxPHLjbGAY4DKzfFTRAWk=; b=ZzSiAq60GOu8fxBrqqllxVRdjUj/yTiH33wVnm+ESLsvpz2IauCgZFduqLex/dYQhy 9JhEL5Z0cOO1Jn8J/ucUgpB3bUTWJJgf9JWzQmPOMd8aSOQY28UoDESz0CKyqXtpexR7 FP7B7kWc1H8NNo3XHODNpAVIVXCeDDqzQCEig5O+Zwm/EK95NTyByfQUrU8Z7AwCBaBx NjLtuG2BOrjxkxyzi9TUnCOI51DhX9YIXE1Q1UhXtyGm+fTQmJvLg5uVO6CqZ7eyUuVB 3tvc8X2HyvOpmV7jbFAYNSdVXDjFjmCWalg5f5d7IewSCrSz/xLMsp8tWqkQDa1t8m/d 9VRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=sCyib29/TDyxQaimgzlPTWBxPHLjbGAY4DKzfFTRAWk=; b=N+Dwz6KN5ovZcARaqEHsTSBB9G+lBoV1o9FJT1XAPNvqsom1M+d6/sSqJgOR+Nf6R7 tXbIn1eqPF3Me6BSTiQYe33WGVGeQzLVNlu9oGqaAAD2vUCUcypPPLv3wRMSUELkzt93 eL2B+kVmVh++0TgX3zBwASWVI79+6vrrUBnhz929SMEhuPpUJyIvhYT/5zd/lfwdXErD 7cEtBJb9nQkZBxxxN0I2k3LdKuArGxevJyX+BDHpZeM2cbOp71V5Fq1dnonutc5MkZH2 77nmf9TdiJ08T/kf4YRQSy23WJFSClJeQrUv06Zdz5x6x0EEB7XlIZHXW+XHMy3xWGWn s2zg== X-Gm-Message-State: AHQUAua/U1chzURmt7KYcVVewZwuwm/XuLnJU/fe80VOkSJB2Mp8HSFy ol8VN/TPFxOTcAB8YfpVrsLw0MDKJ1TUEgp5KPySEg== X-Google-Smtp-Source: AHgI3IafbaWIVIfXyO8jrDe376WblbEqEBC/kZg7g+kVGlOk/gdYOd4YBVPGCvm5ZtXHEkF7rgW6Hpx4eq+iCvZdimo= X-Received: by 2002:a17:902:1122:: with SMTP id d31mr37182411pla.246.1549887935379; Mon, 11 Feb 2019 04:25:35 -0800 (PST) MIME-Version: 1.0 References: <1f5629e03181d0e30efc603f00dad78912991a45.1548166824.git.christophe.leroy@c-s.fr> <87ef8i45km.fsf@dja-thinkpad.axtens.net> <69720148-fd19-0810-5a1d-96c45e2ec00c@c-s.fr>

In-Reply-To: From: Andrey Konovalov Date: Mon, 11 Feb 2019 13:25:24 +0100 Message-ID: Subject: Re: [PATCH v4 3/3] powerpc/32: Add KASAN support To: christophe leroy Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: LKML , Nicholas Piggin , Linux Memory Management List , Paul Mackerras , "Aneesh Kumar K.V" , Andrey Ryabinin , Alexander Potapenko , kasan-dev , PowerPC , Dmitry Vyukov , Daniel Axtens Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, Feb 9, 2019 at 12:55 PM christophe leroy wrote: > > Hi Andrey, > > Le 08/02/2019 =C3=A0 18:40, Andrey Konovalov a =C3=A9crit : > > On Fri, Feb 8, 2019 at 6:17 PM Christophe Leroy wrote: > >> > >> Hi Daniel, > >> > >> Le 08/02/2019 =C3=A0 17:18, Daniel Axtens a =C3=A9crit : > >>> Hi Christophe, > >>> > >>> I've been attempting to port this to 64-bit Book3e nohash (e6500), > >>> although I think I've ended up with an approach more similar to Anees= h's > >>> much earlier (2015) series for book3s. > >>> > >>> Part of this is just due to the changes between 32 and 64 bits - we n= eed > >>> to hack around the discontiguous mappings - but one thing that I'm > >>> particularly puzzled by is what the kasan_early_init is supposed to d= o. > >> > >> It should be a problem as my patch uses a 'for_each_memblock(memory, > >> reg)' loop. > >> > >>> > >>>> +void __init kasan_early_init(void) > >>>> +{ > >>>> + unsigned long addr =3D KASAN_SHADOW_START; > >>>> + unsigned long end =3D KASAN_SHADOW_END; > >>>> + unsigned long next; > >>>> + pmd_t *pmd =3D pmd_offset(pud_offset(pgd_offset_k(addr), addr),= addr); > >>>> + int i; > >>>> + phys_addr_t pa =3D __pa(kasan_early_shadow_page); > >>>> + > >>>> + BUILD_BUG_ON(KASAN_SHADOW_START & ~PGDIR_MASK); > >>>> + > >>>> + if (early_mmu_has_feature(MMU_FTR_HPTE_TABLE)) > >>>> + panic("KASAN not supported with Hash MMU\n"); > >>>> + > >>>> + for (i =3D 0; i < PTRS_PER_PTE; i++) > >>>> + __set_pte_at(&init_mm, (unsigned long)kasan_early_shado= w_page, > >>>> + kasan_early_shadow_pte + i, > >>>> + pfn_pte(PHYS_PFN(pa), PAGE_KERNEL_RO), 0); > >>>> + > >>>> + do { > >>>> + next =3D pgd_addr_end(addr, end); > >>>> + pmd_populate_kernel(&init_mm, pmd, kasan_early_shadow_p= te); > >>>> + } while (pmd++, addr =3D next, addr !=3D end); > >>>> +} > >>> > >>> As far as I can tell it's mapping the early shadow page, read-only, o= ver > >>> the KASAN_SHADOW_START->KASAN_SHADOW_END range, and it's using the ea= rly > >>> shadow PTE array from the generic code. > >>> > >>> I haven't been able to find an answer to why this is in the docs, so = I > >>> was wondering if you or anyone else could explain the early part of > >>> kasan init a bit better. > >> > >> See https://www.kernel.org/doc/html/latest/dev-tools/kasan.html for an > >> explanation of the shadow. > >> > >> When shadow is 0, it means the memory area is entirely accessible. > >> > >> It is necessary to setup a shadow area as soon as possible because all > >> data accesses check the shadow area, from the begining (except for a f= ew > >> files where sanitizing has been disabled in Makefiles). > >> > >> Until the real shadow area is set, all access are granted thanks to th= e > >> zero shadow area beeing for of zeros. > > > > Not entirely correct. kasan_early_init() indeed maps the whole shadow > > memory range to the same kasan_early_shadow_page. However as kernel > > loads and memory gets allocated this shadow page gets rewritten with > > non-zero values by different KASAN allocator hooks. Since these values > > come from completely different parts of the kernel, but all land on > > the same page, kasan_early_shadow_page's content can be considered > > garbage. When KASAN checks memory accesses for validity it detects > > these garbage shadow values, but doesn't print any reports, as the > > reporting routine bails out on the current->kasan_depth check (which > > has the value of 1 initially). Only after kasan_init() completes, when > > the proper shadow memory is mapped, current->kasan_depth gets set to 0 > > and we start reporting bad accesses. > > That's surprising, because in the early phase I map the shadow area > read-only, so I do not expect it to get modified unless RO protection is > failing for some reason. Actually it might be that the allocator hooks don't modify shadow at this point, as the allocator is not yet initialized. However stack should be getting poisoned and unpoisoned from the very start. But the generic statement that early shadow gets dirtied should be correct. Might it be that you don't use stack instrumentation? > > Next week I'll add a test in early_init() to check the content of the > early shadow area. > > Christophe > > > > >> > >> I mainly used ARM arch as an exemple when I implemented KASAN for ppc3= 2. > >> > >>> > >>> At the moment, I don't do any early init, and like Aneesh's series fo= r > >>> book3s, I end up needing a special flag to disable kasan until after > >>> kasan_init. Also, as with Balbir's seris for Radix, some tests didn't > >>> fire, although my missing tests are a superset of his. I suspect the > >>> early init has something to do with these...? > >> > >> I think you should really focus on establishing a zero shadow area as > >> early as possible instead of trying to ack the core parts of KASAN. > >> > >>> > >>> (I'm happy to collate answers into a patch to the docs, btw!) > >> > >> We can also have the discussion going via > >> https://github.com/linuxppc/issues/issues/106 > >> > >>> > >>> In the long term I hope to revive Aneesh's and Balbir's series for ha= sh > >>> and radix as well. > >> > >> Great. > >> > >> Christophe > >> > >>> > >>> Regards, > >>> Daniel > >>> > >>>> + > >>>> +static void __init kasan_init_region(struct memblock_region *reg) > >>>> +{ > >>>> + void *start =3D __va(reg->base); > >>>> + void *end =3D __va(reg->base + reg->size); > >>>> + unsigned long k_start, k_end, k_cur, k_next; > >>>> + pmd_t *pmd; > >>>> + > >>>> + if (start >=3D end) > >>>> + return; > >>>> + > >>>> + k_start =3D (unsigned long)kasan_mem_to_shadow(start); > >>>> + k_end =3D (unsigned long)kasan_mem_to_shadow(end); > >>>> + pmd =3D pmd_offset(pud_offset(pgd_offset_k(k_start), k_start), = k_start); > >>>> + > >>>> + for (k_cur =3D k_start; k_cur !=3D k_end; k_cur =3D k_next, pmd= ++) { > >>>> + k_next =3D pgd_addr_end(k_cur, k_end); > >>>> + if ((void *)pmd_page_vaddr(*pmd) =3D=3D kasan_early_sha= dow_pte) { > >>>> + pte_t *new =3D pte_alloc_one_kernel(&init_mm); > >>>> + > >>>> + if (!new) > >>>> + panic("kasan: pte_alloc_one_kernel() fa= iled"); > >>>> + memcpy(new, kasan_early_shadow_pte, PTE_TABLE_S= IZE); > >>>> + pmd_populate_kernel(&init_mm, pmd, new); > >>>> + } > >>>> + }; > >>>> + > >>>> + for (k_cur =3D k_start; k_cur < k_end; k_cur +=3D PAGE_SIZE) { > >>>> + void *va =3D memblock_alloc(PAGE_SIZE, PAGE_SIZE); > >>>> + pte_t pte =3D pfn_pte(PHYS_PFN(__pa(va)), PAGE_KERNEL); > >>>> + > >>>> + if (!va) > >>>> + panic("kasan: memblock_alloc() failed"); > >>>> + pmd =3D pmd_offset(pud_offset(pgd_offset_k(k_cur), k_cu= r), k_cur); > >>>> + pte_update(pte_offset_kernel(pmd, k_cur), ~0, pte_val(p= te)); > >>>> + } > >>>> + flush_tlb_kernel_range(k_start, k_end); > >>>> +} > >>>> + > >>>> +void __init kasan_init(void) > >>>> +{ > >>>> + struct memblock_region *reg; > >>>> + > >>>> + for_each_memblock(memory, reg) > >>>> + kasan_init_region(reg); > >>>> + > >>>> + kasan_init_tags(); > >>>> + > >>>> + /* At this point kasan is fully initialized. Enable error messa= ges */ > >>>> + init_task.kasan_depth =3D 0; > >>>> + pr_info("KASAN init done\n"); > >>>> +} > >>>> diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c > >>>> index 33cc6f676fa6..ae7db88b72d6 100644 > >>>> --- a/arch/powerpc/mm/mem.c > >>>> +++ b/arch/powerpc/mm/mem.c > >>>> @@ -369,6 +369,10 @@ void __init mem_init(void) > >>>> pr_info(" * 0x%08lx..0x%08lx : highmem PTEs\n", > >>>> PKMAP_BASE, PKMAP_ADDR(LAST_PKMAP)); > >>>> #endif /* CONFIG_HIGHMEM */ > >>>> +#ifdef CONFIG_KASAN > >>>> + pr_info(" * 0x%08lx..0x%08lx : kasan shadow mem\n", > >>>> + KASAN_SHADOW_START, KASAN_SHADOW_END); > >>>> +#endif > >>>> #ifdef CONFIG_NOT_COHERENT_CACHE > >>>> pr_info(" * 0x%08lx..0x%08lx : consistent mem\n", > >>>> IOREMAP_TOP, IOREMAP_TOP + CONFIG_CONSISTENT_SIZE); > >>>> -- > >>>> 2.13.3 > >> > >> -- > >> You received this message because you are subscribed to the Google Gro= ups "kasan-dev" group. > >> To unsubscribe from this group and stop receiving emails from it, send= an email to kasan-dev+unsubscribe@googlegroups.com. > >> To post to this group, send email to kasan-dev@googlegroups.com. > >> To view this discussion on the web visit https://groups.google.com/d/m= sgid/kasan-dev/69720148-fd19-0810-5a1d-96c45e2ec00c%40c-s.fr. > >> For more options, visit https://groups.google.com/d/optout. > > --- > L'absence de virus dans ce courrier =C3=A9lectronique a =C3=A9t=C3=A9 v= =C3=A9rifi=C3=A9e par le logiciel antivirus Avast. > https://www.avast.com/antivirus >