From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-x241.google.com (mail-ua0-x241.google.com [IPv6:2607:f8b0:400c:c08::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3tzpms0pCyzDqVx for ; Fri, 13 Jan 2017 01:58:53 +1100 (AEDT) Received: by mail-ua0-x241.google.com with SMTP id i68so1801385uad.1 for ; Thu, 12 Jan 2017 06:58:52 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20170111205514.GI14532@bhelgaas-glaptop.roam.corp.google.com> References: <20161224093800.GA24893@rahul> <20170111205514.GI14532@bhelgaas-glaptop.roam.corp.google.com> From: Rahul Krishnan Date: Thu, 12 Jan 2017 20:28:50 +0530 Message-ID: Subject: Re: [PATCH v2] pci: hotplug: This patch removes unnecessary return statement using spatch tool To: Bjorn Helgaas Cc: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, Bjorn Helgaas , linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: multipart/alternative; boundary=001a114952ee82abc70545e6f4bc List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --001a114952ee82abc70545e6f4bc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, Jan 12, 2017 at 2:25 AM, Bjorn Helgaas wrote: > On Sat, Dec 24, 2016 at 03:08:00PM +0530, Rahul Krishnan wrote: > > > > This patch removes unnecessary return statement using spatch tool > > > > Signed-off-by: Rahul Krishnan > > Applied to pci/hotplug for v4.11 with Tyrel's Reviewed-by, thanks! > > Are there other similar instances elsewhere in drivers/pci? If so, > can you fix them all at once? > =E2=80=8B Yes, I will look into it immediately. Thank you=E2=80=8B > > > --- > > drivers/pci/hotplug/rpadlpar_core.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/ > rpadlpar_core.c > > index dc67f39..78ce2c7 100644 > > --- a/drivers/pci/hotplug/rpadlpar_core.c > > +++ b/drivers/pci/hotplug/rpadlpar_core.c > > @@ -455,7 +455,6 @@ static inline int is_dlpar_capable(void) > > > > int __init rpadlpar_io_init(void) > > { > > - int rc =3D 0; > > > > if (!is_dlpar_capable()) { > > printk(KERN_WARNING "%s: partition not DLPAR capable\n", > > @@ -463,8 +462,7 @@ int __init rpadlpar_io_init(void) > > return -EPERM; > > } > > > > - rc =3D dlpar_sysfs_init(); > > - return rc; > > + return dlpar_sysfs_init(); > > } > > > > void rpadlpar_io_exit(void) > > -- > > 2.7.4 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > --=20 We all know Linux is great... it does infinite loops in 5 seconds. - Linus Torvald Regards, Rahul Krishnan Wordpress --001a114952ee82abc70545e6f4bc Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Thu, Jan 12, 2017 at 2:25 AM, Bjorn Helgaas <helgaas@kernel.org> wrote:
On S= at, Dec 24, 2016 at 03:08:00PM +0530, Rahul Krishnan wrote:
>
> This patch removes unnecessary return statement using spatch tool
>
> Signed-off-by: Rahul Krishnan <mrahul.krishnan@gmail.com>

Applied to pci/hotplug for v4.11 with Tyrel's Reviewed-by, thank= s!

Are there other similar instances elsewhere in drivers/pci?=C2=A0 If so, can you fix them all at once?
=E2=80=8B=C2= =A0=C2=A0
=C2=A0=C2=A0=C2=A0 Yes, I will look into it= immediately. Thank you=E2=80=8B
=C2=A0

> ---
>=C2=A0 drivers/pci/hotplug/rpadlpar_core.c | 4 +---
>=C2=A0 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/ho= tplug/rpadlpar_core.c
> index dc67f39..78ce2c7 100644
> --- a/drivers/pci/hotplug/rpadlpar_core.c
> +++ b/drivers/pci/hotplug/rpadlpar_core.c
> @@ -455,7 +455,6 @@ static inline int is_dlpar_capable(void)
>
>=C2=A0 int __init rpadlpar_io_init(void)
>=C2=A0 {
> -=C2=A0 =C2=A0 =C2=A0int rc =3D 0;
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0if (!is_dlpar_capable()) {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0printk(KERN_WARN= ING "%s: partition not DLPAR capable\n",
> @@ -463,8 +462,7 @@ int __init rpadlpar_io_init(void)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return -EPERM; >=C2=A0 =C2=A0 =C2=A0 =C2=A0}
>
> -=C2=A0 =C2=A0 =C2=A0rc =3D dlpar_sysfs_init();
> -=C2=A0 =C2=A0 =C2=A0return rc;
> +=C2=A0 =C2=A0 =C2=A0return dlpar_sysfs_init();
>=C2=A0 }
>
>=C2=A0 void rpadlpar_io_exit(void)
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-p= ci" in
> the body of a message to = majordomo@vger.kernel.org
> More majordomo info at=C2=A0 http://vger.kernel.org/<= wbr>majordomo-info.html



--
<= div>
We all know Linux is great... it does infinite lo= ops in 5 seconds.
- Linus Torvald


Regards,
Rahul Krishnan
Wordpress
=
--001a114952ee82abc70545e6f4bc--