linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Baluta <daniel.baluta@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Timur Tabi <timur@kernel.org>, Xiubo Li <Xiubo.Lee@gmail.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	"S.j. Wang" <shengjiu.wang@nxp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Daniel Baluta <daniel.baluta@nxp.com>,
	Takashi Iwai <tiwai@suse.com>,
	Nicolin Chen <nicoleotsuka@gmail.com>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Mark Brown <broonie@kernel.org>, dl-linux-imx <linux-imx@nxp.com>,
	Viorel Suman <viorel.suman@nxp.com>,
	Viorel Suman <viorel.suman@gmail.com>,
	Cosmin Samoila <cosmin.samoila@nxp.com>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [alsa-devel] [PATCH v2 4/4] ASoC: add imx-audmix DT binding documentation
Date: Wed, 16 Jan 2019 10:21:52 +0200	[thread overview]
Message-ID: <CAEnQRZBn7nM-KrGSvnzPWuU=a+jyRxfEKhZSsDD4wTqr6spkwg@mail.gmail.com> (raw)
In-Reply-To: <20190115205755.GA4022@bogus>

On Tue, Jan 15, 2019 at 10:58 PM Rob Herring <robh@kernel.org> wrote:
>
> On Tue, Jan 08, 2019 at 01:05:51PM +0000, Viorel Suman wrote:
> > Add the DT binding documentation for Audio Mixer
> > machine driver.
> >
> > Signed-off-by: Viorel Suman <viorel.suman@nxp.com>
> > ---
> >  .../devicetree/bindings/sound/imx-audmix.txt       | 24 ++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/sound/imx-audmix.txt
> >
> > diff --git a/Documentation/devicetree/bindings/sound/imx-audmix.txt b/Documentation/devicetree/bindings/sound/imx-audmix.txt
> > new file mode 100644
> > index 0000000..6ac1230
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/imx-audmix.txt
> > @@ -0,0 +1,24 @@
> > +NXP Audio Mixer (AUDMIX) machine driver.
> > +
> > +Required properties:
> > +===================================
> > +  - compatible               : Compatible list, contains "fsl,imx-audmix"
> > +
> > +  - model            : Short audio card description.
> > +
> > +  - dais             : Must contain a list of phandles to AUDMIX connected
> > +                       DAIs. The current implementation requires two phandles
> > +                       to SAI interfaces to be provided, the first SAI in the
> > +                       list being used to route the AUDMIX output.
> > +
> > +  - audmix-controller        : Must contain the phandle to the AUDMIX device node.
>
> I don't think you need 2 nodes for this as this one is just a virtual
> device. Just add the dais property to the audmix node.

Hi Rob,

Thanks for the suggestion. We want to understand better the reasoning
behind this.

Is it because dais are physically connected to AUDMIX node?

In ALSA we usually add all the components inside the
associated machine driver virtual node.

thanks,
Daniel.

  reply	other threads:[~2019-01-16  8:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-08 13:05 [PATCH v2 0/4] Add NXP AUDMIX device and machine drivers Viorel Suman
2019-01-08 13:05 ` [PATCH v2 1/4] ASoC: fsl: Add Audio Mixer CPU DAI driver Viorel Suman
2019-01-08 13:05 ` [PATCH v2 2/4] ASoC: add fsl_audmix DT binding documentation Viorel Suman
2019-01-15 20:54   ` Rob Herring
2019-01-08 13:05 ` [PATCH v2 3/4] ASoC: fsl: Add Audio Mixer machine driver Viorel Suman
2019-01-08 13:05 ` [PATCH v2 4/4] ASoC: add imx-audmix DT binding documentation Viorel Suman
2019-01-15 20:57   ` Rob Herring
2019-01-16  8:21     ` Daniel Baluta [this message]
2019-01-16 14:57       ` [alsa-devel] " Rob Herring
2019-01-11 19:13 ` [PATCH v2 0/4] Add NXP AUDMIX device and machine drivers Nicolin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEnQRZBn7nM-KrGSvnzPWuU=a+jyRxfEKhZSsDD4wTqr6spkwg@mail.gmail.com' \
    --to=daniel.baluta@gmail.com \
    --cc=Xiubo.Lee@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=cosmin.samoila@nxp.com \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mark.rutland@arm.com \
    --cc=nicoleotsuka@gmail.com \
    --cc=robh@kernel.org \
    --cc=shengjiu.wang@nxp.com \
    --cc=timur@kernel.org \
    --cc=tiwai@suse.com \
    --cc=viorel.suman@gmail.com \
    --cc=viorel.suman@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).