On Fri, Jan 27, 2023 at 3:19=E2=80=AFPM F= angrui Song <maskray@google.com> wrote:

On Thu, Dec 29, 2022 at 11:22 AM Palmer Dabbelt <= ;palmer@dabbelt.com= > wrote:
>
> On Wed, 21 Dec 2022 15:51:47 PST (-0800), maskray@google.com wrote:
> > The actual intention is that no dynamic relocation exists. Howeve= r, some
> > GNU ld ports produce unneeded R_*_NONE. (If a port fails to deter= mine
> > the exact .rel[a].dyn size, the trailing zeros become R_*_NONE > > relocations. E.g. ld's powerpc port recently fixed
> > https://sourceware.org/bugzilla/sho= w_bug.cgi?id=3D29540) R_*_NONE are
> > generally no-op in the dynamic loaders. So just ignore them.
> >
> > With the change, we can remove ARCH_REL_TYPE_ABS. ARCH_REL_TYPE_A= BS is a
> > bit misnomer as ports may check RELAVETIVE/GLOB_DAT/JUMP_SLOT whi= ch are
> > not called "absolute relocations". (The patch is motiva= ted by the arm64
> > port missing R_AARCH64_RELATIVE.)
> >
> > Signed-off-by: Fangrui Song <maskray@google.com>
> > Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> > ---
> > Change from v1:
> > * rebase after 8ac3b5cd3e0521d92f9755e90d140382fc292510 (lib/vdso= : use "grep -E" instead of "egrep")
> > * change the commit message to mention an example GNU ld bug; no = longer say the patch fixes a deprecated egrep use
> > ---
> >=C2=A0 =C2=A0arch/arm/vdso/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 |=C2=A0 3 ---
> >=C2=A0 =C2=A0arch/arm64/kernel/vdso/Makefile=C2=A0 =C2=A0|=C2=A0 3= ---
> >=C2=A0 =C2=A0arch/arm64/kernel/vdso32/Makefile |=C2=A0 3 ---
> >=C2=A0 =C2=A0arch/csky/kernel/vdso/Makefile=C2=A0 =C2=A0 |=C2=A0 3= ---
> >=C2=A0 =C2=A0arch/loongarch/vdso/Makefile=C2=A0 =C2=A0 =C2=A0 |=C2= =A0 3 ---
> >=C2=A0 =C2=A0arch/mips/vdso/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0|=C2=A0 3 ---
> >=C2=A0 =C2=A0arch/powerpc/kernel/vdso/Makefile |=C2=A0 1 -
> >=C2=A0 =C2=A0arch/riscv/kernel/vdso/Makefile=C2=A0 =C2=A0|=C2=A0 3= ---
> >=C2=A0 =C2=A0arch/s390/kernel/vdso32/Makefile=C2=A0 |=C2=A0 2 -- > >=C2=A0 =C2=A0arch/s390/kernel/vdso64/Makefile=C2=A0 |=C2=A0 2 -- > >=C2=A0 =C2=A0arch/x86/entry/vdso/Makefile=C2=A0 =C2=A0 =C2=A0 |=C2= =A0 4 ----
> >=C2=A0 =C2=A0lib/vdso/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0| 13 ++++---------
> >=C2=A0 =C2=A012 files changed, 4 insertions(+), 39 deletions(-) >
> [snip]
>
> > diff --git a/arch/riscv/kernel/vdso/Makefile b/arch/riscv/kernel/= vdso/Makefile
> > index 06e6b27f3bcc..d85c37e11b21 100644
> > --- a/arch/riscv/kernel/vdso/Makefile
> > +++ b/arch/riscv/kernel/vdso/Makefile
> > @@ -1,9 +1,6 @@
> >=C2=A0 =C2=A0# SPDX-License-Identifier: GPL-2.0-only
> >=C2=A0 =C2=A0# Copied from arch/tile/kernel/vdso/Makefile
> >
> > -# Absolute relocation type $(ARCH_REL_TYPE_ABS) needs to be defi= ned before
> > -# the inclusion of generic Makefile.
> > -ARCH_REL_TYPE_ABS :=3D R_RISCV_32|R_RISCV_64|R_RISCV_JUMP_SLOT > >=C2=A0 =C2=A0include $(srctree)/lib/vdso/Makefile
> >=C2=A0 =C2=A0# Symbols present in the vdso
> >=C2=A0 =C2=A0vdso-syms=C2=A0 =3D rt_sigreturn
>
> Acked-by: Palmer Dabbelt <palmer@rivosinc.com> # RISC-V
>
> Thanks!

Looks like this patch hasn't been picked yet...

Ping:)

<= br>

=E5=AE=8B=E6=96=B9=E7=9D=BF<= /div>

--00000000000011c46d05f66b2f9c--