From: Kees Cook <keescook@chromium.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Colin King <colin.king@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
PowerPC <linuxppc-dev@lists.ozlabs.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] lib: fix build failure in CONFIG_DEBUG_VIRTUAL test
Date: Mon, 10 Dec 2018 09:46:37 -0800 [thread overview]
Message-ID: <CAGXu5jLfNf8NDyZS3jQB=XU9ihs_xg-UBZzFAB7fZaMSaMSPXQ@mail.gmail.com> (raw)
In-Reply-To: <40d63adb6058b1fbb4082ca6f15225cb6e76bd62.1544429175.git.christophe.leroy@c-s.fr>
On Mon, Dec 10, 2018 at 12:08 AM Christophe Leroy
<christophe.leroy@c-s.fr> wrote:
>
> On several arches, virt_to_phys() is in io.h
>
> Build fails without it:
>
> CC lib/test_debug_virtual.o
> lib/test_debug_virtual.c: In function 'test_debug_virtual_init':
> lib/test_debug_virtual.c:26:7: error: implicit declaration of function 'virt_to_phys' [-Werror=implicit-function-declaration]
> pa = virt_to_phys(va);
> ^
>
> Fixes: e4dace361552 ("lib: add test module for CONFIG_DEBUG_VIRTUAL")
> CC: stable@vger.kernel.org
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> lib/test_debug_virtual.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/test_debug_virtual.c b/lib/test_debug_virtual.c
> index d5a06addeb27..bf864c73e462 100644
> --- a/lib/test_debug_virtual.c
> +++ b/lib/test_debug_virtual.c
> @@ -5,6 +5,7 @@
> #include <linux/vmalloc.h>
> #include <linux/slab.h>
> #include <linux/sizes.h>
> +#include <linux/io.h>
>
> #include <asm/page.h>
> #ifdef CONFIG_MIPS
> --
> 2.13.3
>
--
Kees Cook
next prev parent reply other threads:[~2018-12-10 17:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 8:08 [PATCH] lib: fix build failure in CONFIG_DEBUG_VIRTUAL test Christophe Leroy
2018-12-10 17:46 ` Kees Cook [this message]
2018-12-13 3:09 ` Michael Ellerman
2018-12-22 9:54 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXu5jLfNf8NDyZS3jQB=XU9ihs_xg-UBZzFAB7fZaMSaMSPXQ@mail.gmail.com' \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=christophe.leroy@c-s.fr \
--cc=colin.king@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).