From: Paul Moore <paul@paul-moore.com>
To: Nathan Lynch <nathanl@linux.ibm.com>
Cc: ajd@linux.ibm.com, nayna@linux.ibm.com,
linux-kernel@vger.kernel.org, jmorris@namei.org,
linux-security-module@vger.kernel.org, gcwilson@linux.ibm.com,
linuxppc-dev@lists.ozlabs.org, serge@hallyn.com
Subject: Re: [PATCH v2 2/2] powerpc/rtas: block error injection when locked down
Date: Mon, 26 Sep 2022 18:41:21 -0400 [thread overview]
Message-ID: <CAHC9VhS9kJ4aEp_Y_imcsj_0JOn523Au=ct6uQEPjNDVVjYxVg@mail.gmail.com> (raw)
In-Reply-To: <20220926131643.146502-3-nathanl@linux.ibm.com>
On Mon, Sep 26, 2022 at 9:18 AM Nathan Lynch <nathanl@linux.ibm.com> wrote:
>
> The error injection facility on pseries VMs allows corruption of
> arbitrary guest memory, potentially enabling a sufficiently privileged
> user to disable lockdown or perform other modifications of the running
> kernel via the rtas syscall.
>
> Block the PAPR error injection facility from being opened or called
> when locked down.
>
> Signed-off-by: Nathan Lynch <nathanl@linux.ibm.com>
> ---
> arch/powerpc/kernel/rtas.c | 25 ++++++++++++++++++++++++-
> include/linux/security.h | 1 +
> security/security.c | 1 +
> 3 files changed, 26 insertions(+), 1 deletion(-)
The lockdown changes are trivial, but they look fine to me.
Acked-by: Paul Moore <paul@paul-moore.com> (LSM)
--
paul-moore.com
next prev parent reply other threads:[~2022-09-26 22:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 13:16 [PATCH v2 0/2] powerpc/pseries: restrict error injection and DT changes when locked down Nathan Lynch
2022-09-26 13:16 ` [PATCH v2 1/2] powerpc/pseries: block untrusted device tree " Nathan Lynch
2022-09-26 22:39 ` Paul Moore
2022-09-28 9:51 ` Andrew Donnellan
2022-09-26 13:16 ` [PATCH v2 2/2] powerpc/rtas: block error injection " Nathan Lynch
2022-09-26 22:41 ` Paul Moore [this message]
2022-09-28 10:02 ` Andrew Donnellan
2022-09-28 16:23 ` Nathan Lynch
2022-10-04 13:25 ` [PATCH v2 0/2] powerpc/pseries: restrict error injection and DT changes " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHC9VhS9kJ4aEp_Y_imcsj_0JOn523Au=ct6uQEPjNDVVjYxVg@mail.gmail.com' \
--to=paul@paul-moore.com \
--cc=ajd@linux.ibm.com \
--cc=gcwilson@linux.ibm.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nathanl@linux.ibm.com \
--cc=nayna@linux.ibm.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).