From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 046FDC43331 for ; Sat, 7 Sep 2019 17:53:00 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7302C21871 for ; Sat, 7 Sep 2019 17:52:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="O0k0d7lq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7302C21871 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46Qhpx32YhzDqc6 for ; Sun, 8 Sep 2019 03:52:57 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linuxfoundation.org (client-ip=2a00:1450:4864:20::142; helo=mail-lf1-x142.google.com; envelope-from=torvalds@linuxfoundation.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="O0k0d7lq"; dkim-atps=neutral Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46Qhn24BDhzDqby for ; Sun, 8 Sep 2019 03:51:17 +1000 (AEST) Received: by mail-lf1-x142.google.com with SMTP id y4so7474530lfe.11 for ; Sat, 07 Sep 2019 10:51:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JJRFoANDdA7LVjR/dXOt13NCYJCwAkkvMBjFRYL2CJk=; b=O0k0d7lqzfAmPEYFzDlOGgQsR12LVtrvxo5oTKj/qTWwdx05EQgXW+UipRXAFcHY7l NJSN5sB8Bd0GzZnsutsLrlnHa03N+sVzppgC400AeuuF3leAik8ua94YYTL1N/jeDSEY p0NLqzIjW/MddvLJPDdxPws4zfzc5nCUgJ+sc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JJRFoANDdA7LVjR/dXOt13NCYJCwAkkvMBjFRYL2CJk=; b=mae6UGmiE/q45zgAC8DBviCa2z86tLRBa0xa4hpNkKhmuq+7HG4RR5nLZO+WxCIBRJ FrZ+uCdYdAYCMrhze5zphDC47thQf4Y1htTOhndHndPvaqV0Dm4g5KNhQRijxYpkqbfT XjXwXAMKM58ujkFX0eyiw3pRu/cQiM7PE+0WpdgnMZdx0PL/tLcB6ZiOSxylXU0EdI+8 Xp+AYjCnMMLn+0c/wYXcee6t87ZDFfffba8fwa88N6oM7hvtnYWIUv1N7YZ8gEufVHsB 5eeVAiBr61bs85ifpz6QJppbKVwqTG3l8s7PaGct+elwldZboj8EEuSvboyUGvV7d0J9 NsSQ== X-Gm-Message-State: APjAAAV8g+9f+7P/QvYTBxC8R1NKA8alB/QGyD3IaqgjM9yFMJJm/mAx kcVhmm0DscSk4oMy3XmewC7ZXAfkqL8= X-Google-Smtp-Source: APXvYqyW0JT6S/kgbSJpeHNbz344NR3Y2Tk7jYOtL74JDNnOIpp1/IrDO03Kz0FxQcf+DTrJ2l5VQA== X-Received: by 2002:ac2:59c2:: with SMTP id x2mr9701182lfn.125.1567878672143; Sat, 07 Sep 2019 10:51:12 -0700 (PDT) Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com. [209.85.208.171]) by smtp.gmail.com with ESMTPSA id z72sm1566422ljb.98.2019.09.07.10.51.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Sep 2019 10:51:11 -0700 (PDT) Received: by mail-lj1-f171.google.com with SMTP id l1so8874212lji.12 for ; Sat, 07 Sep 2019 10:51:11 -0700 (PDT) X-Received: by 2002:a2e:8645:: with SMTP id i5mr9691835ljj.165.1567878349245; Sat, 07 Sep 2019 10:45:49 -0700 (PDT) MIME-Version: 1.0 References: <20190904201933.10736-1-cyphar@cyphar.com> <20190904201933.10736-12-cyphar@cyphar.com> <7236f382d72130f2afbbe8940e72cc67e5c6dce0.camel@kernel.org> In-Reply-To: From: Linus Torvalds Date: Sat, 7 Sep 2019 10:45:33 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v12 11/12] open: openat2(2) syscall To: Andy Lutomirski Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-ia64@vger.kernel.org, Linux-sh list , Peter Zijlstra , Rasmus Villemoes , Alexei Starovoitov , Linux List Kernel Mailing , David Howells , "open list:KERNEL SELFTEST FRAMEWORK" , sparclinux@vger.kernel.org, Shuah Khan , linux-arch , linux-s390 , Tycho Andersen , Aleksa Sarai , Jiri Olsa , Alexander Shishkin , Ingo Molnar , Linux ARM , linux-mips@vger.kernel.org, linux-xtensa@linux-xtensa.org, Kees Cook , Arnd Bergmann , Jann Horn , Aleksa Sarai , Al Viro , Andy Lutomirski , Shuah Khan , Namhyung Kim , David Drysdale , Christian Brauner , "J. Bruce Fields" , linux-parisc@vger.kernel.org, linux-m68k , Linux API , Chanho Min , Jeff Layton , Oleg Nesterov , Eric Biederman , alpha , linux-fsdevel , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Linux Containers Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, Sep 7, 2019 at 10:42 AM Andy Lutomirski wrote: > > Linus, you rejected resolveat() because you wanted a *nice* API No. I rejected resoveat() because it was a completely broken garbage API that couldn't do even basic stuff right (like O_CREAT). We have a ton of flag space in the new openat2() model, we might as well leave the old flags alone that people are (a) used to and (b) we have code to support _anyway_. Making up a new flag namespace is only going to cause us - and users - more work, and more confusion. For no actual advantage. It's not going to be "cleaner". It's just going to be worse. Linus