From: Linus Torvalds <torvalds@linux-foundation.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
PowerPC <linuxppc-dev@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build failure in Linus' tree
Date: Sun, 27 Mar 2022 15:31:46 -0700 [thread overview]
Message-ID: <CAHk-=wiqZaY0oZ86fJtpZSfCJJ48xqC0jjRC4m6WWrnL7q5Leg@mail.gmail.com> (raw)
In-Reply-To: <CAHk-=whGmZrYZ=YdcjeJbpviUTShj0NOiG2q-3d1-RJtz6vBPQ@mail.gmail.com>
-#endif /* CONFIG_LIVEPATCH */
On Sun, Mar 27, 2022 at 3:23 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> I even *looked* at that code when merging, and convinced myself I had
> gotten the #ifdef/#endif chain right. Apparently I can't count.
>
> What a maroon I am.
Oh, and I see why I screwed up: I even did a "git diff" against the
original powerpc tree, but then I visually matched
-#define klp_get_ftrace_location klp_get_ftrace_location
...
-#endif /* CONFIG_LIVEPATCH */
as a #ifdef/#endif pair.
Now that I look at it knowing that I screwed up, I go "Duh!".
Time to take my meds,
Linus
next prev parent reply other threads:[~2022-03-27 22:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-27 22:01 linux-next: build failure in Linus' tree Stephen Rothwell
2022-03-27 22:23 ` Linus Torvalds
2022-03-27 22:31 ` Linus Torvalds [this message]
2022-03-27 23:33 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2020-11-23 7:40 Stephen Rothwell
2020-11-23 23:39 ` Michael Ellerman
2020-11-24 0:23 ` Daniel Axtens
2020-11-25 2:47 ` Michael Ellerman
2018-06-12 2:26 Stephen Rothwell
2018-06-18 3:50 ` Stephen Rothwell
2011-08-29 0:44 Stephen Rothwell
2011-08-29 22:32 ` Stephen Rothwell
2011-08-29 22:50 ` James Bottomley
2010-10-06 0:09 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wiqZaY0oZ86fJtpZSfCJJ48xqC0jjRC4m6WWrnL7q5Leg@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).