From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72F8FC433B4 for ; Thu, 15 Apr 2021 17:20:48 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 088B36117A for ; Thu, 15 Apr 2021 17:20:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 088B36117A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FLmML4r1Tz3dGf for ; Fri, 16 Apr 2021 03:20:46 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=sZMHlhHO; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::632; helo=mail-pl1-x632.google.com; envelope-from=andy.shevchenko@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=sZMHlhHO; dkim-atps=neutral Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FLmKX22Yfz3bxh for ; Fri, 16 Apr 2021 03:19:11 +1000 (AEST) Received: by mail-pl1-x632.google.com with SMTP id p16so8494494plf.12 for ; Thu, 15 Apr 2021 10:19:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=8a04NZRtQScmgjBHOwbl/yFtfKtVthaZ/Hnily7UrCw=; b=sZMHlhHOU+xc4n8FPvxaAa+E0NTQTmyghhvxpESoKgjXzKi1k+qc9uquNBtg9hVddS z3M/fCvYprkqPl2LRyAECaO3XSv85TRvN4A/BFM6YjIC+xIlKa78AOMGuBMmW5axXmS9 M9/AaXZBOFjIDDxQ0a1PdpygCWQpxryatlidL25bEAZQRjEgrVHCO6go+UFbYcco62H5 a4I71OFriBDb8dGwAHhEhMrWaKxK4AZR5wCCN3jEVytsMXYm0KLQzqC0XqsC4Yz9rLHx xjtH8lPEwOsnC3VEogoNaUvnI6FktMv1krkMdxY07Q6aMr0X8Y/OOJKviqsZLO/mqZH2 d1/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=8a04NZRtQScmgjBHOwbl/yFtfKtVthaZ/Hnily7UrCw=; b=eiw3gjPdhKoEiF82j1HBduEK160pHhprcsteCIcNSQARETSYwwFuE/QMXLy39X4yvK lVijZIjsen9cJGdSAEj9B70U7cc3te+aUS+oGzfKvWNIYPRYDhBmAsb3ZL/5lGop2rz6 Qb/4+aB94GDBx71lQ3dpaQETYoE69c1IeiBgcSQYxxLO1xDgM9g5vQJtFilNyjcmUj1R aM7sVgseCQ471mvYE0yo6jVZURw0NCTg3BDwW9PI5V7hCtwDnHXjisX+KGe35pKh9OyV smvfVlWp7m1hwoOYAGTzhUXf/78WGhHKLdtpPq6ZEya4x/DHQdnkp2w0tvU5Zi5f9F4e 6+ag== X-Gm-Message-State: AOAM531s+edb5n/TtN9jsZQxqkI7fNXOmh1Xl+mBQtqoOZtTFoVzj73g HbZVuq6bD8aimWxeLjVOkgGWnAvuWo0i/am+/rs= X-Google-Smtp-Source: ABdhPJzCwBCGWG/Tzyck7Lf3AD0CL7doHhTFOrbl/SO6fEKkdBuHsyBziigBUUwlbTl8K/Sogznec33DsY81TRdW8B4= X-Received: by 2002:a17:90a:156:: with SMTP id z22mr5256977pje.181.1618507145950; Thu, 15 Apr 2021 10:19:05 -0700 (PDT) MIME-Version: 1.0 References: <20210415134637.17770-1-andriy.shevchenko@linux.intel.com> <87eefblbji.fsf@vajain21.in.ibm.com> In-Reply-To: <87eefblbji.fsf@vajain21.in.ibm.com> From: Andy Shevchenko Date: Thu, 15 Apr 2021 20:18:49 +0300 Message-ID: Subject: Re: [PATCH v1 1/1] powerpc/papr_scm: Properly handle UUID types and API To: Vaibhav Jain Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux Kernel Mailing List , Paul Mackerras , "Aneesh Kumar K . V" , Oliver O'Halloran , Andy Shevchenko , "open list:LINUX FOR POWERPC PA SEMI PWRFICIENT" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Apr 15, 2021 at 8:10 PM Vaibhav Jain wrote: > > > Thanks for the patch Andy, > > Unfortunately ran into a compilation issue due to missing "#include > " that provides definition for > get_unaligned_le64(). Gcc reported following error: > > error: implicit declaration of function =E2=80=98get_unaligned_le64=E2=80= =99 Right, I have not tested it (as mentioned in the comments to the patch) > After including the necessary header file, kernel compiled fine and I > was able to test & verify the patch. Thank you very much for the testing. I'm not sure what the coverage of your test is. That's why I have an additional question below. Is the byte ordering kept the same in BE (32- and 64-bit) cases? Because I'm worrying that I might have missed something. --=20 With Best Regards, Andy Shevchenko