Re: [PATCH v1 1/1] kernel.h: Split out panic and oops helpers

From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Corey Minyard <cminyard@mvista.com>,
	Linux on Hyper-V List <linux-hyperv@vger.kernel.org>,
	Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	linux-remoteproc@vger.kernel.org,
	Michael Kelley <mikelley@microsoft.com>,
	Paul Mackerras <paulus@samba.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Joel Fernandes <joel@joelfernandes.org>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linux-Arch <linux-arch@vger.kernel.org>,
	Wei Liu <wei.liu@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Corey Minyard <minyard@acm.org>,
	"maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)"
	<x86@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Iurii Zaikin <yzaikin@google.com>,
	Ohad Ben-Cohen <ohad@wizery.com>, Joerg Roedel <jroedel@suse.de>,
	Kees Cook <keescook@chromium.org>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Josh Triplett <josh@joshtriplett.org>,
	"Steven Rostedt \(VMware\)" <rostedt@goodmis.org>,
	rcu@vger.kernel.org, Borislav Petkov <bp@alien8.de>,
	openipmi-developer@lists.sourceforge.net,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Vlastimil Babka <vbabka@suse.cz>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	kexec@lists.infradead.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Eric Biederman <ebiederm@xmission.com>,
	Linux FS Devel <linux-fsdevel@vger.kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"open list:LINUX FOR POWERPC PA SEMI PWRFICIENT"
	<linuxppc-dev@lists.ozlabs.org>, Mike Rapoport <rppt@kernel.org>
Subject: Re: [PATCH v1 1/1] kernel.h: Split out panic and oops helpers
Date: Wed, 7 Apr 2021 10:33:44 +0300	[thread overview]
Message-ID: <CAHp75Ve9vBQqSegM2-ch9NUN-MdevxxOs5ZdHkk1W7AacN+Wrw@mail.gmail.com> (raw)
In-Reply-To: <20210406165108.GA4332@42.do-not-panic.com>

On Wed, Apr 7, 2021 at 10:25 AM Luis Chamberlain <mcgrof@kernel.org> wrote:
>
> On Tue, Apr 06, 2021 at 04:31:58PM +0300, Andy Shevchenko wrote:
> > diff --git a/include/linux/panic_notifier.h b/include/linux/panic_notifier.h
> > new file mode 100644
> > index 000000000000..41e32483d7a7
> > --- /dev/null
> > +++ b/include/linux/panic_notifier.h
> > @@ -0,0 +1,12 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +#ifndef _LINUX_PANIC_NOTIFIERS_H
> > +#define _LINUX_PANIC_NOTIFIERS_H
> > +
> > +#include <linux/notifier.h>
> > +#include <linux/types.h>
> > +
> > +extern struct atomic_notifier_head panic_notifier_list;
> > +
> > +extern bool crash_kexec_post_notifiers;
> > +
> > +#endif       /* _LINUX_PANIC_NOTIFIERS_H */
>
> Why is it worth it to add another file just for this?

The main point is to break tons of loops that prevent having clean
headers anymore.

In this case, see bug.h, which is very important in this sense.

>  Seems like a very
> small file.

If it is an argument, it's kinda strange. We have much smaller headers.

-- 
With Best Regards,
Andy Shevchenko