From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-x230.google.com (mail-qt0-x230.google.com [IPv6:2607:f8b0:400d:c0d::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4201Hx6QWCzDr5Y for ; Tue, 28 Aug 2018 17:54:53 +1000 (AEST) Received: by mail-qt0-x230.google.com with SMTP id o15-v6so667757qtk.6 for ; Tue, 28 Aug 2018 00:54:52 -0700 (PDT) MIME-Version: 1.0 References: <20180828015252.28511-1-robh@kernel.org> <20180828015252.28511-50-robh@kernel.org> In-Reply-To: <20180828015252.28511-50-robh@kernel.org> From: Andy Shevchenko Date: Tue, 28 Aug 2018 10:54:39 +0300 Message-ID: Subject: Re: [PATCH] sound: Convert to using %pOFn instead of device_node.name To: Rob Herring Cc: Linux Kernel Mailing List , Johannes Berg , Jaroslav Kysela , Takashi Iwai , "open list:LINUX FOR POWERPC PA SEMI PWRFICIENT" , ALSA Development Mailing List Content-Type: text/plain; charset="UTF-8" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Aug 28, 2018 at 4:56 AM Rob Herring wrote: > > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > + if (snprintf(node_name, sizeof(node_name), "%pOFn", np) != 5) > return 0; > + if (strncmp(np, "i2s-", 4)) > return 0; Shouldn't be node_name here? -- With Best Regards, Andy Shevchenko