From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=EHb9=YY=lists.ozlabs.org=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,
	SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id DA69ECA9EC7
	for <linuxppc-dev@archiver.kernel.org>; Thu, 31 Oct 2019 01:36:05 +0000 (UTC)
Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mail.kernel.org (Postfix) with ESMTPS id 83FCB20856
	for <linuxppc-dev@archiver.kernel.org>; Thu, 31 Oct 2019 01:36:05 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="bepu0HQt"
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83FCB20856
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=socionext.com
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org
Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])
	by lists.ozlabs.org (Postfix) with ESMTP id 473SZq1R0pzF5Kg
	for <linuxppc-dev@archiver.kernel.org>; Thu, 31 Oct 2019 12:36:03 +1100 (AEDT)
Authentication-Results: lists.ozlabs.org;
 spf=softfail (domain owner discourages use of this
 host) smtp.mailfrom=socionext.com (client-ip=210.131.2.80;
 helo=conssluserg-01.nifty.com; envelope-from=yamada.masahiro@socionext.com;
 receiver=<UNKNOWN>)
Authentication-Results: lists.ozlabs.org;
 dmarc=none (p=none dis=none) header.from=socionext.com
Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key;
 unprotected) header.d=nifty.com header.i=@nifty.com header.b="bepu0HQt"; 
 dkim-atps=neutral
Received: from conssluserg-01.nifty.com (conssluserg-01.nifty.com
 [210.131.2.80])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.ozlabs.org (Postfix) with ESMTPS id 473SXR2PqbzF5Br
 for <linuxppc-dev@lists.ozlabs.org>; Thu, 31 Oct 2019 12:33:57 +1100 (AEDT)
Received: from mail-ua1-f48.google.com (mail-ua1-f48.google.com
 [209.85.222.48]) (authenticated)
 by conssluserg-01.nifty.com with ESMTP id x9V1Xbbd024232
 for <linuxppc-dev@lists.ozlabs.org>; Thu, 31 Oct 2019 10:33:37 +0900
DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com x9V1Xbbd024232
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com;
 s=dec2015msa; t=1572485618;
 bh=bp/M0yoU6XWG5FGhAIb3TMzMqQxSrCJgCA1yn97kfsQ=;
 h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
 b=bepu0HQtj2km9tsJjGfmcHRWgvBCy9PQixDLI2BqNjDpxR1mZXkyqL2hzJ+k+tDCK
 OgNeX5mD3j73WVVzLx33CKIPSSPcNvmqYoc5BnwPjqqn2Fb0wI7MxYeYoi6BdOcBKc
 hVqxXg3g8jPHBjwbaUiId4bJbTBUFIFQl8mvVKQiY2khMN4dhhi2D9wG196759fMoJ
 VKllNk/zKoN0r+hcC6mXXFB6v6gt8X3YByaYkb5a6vB8gfJUCIS7z/66QfvqTkUIE3
 dePXmDHyI001G8xbn4j+CFAv3XZQ9m6TiqnWmaKeqBl74g60NsDAJNyDK3kFizXYLS
 iNVrUZ44E/TTg==
X-Nifty-SrcIP: [209.85.222.48]
Received: by mail-ua1-f48.google.com with SMTP id u99so1358002uau.5
 for <linuxppc-dev@lists.ozlabs.org>; Wed, 30 Oct 2019 18:33:37 -0700 (PDT)
X-Gm-Message-State: APjAAAXlN6Y6JiUWYICnAbXR7LAGEbE8wJqKAxa718L1y4Ic8ND0i5bO
 FkUAvtXJPiFOa6buvTXu4Y3FIwSCF91NY8cR0sg=
X-Google-Smtp-Source: APXvYqxc81LFapL9jQbAl/Jp9jDTGPd6bpNwimzNFfq1NBu7iKu4HEBediwWwcQA2Kk4XZiEWac1rp11E96eb0HJ1Sw=
X-Received: by 2002:ab0:710a:: with SMTP id x10mr1550343uan.25.1572485616550; 
 Wed, 30 Oct 2019 18:33:36 -0700 (PDT)
MIME-Version: 1.0
References: <20191030063855.9989-1-yamada.masahiro@socionext.com>
In-Reply-To: <20191030063855.9989-1-yamada.masahiro@socionext.com>
From: Masahiro Yamada <yamada.masahiro@socionext.com>
Date: Thu, 31 Oct 2019 10:33:00 +0900
X-Gmail-Original-Message-ID: <CAK7LNASrZpJ0J7N_YvSza2QQ_cQQ+Z04Cf5-Or4ivKMb9UVuMQ@mail.gmail.com>
Message-ID: <CAK7LNASrZpJ0J7N_YvSza2QQ_cQQ+Z04Cf5-Or4ivKMb9UVuMQ@mail.gmail.com>
Subject: Re: [PATCH 1/3] arch: ipcbuf.h: make uapi asm/ipcbuf.h self-contained
To: Andrew Morton <akpm@linux-foundation.org>,
 linux-arch <linux-arch@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-BeenThere: linuxppc-dev@lists.ozlabs.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.lists.ozlabs.org>
List-Unsubscribe: <https://lists.ozlabs.org/options/linuxppc-dev>,
 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/linuxppc-dev/>
List-Post: <mailto:linuxppc-dev@lists.ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/linuxppc-dev>,
 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>
Cc: linux-s390 <linux-s390@vger.kernel.org>, Arnd Bergmann <arnd@arndb.de>,
 X86 ML <x86@kernel.org>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 linux-mips@vger.kernel.org, sparclinux <sparclinux@vger.kernel.org>,
 linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org
Sender: "Linuxppc-dev"
 <linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org>

Hi Andrew,

I think this patch has already been picked up to your tree,
but I noticed a typo in the commit message just now.
Please see below.

On Wed, Oct 30, 2019 at 3:40 PM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> The user-space cannot compile <asm/ipcbuf.h> due to some missing type
> definitions. For example, building it for x86 fails as follows:
>
>   CC      usr/include/asm/ipcbuf.h.s
> In file included from ./usr/include/asm/ipcbuf.h:1:0,
>                  from <command-line>:32:
> ./usr/include/asm-generic/ipcbuf.h:21:2: error: unknown type name =E2=80=
=98__kernel_key_t=E2=80=99
>   __kernel_key_t  key;
>   ^~~~~~~~~~~~~~
> ./usr/include/asm-generic/ipcbuf.h:22:2: error: unknown type name =E2=80=
=98__kernel_uid32_t=E2=80=99
>   __kernel_uid32_t uid;
>   ^~~~~~~~~~~~~~~~
> ./usr/include/asm-generic/ipcbuf.h:23:2: error: unknown type name =E2=80=
=98__kernel_gid32_t=E2=80=99
>   __kernel_gid32_t gid;
>   ^~~~~~~~~~~~~~~~
> ./usr/include/asm-generic/ipcbuf.h:24:2: error: unknown type name =E2=80=
=98__kernel_uid32_t=E2=80=99
>   __kernel_uid32_t cuid;
>   ^~~~~~~~~~~~~~~~
> ./usr/include/asm-generic/ipcbuf.h:25:2: error: unknown type name =E2=80=
=98__kernel_gid32_t=E2=80=99
>   __kernel_gid32_t cgid;
>   ^~~~~~~~~~~~~~~~
> ./usr/include/asm-generic/ipcbuf.h:26:2: error: unknown type name =E2=80=
=98__kernel_mode_t=E2=80=99
>   __kernel_mode_t  mode;
>   ^~~~~~~~~~~~~~~
> ./usr/include/asm-generic/ipcbuf.h:28:35: error: =E2=80=98__kernel_mode_t=
=E2=80=99 undeclared here (not in a function)
>   unsigned char  __pad1[4 - sizeof(__kernel_mode_t)];
>                                    ^~~~~~~~~~~~~~~
> ./usr/include/asm-generic/ipcbuf.h:31:2: error: unknown type name =E2=80=
=98__kernel_ulong_t=E2=80=99
>   __kernel_ulong_t __unused1;
>   ^~~~~~~~~~~~~~~~
> ./usr/include/asm-generic/ipcbuf.h:32:2: error: unknown type name =E2=80=
=98__kernel_ulong_t=E2=80=99
>   __kernel_ulong_t __unused2;
>   ^~~~~~~~~~~~~~~~
>
> It is just a matter of missing include directive.
>
> Include <asm/posix_types.h> to make it self-contained, and add it to

Include <linux/posix_type.h> to make ...

Could you please fix it up locally?


Thank you.
Masahiro Yamada



> the compile-test coverage.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>  arch/s390/include/uapi/asm/ipcbuf.h   | 2 ++
>  arch/sparc/include/uapi/asm/ipcbuf.h  | 2 ++
>  arch/xtensa/include/uapi/asm/ipcbuf.h | 2 ++
>  include/uapi/asm-generic/ipcbuf.h     | 2 ++
>  usr/include/Makefile                  | 1 -
>  5 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/arch/s390/include/uapi/asm/ipcbuf.h b/arch/s390/include/uapi=
/asm/ipcbuf.h
> index 5b1c4f47c656..1030cd186899 100644
> --- a/arch/s390/include/uapi/asm/ipcbuf.h
> +++ b/arch/s390/include/uapi/asm/ipcbuf.h
> @@ -2,6 +2,8 @@
>  #ifndef __S390_IPCBUF_H__
>  #define __S390_IPCBUF_H__
>
> +#include <linux/posix_types.h>
> +
>  /*
>   * The user_ipc_perm structure for S/390 architecture.
>   * Note extra padding because this structure is passed back and forth
> diff --git a/arch/sparc/include/uapi/asm/ipcbuf.h b/arch/sparc/include/ua=
pi/asm/ipcbuf.h
> index 9d0d125500e2..5b933a598a33 100644
> --- a/arch/sparc/include/uapi/asm/ipcbuf.h
> +++ b/arch/sparc/include/uapi/asm/ipcbuf.h
> @@ -2,6 +2,8 @@
>  #ifndef __SPARC_IPCBUF_H
>  #define __SPARC_IPCBUF_H
>
> +#include <linux/posix_types.h>
> +
>  /*
>   * The ipc64_perm structure for sparc/sparc64 architecture.
>   * Note extra padding because this structure is passed back and forth
> diff --git a/arch/xtensa/include/uapi/asm/ipcbuf.h b/arch/xtensa/include/=
uapi/asm/ipcbuf.h
> index a57afa0b606f..3bd0642f6660 100644
> --- a/arch/xtensa/include/uapi/asm/ipcbuf.h
> +++ b/arch/xtensa/include/uapi/asm/ipcbuf.h
> @@ -12,6 +12,8 @@
>  #ifndef _XTENSA_IPCBUF_H
>  #define _XTENSA_IPCBUF_H
>
> +#include <linux/posix_types.h>
> +
>  /*
>   * Pad space is left for:
>   * - 32-bit mode_t and seq
> diff --git a/include/uapi/asm-generic/ipcbuf.h b/include/uapi/asm-generic=
/ipcbuf.h
> index 7d80dbd336fb..41a01b494fc7 100644
> --- a/include/uapi/asm-generic/ipcbuf.h
> +++ b/include/uapi/asm-generic/ipcbuf.h
> @@ -2,6 +2,8 @@
>  #ifndef __ASM_GENERIC_IPCBUF_H
>  #define __ASM_GENERIC_IPCBUF_H
>
> +#include <linux/posix_types.h>
> +
>  /*
>   * The generic ipc64_perm structure:
>   * Note extra padding because this structure is passed back and forth
> diff --git a/usr/include/Makefile b/usr/include/Makefile
> index 57b20f7b6729..70f8fe256aed 100644
> --- a/usr/include/Makefile
> +++ b/usr/include/Makefile
> @@ -16,7 +16,6 @@ override c_flags =3D $(UAPI_CFLAGS) -Wp,-MD,$(depfile) =
-I$(objtree)/usr/include
>  # Please consider to fix the header first.
>  #
>  # Sorted alphabetically.
> -header-test- +=3D asm/ipcbuf.h
>  header-test- +=3D asm/msgbuf.h
>  header-test- +=3D asm/sembuf.h
>  header-test- +=3D asm/shmbuf.h
> --
> 2.17.1
>


--=20
Best Regards
Masahiro Yamada