From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99313C433B4 for ; Mon, 12 Apr 2021 11:08:35 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0694661244 for ; Mon, 12 Apr 2021 11:08:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0694661244 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FJmFF2LK9z3bTF for ; Mon, 12 Apr 2021 21:08:33 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=arndb.de (client-ip=217.72.192.73; helo=mout.kundenserver.de; envelope-from=arnd@arndb.de; receiver=) Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FJmDs5K9Mz2yxW for ; Mon, 12 Apr 2021 21:08:12 +1000 (AEST) Received: from mail-wr1-f52.google.com ([209.85.221.52]) by mrelayeu.kundenserver.de (mreue107 [213.165.67.113]) with ESMTPSA (Nemesis) id 1N8GAQ-1laUyt1rPM-014Crs for ; Mon, 12 Apr 2021 13:08:07 +0200 Received: by mail-wr1-f52.google.com with SMTP id s7so12363289wru.6 for ; Mon, 12 Apr 2021 04:08:06 -0700 (PDT) X-Gm-Message-State: AOAM530l2wX/NasHkHxcpw9wJrJc23ubZXczeMw+3JTx8CmvDM9i9lQi BczFkBvorbQaP56rtQ3oBxlGQbvtQycbVm/4duk= X-Google-Smtp-Source: ABdhPJwatGj4Mvozhf6aCxkSShLwRvZgtq4mQWAmILFQGmr0irnCJbJ+CA5m1DFQ3FmRiRFXCX+SPYIdhUIUiDPM7gw= X-Received: by 2002:a5d:6dc4:: with SMTP id d4mr1862692wrz.105.1618225686459; Mon, 12 Apr 2021 04:08:06 -0700 (PDT) MIME-Version: 1.0 References: <20210412085545.2595431-1-hch@lst.de> <16c471554aa5424fbe2f6a4fd60bd662@AcuMS.aculab.com> In-Reply-To: <16c471554aa5424fbe2f6a4fd60bd662@AcuMS.aculab.com> From: Arnd Bergmann Date: Mon, 12 Apr 2021 13:07:50 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: consolidate the flock uapi definitions To: David Laight Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:OeoWRZQ5tzWn+DWeM4Tp4OACKEwR7wJ4VG+coZqaXM8woVvfBVF cikSbNC6v5bzJHl0NUImxY99NXNQ7ndM6aOoti5xXTgfbIPb5ASdcIrnwMF325fJQY5Uw0P GOioaBcgPZ22hkdp+M7fq2OBSE3PfY1oM1++xUWGucnGAoHHWvgb6x6LgBHB62V+FP/rnF1 GvTKNTHrs33EHCBuJm/4g== X-UI-Out-Filterresults: notjunk:1;V03:K0:4rlbwDLE9uY=:BoD8jcxM7TdJz+DOC5h4Lc TTI2fHF0gBCWAQO1DwoIZRFq3OpK0CuUuT1jam0WmcQIX6EMymX0lrrbOKN0XL6Nt/0/PxEf7 XzsAnGYshWt4XhyHj98xMzqTz8JWl6qruCfLTHzMn5+raUMaX9UaPKNexa401/r0okdXW8EQS fJvN8BqMV46yZCl2gWvQsFQ6nzqXGIyZMtp3SX8JfZQ4CNqpoVjofc+pYUHVAdr7ob6ArFhe3 fmI8+HB0Jt7Nn3RflrUVru5ewLEs6TgfnCqb5fSf5xNUflDqufZKLfxtX9D3N6dE6hHY4u1Fu 0q11Ki8v5or8J9DF/A4Qtn9/QD7ldHzYhDau/TX4iaxxa7Lu/xbZSeBKdWVGCBRzsq9I7cdBI V8q7QKqWFE3K+rKNKVJJPNHXtZh9koiWFD7E1g5jOLF7GnLkX6c3MOseXa75UPgF3ci8JkCuv jo8Vv8TaQY4Wh0sGfYlXZyC0rbDaSTp8xFzWyzFzhPHc642OBwepz+D1iSvIDQMOR4Da5CYNs pGkRsOWzUcWFGpXrTI4oTFXsZ8xp+GVXxDlw9n8Znlr5xnORqONMmBjlHxPwVtvmgLzkPyQ4z pDRPAjlvPb9DnJhVIPFCXdWBRQpj6Gz8Ia X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , linux-s390 , Thomas Bogendoerfer , Parisc List , Vasily Gorbik , Catalin Marinas , Helge Deller , the arch/x86 maintainers , Linux Kernel Mailing List , "David S. Miller" , "James E.J. Bottomley" , Christian Borntraeger , Will Deacon , Heiko Carstens , sparclinux , "open list:BROADCOM NVRAM DRIVER" , linuxppc-dev , Christoph Hellwig , Linux ARM Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Apr 12, 2021 at 12:22 PM David Laight wrote: > > From: Arnd Bergmann > > Sent: 12 April 2021 11:04 > > > > On Mon, Apr 12, 2021 at 10:55 AM Christoph Hellwig wrote: > > > > > > Hi all, > > > > > > currently we deal with the slight differents in the various architecture > > > variants of the flock and flock64 stuctures in a very cruft way. This > > > series switches to just use small arch hooks and define the rest in > > > asm-generic and linux/compat.h instead. > > > > Nice cleanup. I can merge it through the asm-generic tree if you like, > > though it's a little late just ahead of the merge window. > > > > I would not want to change the compat_loff_t definition to compat_s64 > > to avoid the padding at this time, though that might be a useful cleanup > > for a future cycle. > > Is x86 the only architecture that has 32bit and 64bit variants where > the 32bit variant aligns 64bit items on 32bit boundaries? Yes. > ISTM that fixing compat_loff_t shouldn't have any fallout. That is my assumption as well, but I still wouldn't take the risk one week before the merge window. Arnd