From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 757F3C43381 for ; Mon, 25 Mar 2019 07:34:46 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BAFEC20879 for ; Mon, 25 Mar 2019 07:34:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAFEC20879 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 44SQyC2grzzDqGh for ; Mon, 25 Mar 2019 18:34:43 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=209.85.160.196; helo=mail-qt1-f196.google.com; envelope-from=arndbergmann@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=arndb.de Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 44SQwP2SYCzDqFs for ; Mon, 25 Mar 2019 18:33:08 +1100 (AEDT) Received: by mail-qt1-f196.google.com with SMTP id z16so9167575qtn.4 for ; Mon, 25 Mar 2019 00:33:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1MqoVO4GdF3K6sehfp7D7I5RtwnxGYYTVEiIQ0OI5sQ=; b=qOQ3mUsW4Y6BoMx/mLLZbSYGQW5uGqLZuRdBchdWQGuDyoR5vlpR5unEhaTMXSkyoj THODTHSGEcxpGoZhqlLheWUZPe4n7tpQaKG61q0KxEusTQZFS6MnfGxSC6IR64fVJ9GN +GOtwM9T3n/Mled9ELTLvNxotbXPimvqolyahNGgh6KPT6eGX5bwZood9san6S6cUbVt 9QkKfuxo7Y960FSRRGwmRE7ZfDjMQewCauUjRS8qTlNMP7ALdJe2A+732DbzWqcLVzIg mrIerplTqGtaaKE/x7okwXLMxsg9hwN/8xSiQ3JJRbBGuGFpPLgxtgE0FInNeB2SVUJF mWvw== X-Gm-Message-State: APjAAAWFu4OGY+8InGG1MD83bla9ZTI988LyrAl3qHbtFjrTX73yzJvh qUbQa9u0H6fa/VlaFgDTNN6lpXtZmiRw+pY2iPo= X-Google-Smtp-Source: APXvYqxKEsoDhNlT5+1LqguQotzzoYfh33c3j/RJW0lHblejN8SPJQgxr41seRZPVPQ7PbwWXyRFPtHB2ovD82Zw4eY= X-Received: by 2002:a0c:9487:: with SMTP id j7mr18527311qvj.180.1553499185439; Mon, 25 Mar 2019 00:33:05 -0700 (PDT) MIME-Version: 1.0 References: <1553062828-27798-1-git-send-email-yamada.masahiro@socionext.com>

In-Reply-To: From: Arnd Bergmann Date: Mon, 25 Mar 2019 08:32:48 +0100 Message-ID: Subject: Re: [PATCH] compiler: allow all arches to enable CONFIG_OPTIMIZE_INLINING To: Masahiro Yamada Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , linux-s390 , Dave Hansen , the arch/x86 maintainers , linux-mips@vger.kernel.org, Linux Kernel Mailing List , Paul Burton , Ingo Molnar , linux-mtd , Andrew Morton , linuxppc-dev , Linux ARM Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Mar 25, 2019 at 7:11 AM Masahiro Yamada wrote: > On Wed, Mar 20, 2019 at 10:34 PM Arnd Bergmann wrote: > > > > On Wed, Mar 20, 2019 at 10:41 AM Arnd Bergmann wrote: > > > > > > I've added your patch to my randconfig test setup and will let you > > > know if I see anything noticeable. I'm currently testing clang-arm32, > > > clang-arm64 and gcc-x86. > > > > This is the only additional bug that has come up so far: > > > > `.exit.text' referenced in section `.alt.smp.init' of > > drivers/char/ipmi/ipmi_msghandler.o: defined in discarded section > > `exit.text' of drivers/char/ipmi/ipmi_msghandler.o > > > > diff --git a/arch/arm/kernel/atags.h b/arch/arm/kernel/atags.h > > index 201100226301..84b12e33104d 100644 > > --- a/arch/arm/kernel/atags.h > > +++ b/arch/arm/kernel/atags.h > > @@ -5,7 +5,7 @@ void convert_to_tag_list(struct tag *tags); > > const struct machine_desc *setup_machine_tags(phys_addr_t __atags_pointer, > > unsigned int machine_nr); > > #else > > -static inline const struct machine_desc * > > +static __always_inline const struct machine_desc * > > setup_machine_tags(phys_addr_t __atags_pointer, unsigned int machine_nr) > > { > > early_print("no ATAGS support: can't continue\n"); > > > > > I do not know why to reproduce it, > but is "__init __noreturn" more sensible than > "__always_inline" here? It's in a header file, so it has to be 'inline'. We could make it static inline __init __noreturn, but I don't see an advantage over __always_inline there. Arnd