linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Wolfram Sang <wsa@kernel.org>,
	Christian Zigotzky <chzigotzky@xenosoft.de>,
	Sven Peter <sven@svenpeter.dev>,
	Michael Ellerman <mpe@ellerman.id.au>,
	 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	 Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
	Hector Martin <marcan@marcan.st>,
	 Mohamed Mediouni <mohamed.mediouni@caramail.com>,
	Stan Skowronek <stan@corellium.com>,
	 Mark Kettenis <mark.kettenis@xs4all.nl>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	 Alyssa Rosenzweig <alyssa@rosenzweig.io>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	 Linux I2C <linux-i2c@vger.kernel.org>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"R.T.Dickinson" <rtd2@xtra.co.nz>,
	 Darren Stevens <darren@stevens-zone.net>,
	Matthew Leaman <matthew@a-eon.biz>,
	 "R.T.Dickinson" <rtd@a-eon.com>
Subject: Re: Add Apple M1 support to PASemi i2c driver
Date: Mon, 4 Oct 2021 13:20:23 +0200	[thread overview]
Message-ID: <CAK8P3a2760x4OYbNBuFCv32Tgt7K3MdJna4qXvPchdKhV8-8vQ@mail.gmail.com> (raw)
In-Reply-To: <YVrPf4yVFm184LEG@shikoro>

On Mon, Oct 4, 2021 at 11:55 AM Wolfram Sang <wsa@kernel.org> wrote:
>
>
> > i2c-8 i2c             PA Semi SMBus adapter at 0x(____ptrval____)     I2C adapter
> > i2c-9 i2c             PA Semi SMBus adapter at 0x(____ptrval____)     I2C adapter
> > i2c-10        i2c             PA Semi SMBus adapter at 0x(____ptrval____)     I2C adapter
>
> As Sven correctly switched from %lx to %p, this is intended behaviour.
> Run 'i2cdetect' as root to see the values again.

I think the address could just get removed here, as this is clearly not helpful.
port number, which is somewhat useful for identifying the device, now
it's either the pointless string, or the virtual address that the
device is mapped
to, which is not helpful either and potentially leaks information about kernel
internal structures.

       Arnd

  reply	other threads:[~2021-10-04 11:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-26 14:55 Add Apple M1 support to PASemi i2c driver Christian Zigotzky
2021-09-26 20:27 ` Christian Zigotzky
2021-09-27  5:39   ` Sven Peter
2021-09-27  7:07     ` Wolfram Sang
2021-09-27  7:58       ` Michael Ellerman
2021-09-27 14:46         ` Christian Zigotzky
2021-10-08 20:19         ` Christian Zigotzky
2021-10-08 20:47           ` Olof Johansson
2021-10-09  6:10             ` Christian Zigotzky
2021-10-01  4:47     ` Christian Zigotzky
2021-10-01  5:49       ` Christian Zigotzky
2021-10-03 14:36       ` Sven Peter
2021-10-03 15:45         ` Christian Zigotzky
2021-10-04  9:22         ` Christian Zigotzky
2021-10-04  9:47         ` Christian Zigotzky
2021-10-04  9:55           ` Wolfram Sang
2021-10-04 11:20             ` Arnd Bergmann [this message]
2021-10-04 11:22               ` Sven Peter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK8P3a2760x4OYbNBuFCv32Tgt7K3MdJna4qXvPchdKhV8-8vQ@mail.gmail.com \
    --to=arnd@arndb.de \
    --cc=alyssa@rosenzweig.io \
    --cc=benh@kernel.crashing.org \
    --cc=chzigotzky@xenosoft.de \
    --cc=darren@stevens-zone.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=marcan@marcan.st \
    --cc=mark.kettenis@xs4all.nl \
    --cc=matthew@a-eon.biz \
    --cc=mohamed.mediouni@caramail.com \
    --cc=mpe@ellerman.id.au \
    --cc=olof@lixom.net \
    --cc=paulus@samba.org \
    --cc=rtd2@xtra.co.nz \
    --cc=rtd@a-eon.com \
    --cc=stan@corellium.com \
    --cc=sven@svenpeter.dev \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).