From: Arnd Bergmann <arnd@arndb.de>
To: Firoz Khan <firoz.khan@linaro.org>
Cc: Kate Stewart <kstewart@linuxfoundation.org>,
linux-arch <linux-arch@vger.kernel.org>,
gregkh <gregkh@linuxfoundation.org>,
y2038 Mailman List <y2038@lists.linaro.org>,
Boqun Feng <boqun.feng@gmail.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
linuxram@us.ibm.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>,
leitao@debian.org, Geert Uytterhoeven <geert@linux-m68k.org>,
Deepa Dinamani <deepa.kernel@gmail.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Paul Mackerras <paulus@samba.org>,
Thomas Gleixner <tglx@linutronix.de>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v3 4/4] powerpc: generate uapi header and system call table files
Date: Tue, 4 Dec 2018 22:17:18 +0100 [thread overview]
Message-ID: <CAK8P3a2SP0eX50NoFKaM2N85mgSejToQkD9ZOE_7V_RT__BCvg@mail.gmail.com> (raw)
In-Reply-To: <1543465611-17122-5-git-send-email-firoz.khan@linaro.org>
> diff --git a/arch/powerpc/kernel/systbl.S b/arch/powerpc/kernel/systbl.S
> index 9ff1913..d756348 100644
> --- a/arch/powerpc/kernel/systbl.S
> +++ b/arch/powerpc/kernel/systbl.S
> #ifdef CONFIG_PPC64
> @@ -47,5 +25,17 @@
> .globl sys_call_table
> sys_call_table:
>
> +#if defined CONFIG_PPC64 && defined(CONFIG_COMPAT)
> +#define __SYSCALL(nr, entry, nargs) .8byte entry
> #define compat_sys_sigsuspend sys_sigsuspend
> -#include <asm/systbl.h>
> +#include <asm/syscall_table_c32.h>
> +#undef __SYSCALL
> +#elif defined CONFIG_PPC64 && !defined(CONFIG_COMPAT)
> +#define __SYSCALL(nr, entry, nargs) .8byte entry
> +#include <asm/syscall_table_64.h>
> +#undef __SYSCALL
This part looks wrong: where the old sys_call_table contained
both the native and compat calls side by side, the new table
contains only the compat versions (note that CONFIG_COMPAT is
always set on PPC64). I think you copy-pasted this incorrectly from
one of the other architectures that uses a different layout for the
compat calls.
The way I think this could work best is if you add a preparation
patch that splits out the 64-bit table into two separate ones
(and make sure that works). After that, you can add your
existing patch, rebased to use the two generated tables
instead of the old-style tables. I'll follow up with an untested
patch for illustration.
Arnd
next prev parent reply other threads:[~2018-12-04 21:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 4:26 [PATCH v3 0/4] powerpc: system call table generation support Firoz Khan
2018-11-29 4:26 ` [PATCH v3 1/4] powerpc: add __NR_syscalls along with NR_syscalls Firoz Khan
2018-11-29 4:26 ` [PATCH v3 2/4] powerpc: move macro definition from asm/systbl.h Firoz Khan
2018-11-29 4:26 ` [PATCH v3 3/4] powerpc: add system call table generation support Firoz Khan
2018-11-29 4:26 ` [PATCH v3 4/4] powerpc: generate uapi header and system call table files Firoz Khan
2018-12-04 21:17 ` Arnd Bergmann [this message]
2018-12-04 21:23 ` [PATCH] powerpc: split compat syscall table out from native table Arnd Bergmann
2018-12-05 12:24 ` Michael Ellerman
2018-12-04 21:33 ` [PATCH v3 4/4] powerpc: generate uapi header and system call table files Arnd Bergmann
2018-11-29 8:57 ` [PATCH v3 0/4] powerpc: system call table generation support Firoz Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a2SP0eX50NoFKaM2N85mgSejToQkD9ZOE_7V_RT__BCvg@mail.gmail.com \
--to=arnd@arndb.de \
--cc=boqun.feng@gmail.com \
--cc=deepa.kernel@gmail.com \
--cc=firoz.khan@linaro.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=leitao@debian.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=linuxram@us.ibm.com \
--cc=marcin.juszkiewicz@linaro.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulus@samba.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).