From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BB87C433F5 for ; Mon, 14 Feb 2022 19:41:18 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4JyF2h0N5Zz3cWk for ; Tue, 15 Feb 2022 06:41:16 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=FB6LCtzh; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=145.40.68.75; helo=ams.source.kernel.org; envelope-from=arnd@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=FB6LCtzh; dkim-atps=neutral Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4JyF1z0cJMz3bbj for ; Tue, 15 Feb 2022 06:40:38 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 899FEB8166D for ; Mon, 14 Feb 2022 19:40:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A3B2C340EE for ; Mon, 14 Feb 2022 19:40:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644867635; bh=5szbHF9etsKpvbwWwwc9H/Y1QakuvzjKYGUIBcYFA80=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=FB6LCtzhqken/QDOPyOwZ7wQpXfPikw3pdTyiG/plTo//u4LL21KcLieW6f3UDasd m+oZrXFq0g+10OYhhpfWoc66p3wYzH1yqgc9M/Ir+axOtsEuq/9I0L4rsyEdsA4DqV Akh3HKGFbae964Ns+9AAqIR8q2ETEq6jdm91TNaeypazn0g9zThClRvdRy2dhtQTVB huhrfM1rfEAPboTNO6qI3jB+K2Wk2ktxzMPEDCNV3Ppxg1UY9wNqs0jqFbwMJdfyF3 wJOEIVpvplY+7kpXA5brHQ6R6B4+dmKM9rSodPkMt8v0CZbn+igDN37PabkIb6gL30 unIqB3cjmS6Lw== Received: by mail-wm1-f44.google.com with SMTP id l123-20020a1c2581000000b0037b9d960079so114843wml.0 for ; Mon, 14 Feb 2022 11:40:35 -0800 (PST) X-Gm-Message-State: AOAM533AvAy8diwveqs5eN+/AWJ/FloYBCA8YlzUGEogu41WU07d+SeS 7BFQgfgN5QjFPiRIpPF62d9MSVUXX0BGiCNcylQ= X-Google-Smtp-Source: ABdhPJzTYqCeBLA8ZZTCXfIkkUBrupnk+RLzKXVQdywxm2I/SfNIqW0R0tvlKvR6EMssd+gXW/CMf7zH4TFa2LGJB14= X-Received: by 2002:a05:600c:1d27:b0:37c:74bb:2b4d with SMTP id l39-20020a05600c1d2700b0037c74bb2b4dmr252362wms.82.1644867623104; Mon, 14 Feb 2022 11:40:23 -0800 (PST) MIME-Version: 1.0 References: <20220214163452.1568807-1-arnd@kernel.org> <20220214163452.1568807-11-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Mon, 14 Feb 2022 20:40:07 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 10/14] uaccess: remove most CONFIG_SET_FS users To: Christoph Hellwig Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Rich Felker , linux-ia64@vger.kernel.org, Linux-sh list , Peter Zijlstra , "open list:BROADCOM NVRAM DRIVER" , Max Filippov , Guo Ren , sparclinux , linux-riscv , Will Deacon , Ard Biesheuvel , linux-arch , linux-s390 , Brian Cain , "open list:QUALCOMM HEXAGON..." , Helge Deller , the arch/x86 maintainers , Russell King - ARM Linux , linux-csky@vger.kernel.org, Christoph Hellwig , Ingo Molnar , Geert Uytterhoeven , "open list:SYNOPSYS ARC ARCHITECTURE" , "open list:TENSILICA XTENSA PORT \(xtensa\)" , Arnd Bergmann , Heiko Carstens , linux-um , linuxppc-dev , Richard Weinberger , linux-m68k , Openrisc , Greentime Hu , Stafford Horne , Linux ARM , Michal Simek , Thomas Bogendoerfer , Nick Hu , Parisc List , Linux-MM , Linux API , Linux Kernel Mailing List , Dinh Nguyen , "Eric W . Biederman" , alpha , Andrew Morton , Linus Torvalds , David Miller Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Feb 14, 2022 at 6:06 PM Christoph Hellwig wrote: > > On Mon, Feb 14, 2022 at 05:34:48PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > On almost all architectures, there are no remaining callers > > of set_fs(), so CONFIG_SET_FS can be disabled, along with > > removing the thread_info field and any references to it. > > > > This turns access_ok() into a cheaper check against TASK_SIZE_MAX. > > Wouldn't it make more sense to just merge this into the last patch? Yes, sounds good. I wasn't sure at first if there is enough buy-in to get all architectures cleaned up, and I hadn't done the ia64 patch, so it seemed more important to do this part early, but now it seems that it will all go in at the same time, so doing this as part of a big removal at the end makes sense. Arnd