From: Balbir Singh <bsingharora@gmail.com>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Mahesh Jagannath Salgaonkar <mahesh@linux.vnet.ibm.com>,
"open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)"
<linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v2 3/5] powerpc/mce: Hookup derror (load/store) UE errors
Date: Wed, 13 Sep 2017 16:26:59 +1000 [thread overview]
Message-ID: <CAKTCnz=+sY0+dkw8gA2oRMG9g9CqNRqdVrcRU-01qXys9+7O3Q@mail.gmail.com> (raw)
In-Reply-To: <20170913162113.49e80b39@roar.ozlabs.ibm.com>
On Wed, Sep 13, 2017 at 4:21 PM, Nicholas Piggin <npiggin@gmail.com> wrote:
> On Wed, 13 Sep 2017 16:10:47 +1000
> Balbir Singh <bsingharora@gmail.com> wrote:
>
>> Extract physical_address for UE errors by walking the page
>> tables for the mm and address at the NIP, to extract the
>> instruction. Then use the instruction to find the effective
>> address via analyse_instr().
>>
>> We might have page table walking races, but we expect them to
>> be rare, the physical address extraction is best effort. The idea
>> is to then hook up this infrastructure to memory failure eventually.
>
> This all looks pretty good to me, you can probably update these
> changelogs now because you are hooking it into memory failure.
Yep, the eventually can probably go, I meant in the next patch.
The following patch then hooks this up into memory_failure
>
> I wonder if it would be worth skipping the instruction analysis and
> page table walk if we've recursed up to the maximum MCE depth, just
> in case we're hitting MCEs in part of that code or data.
Yep, good idea. Would you be OK if we did this after this small series
got merged? Since that would mean that we got a UE error
while processing the our third machine check exception, I think the
probability of us running into that is low, but I'd definitely like to do that
once these changes are merged.
Balbir Singh.
next prev parent reply other threads:[~2017-09-13 6:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 6:10 [PATCH v2 0/4] Revisit MCE handling for UE Errors Balbir Singh
2017-09-13 6:10 ` [PATCH v2 1/5] powerpc/mce.c: Remove unused function get_mce_fault_addr() Balbir Singh
2017-09-13 6:10 ` [PATCH v2 2/5] powerpc/mce: align the print of physical address better Balbir Singh
2017-09-13 6:10 ` [PATCH v2 3/5] powerpc/mce: Hookup derror (load/store) UE errors Balbir Singh
2017-09-13 6:21 ` Nicholas Piggin
2017-09-13 6:26 ` Balbir Singh [this message]
2017-09-13 8:56 ` Nicholas Piggin
2017-09-13 6:10 ` [PATCH v2 4/5] powerpc/mce: Hookup ierror (instruction) " Balbir Singh
2017-09-13 6:10 ` [PATCH v2 5/5] powerpc/mce: hookup memory_failure for " Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKTCnz=+sY0+dkw8gA2oRMG9g9CqNRqdVrcRU-01qXys9+7O3Q@mail.gmail.com' \
--to=bsingharora@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).