From: Maxim Kiselev <bigunclemax@gmail.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"fido_max@inbox.ru" <fido_max@inbox.ru>,
Rob Herring <robh+dt@kernel.org>,
Paul Mackerras <paulus@samba.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] powerpc: dts: t1040rdb: fix ports names for Seville Ethernet switch
Date: Thu, 30 Dec 2021 16:24:38 +0300 [thread overview]
Message-ID: <CALHCpMg8ZeQUcbA1EeUpXMcay0u=QZfnZZGpPb_HAXJeHoUQvQ@mail.gmail.com> (raw)
In-Reply-To: <20211230130003.pzwzac5xttnnksz6@skbuf>
[-- Attachment #1: Type: text/plain, Size: 3595 bytes --]
Yes, I have T1040RDB ver.b (without SFP) and my front panel looks like this.
+---------------------------------------------------------------------+
| NO SFP |
| +-------+-------+ | +-------+-------+-------+-------+ |
| | UART0 | ETH1 | | | ETH4 | ETH6 | ETH8 | ETH10 | |
| +-------+-------+ \|/ +-------+-------+-------+-------+-------+ |
| | UART1 | ETH0 | | ETH2 | ETH3 | ETH5 | ETH7 | ETH9 | |
+--+-------+-------+-------+-------+-------+-------+-------+-------+--+
Same as this pic
https://habrastorage.org/files/433/d0f/057/433d0f05784f42b6acf9bb777970b1e9.jpg
чт, 30 дек. 2021 г. в 16:00, Vladimir Oltean <vladimir.oltean@nxp.com>:
> On Thu, Dec 30, 2021 at 01:43:28PM +0300, Maxim Kiselev wrote:
> > Fix network interface names for the switch ports according to labels
> > that are written on the front panel of the board. They start from ETH3
> > and end at ETH10.
> >
> > Fixes: e69eb0824d8c ("powerpc: dts: t1040rdb: add ports for Seville
> > Ethernet switch")
>
> A Fixes: tag should not wrap on multiple lines.
>
> > Signed-off-by: Maxim Kiselev <bigunclemax@gmail.com>
> > Reviewed-by: Maxim Kochetkov <fido_max@inbox.ru>
> > ---
>
> Sadly I'm not able to confirm or disprove this change right now, because
> my T1040RDB has a bad DDR memory stick, it seems, so it just randomly
> hangs.
> But I'm pretty sure the Ethernet ports were properly mapped out when I
> tested them.
>
> Do you have the T1040RDB or the T1040D4RDB? Because the front panel of
> my T1040RDB looks like this:
>
> +---------------------------------------------------------------------+
> | |
> | +-------+-------+ +-------+-------+-------+-------+ |
> | | UART0 | ETH1 | | ETH4 | ETH6 | ETH8 | ETH10 | |
> | +-------+-------+-------+-------+-------+-------+-------+-------+ |
> | | UART1 | ETH0 | ETH2 | ETH3 | ETH5 | ETH7 | ETH9 | ETH11 | |
> +--+-------+-------+-------+-------+-------+-------+-------+-------+--+
>
> > arch/powerpc/boot/dts/fsl/t1040rdb.dts | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/powerpc/boot/dts/fsl/t1040rdb.dts
> b/arch/powerpc/boot/dts/fsl/t1040rdb.dts
> > index af0c8a6f56138..b6733e7e65805 100644
> > --- a/arch/powerpc/boot/dts/fsl/t1040rdb.dts
> > +++ b/arch/powerpc/boot/dts/fsl/t1040rdb.dts
> > @@ -119,7 +119,7 @@ &seville_port0 {
> > managed = "in-band-status";
> > phy-handle = <&phy_qsgmii_0>;
> > phy-mode = "qsgmii";
> > - label = "ETH5";
> > + label = "ETH3";
> > status = "okay";
> > };
> >
> > @@ -135,7 +135,7 @@ &seville_port2 {
> > managed = "in-band-status";
> > phy-handle = <&phy_qsgmii_2>;
> > phy-mode = "qsgmii";
> > - label = "ETH7";
> > + label = "ETH5";
> > status = "okay";
> > };
> >
> > @@ -151,7 +151,7 @@ &seville_port4 {
> > managed = "in-band-status";
> > phy-handle = <&phy_qsgmii_4>;
> > phy-mode = "qsgmii";
> > - label = "ETH9";
> > + label = "ETH7";
> > status = "okay";
> > };
> >
> > @@ -167,7 +167,7 @@ &seville_port6 {
> > managed = "in-band-status";
> > phy-handle = <&phy_qsgmii_6>;
> > phy-mode = "qsgmii";
> > - label = "ETH11";
> > + label = "ETH9";
> > status = "okay";
> > };
> >
> > --
> > 2.32.0
> >
[-- Attachment #2: Type: text/html, Size: 5314 bytes --]
next prev parent reply other threads:[~2021-12-30 22:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-30 10:43 [PATCH] powerpc: dts: t1040rdb: fix ports names for Seville Ethernet switch Maxim Kiselev
2021-12-30 13:00 ` Vladimir Oltean
2021-12-30 13:24 ` Maxim Kiselev [this message]
[not found] ` <20211231125247.ugne3h44pmpzliin@skbuf>
2022-01-10 7:40 ` Maxim Kiselev
2022-01-11 13:13 ` Vladimir Oltean
2022-01-11 15:22 ` [PATCH] powerpc: dts: add device tree for T1040RDB-REV-A Maxim Kiselev
2022-01-11 15:29 ` Vladimir Oltean
2022-01-11 17:37 ` [PATCH v2] powerpc: dts: t1040rdb: fix ports names for Seville Ethernet switch Maxim
2022-01-12 18:50 ` Vladimir Oltean
2022-01-20 6:29 ` Michael Ellerman
2022-01-21 9:14 ` [PATCH v3] " Maxim Kiselev
2022-02-15 5:26 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALHCpMg8ZeQUcbA1EeUpXMcay0u=QZfnZZGpPb_HAXJeHoUQvQ@mail.gmail.com' \
--to=bigunclemax@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=fido_max@inbox.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=robh+dt@kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).