From: Rob Herring <robh@kernel.org>
To: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Grant Likely <grant.likely@linaro.org>,
Iyappan Subramanian <isubramanian@apm.com>,
Keyur Chudgar <kchudgar@apm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Li Yang <leoli@freescale.com>,
Michal Simek <michal.simek@xilinx.com>,
netdev <netdev@vger.kernel.org>, Robert Richter <rric@kernel.org>,
Soren Brinkmann <soren.brinkmann@xilinx.com>,
Sunil Goutham <sgoutham@cavium.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND v3 5/9] of_mdio: fix MDIO phy device refcounting
Date: Thu, 24 Sep 2015 17:21:34 -0500 [thread overview]
Message-ID: <CAL_JsqKhALmq-YyUZYKVzUpUW3oLeMN0edk6uDGhzHt7Qqe+iA@mail.gmail.com> (raw)
In-Reply-To: <E1ZfCJR-0004Rk-8M@rmk-PC.arm.linux.org.uk>
On Thu, Sep 24, 2015 at 2:36 PM, Russell King
<rmk+kernel@arm.linux.org.uk> wrote:
> bus_find_device() is defined as:
>
> * This is similar to the bus_for_each_dev() function above, but it
> * returns a reference to a device that is 'found' for later use, as
> * determined by the @match callback.
>
> and it does indeed return a reference-counted pointer to the device:
>
> while ((dev = next_device(&i)))
> if (match(dev, data) && get_device(dev))
> ^^^^^^^^^^^^^^^
> break;
> klist_iter_exit(&i);
> return dev;
>
> What that means is that when we're done with the struct device, we must
> drop that reference. Neither of_phy_connect() nor of_phy_attach() did
> this when phy_connect_direct() or phy_attach_direct() failed.
>
> With our previous patch, phy_connect_direct() and phy_attach_direct()
> take a new refcount on the phy device when successful, so we can drop
> our local reference immediatley after these functions, whether or not
> they succeeded.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Acked-by: Rob Herring <robh@kernel.org>
> ---
> drivers/of/of_mdio.c | 27 +++++++++++++++++++++++----
> 1 file changed, 23 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
> index 1350fa25cdb0..a87a868fed64 100644
> --- a/drivers/of/of_mdio.c
> +++ b/drivers/of/of_mdio.c
> @@ -197,7 +197,8 @@ static int of_phy_match(struct device *dev, void *phy_np)
> * of_phy_find_device - Give a PHY node, find the phy_device
> * @phy_np: Pointer to the phy's device tree node
> *
> - * Returns a pointer to the phy_device.
> + * If successful, returns a pointer to the phy_device with the embedded
> + * struct device refcount incremented by one, or NULL on failure.
> */
> struct phy_device *of_phy_find_device(struct device_node *phy_np)
> {
> @@ -217,7 +218,9 @@ EXPORT_SYMBOL(of_phy_find_device);
> * @hndlr: Link state callback for the network device
> * @iface: PHY data interface type
> *
> - * Returns a pointer to the phy_device if successful. NULL otherwise
> + * If successful, returns a pointer to the phy_device with the embedded
> + * struct device refcount incremented by one, or NULL on failure. The
> + * refcount must be dropped by calling phy_disconnect() or phy_detach().
> */
> struct phy_device *of_phy_connect(struct net_device *dev,
> struct device_node *phy_np,
> @@ -225,13 +228,19 @@ struct phy_device *of_phy_connect(struct net_device *dev,
> phy_interface_t iface)
> {
> struct phy_device *phy = of_phy_find_device(phy_np);
> + int ret;
>
> if (!phy)
> return NULL;
>
> phy->dev_flags = flags;
>
> - return phy_connect_direct(dev, phy, hndlr, iface) ? NULL : phy;
> + ret = phy_connect_direct(dev, phy, hndlr, iface);
> +
> + /* refcount is held by phy_connect_direct() on success */
> + put_device(&phy->dev);
> +
> + return ret ? NULL : phy;
> }
> EXPORT_SYMBOL(of_phy_connect);
>
> @@ -241,17 +250,27 @@ EXPORT_SYMBOL(of_phy_connect);
> * @phy_np: Node pointer for the PHY
> * @flags: flags to pass to the PHY
> * @iface: PHY data interface type
> + *
> + * If successful, returns a pointer to the phy_device with the embedded
> + * struct device refcount incremented by one, or NULL on failure. The
> + * refcount must be dropped by calling phy_disconnect() or phy_detach().
> */
> struct phy_device *of_phy_attach(struct net_device *dev,
> struct device_node *phy_np, u32 flags,
> phy_interface_t iface)
> {
> struct phy_device *phy = of_phy_find_device(phy_np);
> + int ret;
>
> if (!phy)
> return NULL;
>
> - return phy_attach_direct(dev, phy, flags, iface) ? NULL : phy;
> + ret = phy_attach_direct(dev, phy, flags, iface);
> +
> + /* refcount is held by phy_attach_direct() on success */
> + put_device(&phy->dev);
> +
> + return ret ? NULL : phy;
> }
> EXPORT_SYMBOL(of_phy_attach);
>
> --
> 2.1.0
>
next prev parent reply other threads:[~2015-09-24 22:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 16:17 [PATCH v2 0/9] Phy, mdiobus, and netdev struct device fixes Russell King - ARM Linux
2015-09-22 16:18 ` [PATCH 1/9] phy: fix of_mdio_find_bus() device refcount leak Russell King
2015-09-22 16:18 ` [PATCH 2/9] net: dsa: " Russell King
2015-09-22 16:18 ` [PATCH 3/9] phy: fix mdiobus module safety Russell King
2015-09-22 16:18 ` [PATCH 4/9] phy: add proper phy struct device refcounting Russell King
2015-09-22 16:18 ` [PATCH 5/9] of_mdio: fix MDIO phy " Russell King
2015-09-22 16:18 ` [PATCH 6/9] net: fix phy refcounting in a bunch of drivers Russell King
2015-09-22 16:18 ` [PATCH 7/9] phy: fixed-phy: properly validate phy in fixed_phy_update_state() Russell King
2015-09-22 16:18 ` [PATCH 8/9] phy: add phy_device_remove() Russell King
2015-09-22 16:18 ` [PATCH 9/9] net: fix net_device refcounting Russell King
2015-09-23 23:24 ` [PATCH v2 0/9] Phy, mdiobus, and netdev struct device fixes David Miller
2015-09-24 16:00 ` Russell King - ARM Linux
2015-09-24 19:35 ` [PATCH RESEND v3 1/9] phy: fix of_mdio_find_bus() device refcount leak Russell King
2015-09-24 19:35 ` [PATCH RESEND v3 2/9] net: dsa: " Russell King
2015-09-24 19:36 ` [PATCH RESEND v3 3/9] phy: fix mdiobus module safety Russell King
2015-09-24 19:36 ` [PATCH RESEND v3 4/9] phy: add proper phy struct device refcounting Russell King
2015-09-24 19:36 ` [PATCH RESEND v3 5/9] of_mdio: fix MDIO phy " Russell King
2015-09-24 22:21 ` Rob Herring [this message]
2015-09-24 19:36 ` [PATCH RESEND v3 6/9] net: fix phy refcounting in a bunch of drivers Russell King
2015-09-24 19:36 ` [PATCH RESEND v3 7/9] phy: fixed-phy: properly validate phy in fixed_phy_update_state() Russell King
2015-09-24 19:36 ` [PATCH RESEND v3 8/9] phy: add phy_device_remove() Russell King
2015-09-24 19:36 ` [PATCH RESEND v3 9/9] net: fix net_device refcounting Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqKhALmq-YyUZYKVzUpUW3oLeMN0edk6uDGhzHt7Qqe+iA@mail.gmail.com \
--to=robh@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=grant.likely@linaro.org \
--cc=isubramanian@apm.com \
--cc=kchudgar@apm.com \
--cc=leoli@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=rric@kernel.org \
--cc=sgoutham@cavium.com \
--cc=soren.brinkmann@xilinx.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).