From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C8B0C4743C for ; Mon, 7 Jun 2021 08:53:50 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C410261078 for ; Mon, 7 Jun 2021 08:53:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C410261078 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Fz6bw71Hlz3085 for ; Mon, 7 Jun 2021 18:53:48 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.222.47; helo=mail-ua1-f47.google.com; envelope-from=geert.uytterhoeven@gmail.com; receiver=) Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com [209.85.222.47]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Fz6bS391Vz2yWs for ; Mon, 7 Jun 2021 18:53:22 +1000 (AEST) Received: by mail-ua1-f47.google.com with SMTP id c17so9277950uao.1 for ; Mon, 07 Jun 2021 01:53:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y7XwbZyFAy9rqQo5J7t8DRS+d/mueoOLl5p+cSQb+8Y=; b=Z/TUQ2CMtkBVSGrtqbbWlOq7KNf6ZbtbaXb3q9Upbt2vdF03tjzqA6hPohCgAX0l6O RFieWN2WdYnk1Oy00WDWt2oGMvHQCcH1G9wDP7ectpOlMBL4E6Ey8R/PHX2eIVYf9elP YcwpaH1xjYaGYnywn+fj9kCOHpdD+YdoZm8smxYcBaHH8NbDoaVfpe5hT7ZbmMS7IW2f ZIJaFlOS7cDEYgxnWTk3fWvByFpROIkZCF+fSF+Soi+hHFo39TQJVpI16dJ+FguCHTb6 h6AIe90yjenr25Z8+jDMZ0WPgd95Tg2AUHoQ25LZhTzMvkewMrPxDFI5hjQj2BlbDaKh cnhg== X-Gm-Message-State: AOAM530I7PVKQ6nCikIg7ykbBckbRLJJKuZts+Xnj2gFy/WG9TIMcL1a zzMYRM8xue1F1Nx9R5nOnW2jqbuq7ryCplMytPw= X-Google-Smtp-Source: ABdhPJw70xfmNroh3KIu5QGmqKsYwQ+PKLyHQ50n7DeatYgE4iGl6TNz+FWGTOL2BBcrgRRRH99rMYwIPPT469OpB6M= X-Received: by 2002:ab0:63d9:: with SMTP id i25mr6682382uap.106.1623055999326; Mon, 07 Jun 2021 01:53:19 -0700 (PDT) MIME-Version: 1.0 References: <20210604064916.26580-1-rppt@kernel.org> <20210604064916.26580-9-rppt@kernel.org> In-Reply-To: <20210604064916.26580-9-rppt@kernel.org> From: Geert Uytterhoeven Date: Mon, 7 Jun 2021 10:53:08 +0200 Message-ID: Subject: Re: [PATCH v2 8/9] mm: replace CONFIG_NEED_MULTIPLE_NODES with CONFIG_NUMA To: Mike Rapoport Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-ia64@vger.kernel.org" , Linux-sh list , "open list:BROADCOM NVRAM DRIVER" , Linux MM , sparclinux , linux-riscv , Linux-Arch , linux-s390 , Jonathan Corbet , "open list:DOCUMENTATION" , Mike Rapoport , Matt Turner , arcml , "open list:TENSILICA XTENSA PORT $xtensa$" , Arnd Bergmann , linux-m68k , Ivan Kokshaysky , Linux ARM , Richard Henderson , Vineet Gupta , kexec@lists.infradead.org, Linux Kernel Mailing List , alpha , Andrew Morton , linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Mike, On Fri, Jun 4, 2021 at 8:50 AM Mike Rapoport wrote: > From: Mike Rapoport > > After removal of DISCINTIGMEM the NEED_MULTIPLE_NODES and NUMA > configuration options are equivalent. > > Drop CONFIG_NEED_MULTIPLE_NODES and use CONFIG_NUMA instead. > > Done with > > $ sed -i 's/CONFIG_NEED_MULTIPLE_NODES/CONFIG_NUMA/' \ > $(git grep -wl CONFIG_NEED_MULTIPLE_NODES) > $ sed -i 's/NEED_MULTIPLE_NODES/NUMA/' \ > $(git grep -wl NEED_MULTIPLE_NODES) > > with manual tweaks afterwards. > > Signed-off-by: Mike Rapoport Thanks for your patch! As you dropped the following hunk from v2 of PATCH 5/9, there's now one reference left of CONFIG_NEED_MULTIPLE_NODES (plus the discontigmem comment): -diff --git a/mm/memory.c b/mm/memory.c -index f3ffab9b9e39157b..fd0ebb63be3304f5 100644 ---- a/mm/memory.c -+++ b/mm/memory.c -@@ -90,8 +90,7 @@ - #warning Unfortunate NUMA and NUMA Balancing config, growing page-frame for last_cpupid. - #endif - --#ifndef CONFIG_NEED_MULTIPLE_NODES --/* use the per-pgdat data instead for discontigmem - mbligh */ -+#ifdef CONFIG_FLATMEM - unsigned long max_mapnr; - EXPORT_SYMBOL(max_mapnr); - Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds