From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E082EC3A59C for ; Fri, 16 Aug 2019 07:41:23 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6CAAD20644 for ; Fri, 16 Aug 2019 07:41:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6CAAD20644 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 468wHN4qz9zDqkj for ; Fri, 16 Aug 2019 17:41:20 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=209.85.210.68; helo=mail-ot1-f68.google.com; envelope-from=geert.uytterhoeven@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 468wF24vJ7zDr5d for ; Fri, 16 Aug 2019 17:39:17 +1000 (AEST) Received: by mail-ot1-f68.google.com with SMTP id k18so8886092otr.3 for ; Fri, 16 Aug 2019 00:39:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rNgiwRT8IqruHTtyg4qTM81WOjWWtlc2s7dRDLMNYXA=; b=lIQ9peSDpku3ykacqJmjIbrZUxwVigq1mRR8rt/EoMqS9c1dRYOZ98UgcpPTBOIvxz i1/DJPUh9yKsxo5j0iZeU+tIbatA4e7o7chQOph8lDXlnCc58XUaAmmojwMiLHCt/OQ3 2CbgGzJ9yMcQL3PLDvgA6vhUnWW+rD+lfAsRI/+orpUOtMT7FcEPRUmpZeYBNN57okAH cwARNtWf68sd3Nu59GKLmcXRV+TmsqLXNgZ6kDyhxVFmx/phOyJsL6GJ+tyLCy7lR652 SshVudxNttYsgxR3zRsiPbLHmqZ9XuYEL9TEaFyFEXthJO7mUAVcHeEyVnSqXoTbUJe0 r9CA== X-Gm-Message-State: APjAAAVXwkUknKHtvio/HYyuWsOUFUjw5jtl3hRFmG6GfGNWDk53/00X LvY2It5WFu5JW7CiwbfTwNBoUbBhzS/EYGCzRn8= X-Google-Smtp-Source: APXvYqz193ixgGnhQHDM0sA58o87yH16orCv5VbCTsKEDkS808wZnFykFKzgKwDR213pxnj04zPYszKH8AWAfSfEEwQ= X-Received: by 2002:a9d:68c5:: with SMTP id i5mr6603053oto.250.1565941154237; Fri, 16 Aug 2019 00:39:14 -0700 (PDT) MIME-Version: 1.0 References: <20190816062435.881-1-hch@lst.de> <20190816062435.881-7-hch@lst.de> In-Reply-To: <20190816062435.881-7-hch@lst.de> From: Geert Uytterhoeven Date: Fri, 16 Aug 2019 09:39:03 +0200 Message-ID: Subject: Re: [PATCH 6/6] driver core: initialize a default DMA mask for platform device To: Christoph Hellwig Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gavin Li , Shawn Guo , Fabio Estevam , Linux-Arch , Michal Simek , Maxime Chevallier , Alan Stern , NXP Linux Team , Mathias Nyman , Sascha Hauer , linux-m68k , Minas Harutyunyan , Bin Liu , Linux ARM , Laurentiu Tudor , Geoff Levand , Greg Kroah-Hartman , USB list , Linux Kernel Mailing List , Linux IOMMU , Pengutronix Kernel Team , linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Christoph, On Fri, Aug 16, 2019 at 8:30 AM Christoph Hellwig wrote: > We still treat devices without a DMA mask as defaulting to 32-bits for > both mask, but a few releases ago we've started warning about such > cases, as they require special cases to work around this sloppyness. > Add a dma_mask field to struct platform_device so that we can initialize > the dma_mask pointer in struct device and initialize both masks to > 32-bits by default, replacing similar functionality in m68k and > powerpc. The arch_setup_pdev_archdata hooks is now unused and removed. > > Note that the code looks a little odd with the various conditionals > because we have to support platform_device structures that are > statically allocated. > > Signed-off-by: Christoph Hellwig > --- > arch/m68k/kernel/dma.c | 9 ------- Acked-by: Geert Uytterhoeven > arch/sh/boards/mach-ecovec24/setup.c | 2 -- > arch/sh/boards/mach-migor/setup.c | 1 - Acked-by: Geert Uytterhoeven given "[PATCH 0/2] Remove calls to empty arch_setup_pdev_archdata()" https://lore.kernel.org/linux-renesas-soc/1526641611-2769-1-git-send-email-geert+renesas@glider.be/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds