From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 449CEC07E9A for ; Wed, 14 Jul 2021 11:02:27 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 086D161363 for ; Wed, 14 Jul 2021 11:02:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 086D161363 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4GPvjD229kz3bXR for ; Wed, 14 Jul 2021 21:02:24 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.222.42; helo=mail-ua1-f42.google.com; envelope-from=geert.uytterhoeven@gmail.com; receiver=) Received: from mail-ua1-f42.google.com (mail-ua1-f42.google.com [209.85.222.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4GPrdy5r9Sz2yNf for ; Wed, 14 Jul 2021 18:44:22 +1000 (AEST) Received: by mail-ua1-f42.google.com with SMTP id q20so350098uaa.3 for ; Wed, 14 Jul 2021 01:44:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=r5k/nzvm++7I0kjlsxJbLPoLxldn2GkCJzAXrc4Q3tE=; b=ZtZavlDQKeYSc/GoQ4KRXMe/JkA8MeXAgGl48evPV/dNnWcnqjiCw3Bl9npv9aNp8f DBxyUanpcNOh6mIpUnHn16NuoKufc7h8vYTrV6sWXUgEdv37dFkykseglZ0kgulYXMmp 0e6QfjYL7PLZC9aOvQSSXL3hLQzbDn2RUls3FeNzqxvxhjhgDrN9OmpZUCS6fVG+th0I UAGhKMWWJlHKpu+WzMkX7+HAoyWJeRFyBu6eH/pv+lKb12Y2VROWtJiiFFC8AZmV64ep Y1nv5lDurFygS6VTDv2wg71Em0olz38246fGOAySde+1b4KI7e92GYrdh0XmO6Egu9Io 8Xaw== X-Gm-Message-State: AOAM533W1SfE5CIYb792cZxNQbyG9UQnojl3dT0vqXvO4fx1t1/93KhP uAVk86XbIVAilZwTwmkJkYjXOrXmpMMavB1Fceg= X-Google-Smtp-Source: ABdhPJw+Y3tnjfY/zI+Y1qOhR0PNRzn2MQD3PHuwf/AzIRJfXjUIjP825Ll9FtnbmVsf04QAqWLG0Tq2dErAW2+m0rM= X-Received: by 2002:a9f:3f0d:: with SMTP id h13mr12412958uaj.100.1626252258156; Wed, 14 Jul 2021 01:44:18 -0700 (PDT) MIME-Version: 1.0 References: <20210713193522.1770306-1-u.kleine-koenig@pengutronix.de> <20210713193522.1770306-6-u.kleine-koenig@pengutronix.de> In-Reply-To: <20210713193522.1770306-6-u.kleine-koenig@pengutronix.de> From: Geert Uytterhoeven Date: Wed, 14 Jul 2021 10:44:06 +0200 Message-ID: Subject: Re: [PATCH v4 5/5] bus: Make remove callback return void To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Wed, 14 Jul 2021 21:02:02 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nvdimm@lists.linux.dev, linux-sh@vger.kernel.org, Samuel Iglesias Gonsalvez , Jens Taprogge , Ulf Hansson , Jaroslav Kysela , linux-fpga@vger.kernel.org, Benjamin Tissoires , Paul Mackerras , Srinivas Pandruvada , "K. Y. Srinivasan" , Mike Christie , Wei Liu , Maxim Levitsky , Samuel Holland , "Rafael J . Wysocki" , linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Tomas Winkler , Julien Grall , Ohad Ben-Cohen , Yufen Yu , Alex Williamson , Alex Elder , linux-parisc@vger.kernel.org, Finn Thain , Geoff Levand , Greg Kroah-Hartman , linux-usb@vger.kernel.org, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Kai-Heng Feng , Sascha Hauer , Jon Mason , linux-ntb@googlegroups.com, Wu Hao , David Woodhouse , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Alexandre Belloni , Manohar Vanga , linux-wireless@vger.kernel.org, Dominik Brodowski , virtualization@lists.linux-foundation.org, "James E.J. Bottomley" , target-devel@vger.kernel.org, Srinivas Kandagatla , linux-i2c@vger.kernel.org, linux-s390@vger.kernel.org, Stefano Stabellini , Stephen Hemminger , Yoshinori Sato , Jiri Slaby , Helge Deller , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , YueHaibing , industrypack-devel@lists.sourceforge.net, linux-mips@vger.kernel.org, Len Brown , Vasily Gorbik , linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, Maxime Ripard , William Breathitt Gray , greybus-dev@lists.linaro.org, linux-m68k@lists.linux-m68k.org, Florian Fainelli , Rikard Falkeborn , Frank Li , Mark Gross , Boris Ostrovsky , Mika Westerberg , linux-arm-kernel@lists.infradead.org, Johannes Thumshirn , Mathieu Poirier , Stephen Boyd , Cornelia Huck , Peter Oberparleiter , Wolfram Sang , Joey Pabalan , Yehezkel Bernat , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Bodo Stroesser , Alison Schofield , Heikki Krogerus , Tyrel Datwyler , Alexander Shishkin , Tom Rix , Jason Wang , SeongJae Park , alsa-devel@alsa-project.org, platform-driver-x86@vger.kernel.org, Bjorn Helgaas , netdev@vger.kernel.org, Vineeth Vijayan , Ira Weiny , Rob Herring , Lorenzo Pieralisi , Dave Jiang , linux-staging@lists.linux.dev, Dexuan Cui , Jernej Skrabec , Kishon Vijay Abraham I , Christian Borntraeger , Chen-Yu Tsai , linux-input@vger.kernel.org, Allen Hubbe , Alex Dubov , Haiyang Zhang , Jiri Kosina , "Russell King \(Oracle\)" , Ben Widawsky , Harald Freudenberger , linux-cxl@vger.kernel.org, Michael Buesch , Dan Williams , Mauro Carvalho Chehab , Cristian Marussi , Thomas Bogendoerfer , "Martin K. Petersen" , Martyn Welch , Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-sunxi@lists.linux.dev, Stefan Richter , Sudeep Holla , "David S. Miller" , Sven Van Asbroeck , Rich Felker , kvm@vger.kernel.org, "Michael S. Tsirkin" , linux-remoteproc@vger.kernel.org, Bjorn Andersson , sparclinux@vger.kernel.org, Kirti Wankhede , Andreas Noever , linux-i3c@lists.infradead.org, linux1394-devel@lists.sourceforge.net, Lee Jones , Arnd Bergmann , linux-scsi@vger.kernel.org, Marc Zyngier , Russell King , Thorsten Scherer , Andy Gross , linux-serial@vger.kernel.org, Jakub Kicinski , linux-hyperv@vger.kernel.org, Michael Jamet , Heiko Carstens , Johan Hovold , Hans de Goede , Hannes Reinecke , Juergen Gross , linuxppc-dev@lists.ozlabs.org, Takashi Iwai , Alexandre Bounine , Vinod Koul , Mark Brown , Vishal Verma , dmaengine@vger.kernel.org, Moritz Fischer , Johannes Berg , Johannes Thumshirn , Maximilian Luz Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Jul 13, 2021 at 9:35 PM Uwe Kleine-K=C3=B6nig wrote: > The driver core ignores the return value of this callback because there > is only little it can do when a device disappears. > > This is the final bit of a long lasting cleanup quest where several > buses were converted to also return void from their remove callback. > Additionally some resource leaks were fixed that were caused by drivers > returning an error code in the expectation that the driver won't go > away. > > With struct bus_type::remove returning void it's prevented that newly > implemented buses return an ignored error code and so don't anticipate > wrong expectations for driver authors. > drivers/zorro/zorro-driver.c | 3 +-- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds