From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-x229.google.com (mail-ob0-x229.google.com [IPv6:2607:f8b0:4003:c01::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 142731A2351 for ; Mon, 17 Aug 2015 18:20:23 +1000 (AEST) Received: by obbop1 with SMTP id op1so106832429obb.2 for ; Mon, 17 Aug 2015 01:20:21 -0700 (PDT) MIME-Version: 1.0 Sender: geert.uytterhoeven@gmail.com In-Reply-To: References: <20150725074559.543547894@telegraphics.com.au> Date: Mon, 17 Aug 2015 10:20:21 +0200 Message-ID: Subject: Re: [RFC v5 00/26] Re-use nvram module From: Geert Uytterhoeven To: Finn Thain Cc: linux-kernel , linux-m68k , linuxppc-dev Content-Type: text/plain; charset=UTF-8 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Finn, On Mon, Aug 17, 2015 at 10:04 AM, Finn Thain wrote: >> BTW, checkpatch reported a few newly-introduced whitespace errors in >> patches 03, 05, 16, 24, and 25. > > I will check again, but I'm sure those are all deliberate. I examined all > the "errors" and "warnings" before submitting. > > checkpatch doesn't really understand the difference between whitespace > used for indentation of statements (according to scope) and whitespace > used for alignment of terms or parameters (when line-wrapped). Any tool > that fails to make that distinction can't be depended upon to correctly > validate the elisp in Documentation/CodingStyle, for example. Checkpatch complains because you don't replace a sequence of 8 spaces by a TAB in continuation lines. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds