From: Geert Uytterhoeven <geert@linux-m68k.org>
To: John Ogness <john.ogness@linutronix.de>
Cc: "Petr Mladek" <pmladek@suse.com>,
"Kees Cook" <keescook@chromium.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
"Alexey Kardashevskiy" <aik@ozlabs.ru>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
kexec@lists.infradead.org,
"Sergey Senozhatsky" <senozhatsky@chromium.org>,
"Yue Hu" <huyue2@yulong.com>, "Paul Mackerras" <paulus@samba.org>,
"Eric Biederman" <ebiederm@xmission.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Tiezhu Yang" <yangtiezhu@loongson.cn>,
"Cédric Le Goater" <clg@kaod.org>
Subject: Re: [PATCH printk v4 3/6] printk: remove safe buffers
Date: Thu, 2 Sep 2021 18:48:04 +0200 [thread overview]
Message-ID: <CAMuHMdXa-ahzQX2FMb-YZ9Yc4Z=72JpaN8Z9bC5htmyvEDSh+w@mail.gmail.com> (raw)
In-Reply-To: <20210715193359.25946-4-john.ogness@linutronix.de>
Hi John,
On Thu, Jul 15, 2021 at 9:53 PM John Ogness <john.ogness@linutronix.de> wrote:
> With @logbuf_lock removed, the high level printk functions for
> storing messages are lockless. Messages can be stored from any
> context, so there is no need for the NMI and safe buffers anymore.
> Remove the NMI and safe buffers.
>
> Although the safe buffers are removed, the NMI and safe context
> tracking is still in place. In these contexts, store the message
> immediately but still use irq_work to defer the console printing.
>
> Since printk recursion tracking is in place, safe context tracking
> for most of printk is not needed. Remove it. Only safe context
> tracking relating to the console and console_owner locks is left
> in place. This is because the console and console_owner locks are
> needed for the actual printing.
>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
Thank you very much for reducing kernel size by ca. 8 KiB!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2021-09-02 16:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 19:33 [PATCH printk v4 0/6] printk: remove safe buffers John Ogness
2021-07-15 19:33 ` [PATCH printk v4 3/6] " John Ogness
2021-07-21 11:25 ` Petr Mladek
2021-09-02 16:48 ` Geert Uytterhoeven [this message]
2021-07-15 19:33 ` [PATCH printk v4 4/6] printk: remove NMI tracking John Ogness
2021-07-21 12:00 ` Petr Mladek
2021-07-21 12:46 ` John Ogness
2021-07-21 13:08 ` Petr Mladek
2021-07-21 13:23 ` John Ogness
2021-07-27 7:26 ` [PATCH printk v4 0/6] printk: remove safe buffers Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdXa-ahzQX2FMb-YZ9Yc4Z=72JpaN8Z9bC5htmyvEDSh+w@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=aik@ozlabs.ru \
--cc=akpm@linux-foundation.org \
--cc=clg@kaod.org \
--cc=ebiederm@xmission.com \
--cc=huyue2@yulong.com \
--cc=john.ogness@linutronix.de \
--cc=keescook@chromium.org \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=paulmck@kernel.org \
--cc=paulus@samba.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tglx@linutronix.de \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).