From: Baolin Wang <baolin.wang@linaro.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Xunlei Pang" <pang.xunlei@linaro.org>,
peterz@infradead.org, heiko.carstens@de.ibm.com,
paulus@samba.org, cl@linux.com,
"Heena Sirwani" <heenasirwani@gmail.com>,
linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
"y2038 Mailman List" <y2038@lists.linaro.org>,
rafael.j.wysocki@intel.com, "Andrew Hunter" <ahh@google.com>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"Paul Turner" <pjt@google.com>,
riel@redhat.com, "Arnd Bergmann" <arnd@arndb.de>,
"Richard Cochran" <richardcochran@gmail.com>,
schwidefsky@de.ibm.com, "John Stultz" <john.stultz@linaro.org>,
rth@twiddle.net, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
tj@kernel.org, linux390@de.ibm.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 05/11] time/posix-timers:Convert to the 64bit methods for k_clock callback functions
Date: Tue, 21 Apr 2015 16:36:13 +0800 [thread overview]
Message-ID: <CAMz4kuKF2sU4tMD7UtDobu2kVDMp7cfHNERSPQ9Yyzs80tOzYg@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1504202243070.13914@nanos>
[-- Attachment #1: Type: text/plain, Size: 1765 bytes --]
On 21 April 2015 at 04:48, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Mon, 20 Apr 2015, Baolin Wang wrote:
> > /* Set clock_realtime */
> > static int posix_clock_realtime_set(const clockid_t which_clock,
> > - const struct timespec *tp)
> > + const struct timespec64 *tp)
> > {
> > - return do_sys_settimeofday(tp, NULL);
> > + struct timespec ts = timespec64_to_timespec(*tp);
> > +
> > + return do_sys_settimeofday(&ts, NULL);
>
> Sigh. No. We first provide a proper function for this, which takes a
> timespec64, i.e. do_sys_settimeofday64() instead of having this
> wrapper mess all over the place.
>
Thanks for your comments,but if use do_sys_settimeofday64() here that
will introduce
a security bug: do_sys_settimeofday contains a capability
check that normally prevents non-root users from setting the time.
With your change, any user can set the system time.
>
> > /* SIGEV_NONE timers are not queued ! See common_timer_get */
> > if (((timr->it_sigev_notify & ~SIGEV_THREAD_ID) == SIGEV_NONE)) {
> > diff --git a/kernel/time/timekeeping.h b/kernel/time/timekeeping.h
> > index 1d91416..144af14 100644
> > --- a/kernel/time/timekeeping.h
> > +++ b/kernel/time/timekeeping.h
> > @@ -15,7 +15,7 @@ extern u64 timekeeping_max_deferment(void);
> > extern int timekeeping_inject_offset(struct timespec *ts);
> > extern s32 timekeeping_get_tai_offset(void);
> > extern void timekeeping_set_tai_offset(s32 tai_offset);
> > -extern void timekeeping_clocktai(struct timespec *ts);
> > +extern void timekeeping_clocktai(struct timespec64 *ts);
>
> # git grep timekeeping_clocktai() is your friend.
>
> Thanks,
>
> tglx
>
--
Baolin.wang
Best Regards
[-- Attachment #2: Type: text/html, Size: 3026 bytes --]
next prev parent reply other threads:[~2015-04-21 8:36 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-20 5:57 [PATCH 00/11] Convert the posix_clock_operations and k_clock structure to ready for 2038 Baolin Wang
2015-04-20 5:57 ` [PATCH 01/11] linux/time64.h:Introduce the 'struct itimerspec64' for 64bit Baolin Wang
2015-04-20 9:49 ` Sergei Shtylyov
2015-04-20 10:55 ` Baolin Wang
2015-04-20 19:14 ` Thomas Gleixner
2015-04-20 19:59 ` Thomas Gleixner
2015-04-21 8:19 ` Baolin Wang
2015-04-20 5:57 ` [PATCH 02/11] timekeeping:Introduce the current_kernel_time64() function with timespec64 type Baolin Wang
2015-04-20 5:57 ` [PATCH 03/11] time/hrtimer:Introduce hrtimer_get_res64() with timespec64 type for getting the timer resolution Baolin Wang
2015-04-20 19:15 ` Thomas Gleixner
2015-04-20 5:57 ` [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure Baolin Wang
2015-04-20 20:40 ` Thomas Gleixner
2015-04-21 8:59 ` [Y2038] " Arnd Bergmann
2015-04-21 14:14 ` Thomas Gleixner
2015-04-21 14:57 ` Arnd Bergmann
2015-04-21 15:13 ` Thomas Gleixner
2015-04-21 15:40 ` Arnd Bergmann
2015-04-21 20:13 ` Thomas Gleixner
2015-04-22 8:45 ` Thomas Gleixner
2015-04-22 10:11 ` Richard Cochran
2015-04-22 10:44 ` David Laight
2015-04-22 11:07 ` Arnd Bergmann
2015-04-22 13:37 ` Thomas Gleixner
2015-04-22 13:50 ` Arnd Bergmann
2015-04-22 14:54 ` Richard Cochran
2015-04-22 15:37 ` Arnd Bergmann
2015-04-22 15:14 ` Luc Van Oostenryck
2015-04-22 15:38 ` Arnd Bergmann
2015-04-20 5:57 ` [PATCH 05/11] time/posix-timers:Convert to the 64bit methods for k_clock callback functions Baolin Wang
2015-04-20 20:48 ` Thomas Gleixner
2015-04-21 8:36 ` Baolin Wang [this message]
2015-04-21 8:45 ` [Y2038] " Arnd Bergmann
2015-04-21 8:55 ` Baolin Wang
2015-04-20 5:57 ` [PATCH 06/11] char/mmtimer:Convert to the 64bit methods for k_clock callback function Baolin Wang
2015-04-20 5:57 ` [PATCH 07/11] time/alarmtimer:Convert to the new methods for k_clock structure Baolin Wang
2015-04-20 5:57 ` [PATCH 08/11] time/posix-clock:Convert to the 64bit methods for k_clock and posix_clock_operations structure Baolin Wang
2015-04-20 5:57 ` [PATCH 09/11] cputime:Introduce the cputime_to_timespec64/timespec64_to_cputime function Baolin Wang
2015-04-20 21:09 ` Thomas Gleixner
2015-04-20 5:57 ` [PATCH 10/11] time/posix-cpu-timers:Convert to the 64bit methods for k_clock structure Baolin Wang
2015-04-20 5:57 ` [PATCH 11/11] k_clock:Remove the 32bit methods with timespec type Baolin Wang
2015-04-20 8:42 ` Richard Cochran
2015-04-20 9:00 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMz4kuKF2sU4tMD7UtDobu2kVDMp7cfHNERSPQ9Yyzs80tOzYg@mail.gmail.com \
--to=baolin.wang@linaro.org \
--cc=ahh@google.com \
--cc=arnd@arndb.de \
--cc=cl@linux.com \
--cc=fweisbec@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heenasirwani@gmail.com \
--cc=heiko.carstens@de.ibm.com \
--cc=john.stultz@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=pang.xunlei@linaro.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=rafael.j.wysocki@intel.com \
--cc=richardcochran@gmail.com \
--cc=riel@redhat.com \
--cc=rth@twiddle.net \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).