From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97122C3A589 for ; Tue, 20 Aug 2019 11:01:00 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF8F4206DF for ; Tue, 20 Aug 2019 11:00:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="esBS8tvW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF8F4206DF Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46CSWs6pfjzDqTd for ; Tue, 20 Aug 2019 21:00:57 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=google.com (client-ip=2607:f8b0:4864:20::243; helo=mail-oi1-x243.google.com; envelope-from=elver@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="esBS8tvW"; dkim-atps=neutral Received: from mail-oi1-x243.google.com (mail-oi1-x243.google.com [IPv6:2607:f8b0:4864:20::243]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46CR5J3G6FzDqvK for ; Tue, 20 Aug 2019 19:56:11 +1000 (AEST) Received: by mail-oi1-x243.google.com with SMTP id o6so3619468oic.9 for ; Tue, 20 Aug 2019 02:56:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ERy6C+OfX7AwXRit4NjtghifEuheVTJjPNjjGxnVXl4=; b=esBS8tvWjvw1oPPxWdzyE63jd94MRLnrUUg4cyouQEMyiYTKxPG+Md74XSdR0Hn9qm u/yhAcDom21n1PFzSKCGDVRlC8bwdtOPV5Ga016Y3MfIx+qPtgAqq/l3ZdPMYmiQU647 6FOJ9xi1gsNq3LaPCHCLn+mUPV3cg7lHqbwFZk1uSrWhaPoT1t9n6MR3QtZbKyLxDSxS yOOtBByzrdAPB/lhM3CHw0IMUBqHOuId43QVT2RwUl/2EzvVgf27h3OlZL30SdLIkmOF KUilJjflda9G5h40sZPfyzC1FSzsAn8yoWXinP1SG4qMRUqYupzKNJdNoA/N8PfONPNJ u4wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ERy6C+OfX7AwXRit4NjtghifEuheVTJjPNjjGxnVXl4=; b=F/UZVlsWwXPAL74vBhVscyPW2fYz6P/1iyB8uqB44fU7mOCPvGUZSlnBmLaVGbJCoV jYZyQgulovp9eW7cYyXVtsIXKOq0Zg5R1gP1VvFcvZrvTbzhy0HnDRBTfI6vgpkOQwIN 8secd3X0l4zFMdltXQzG9+DWEodGQC1+cfkexNlp2h9wA4Mz2tSQwIhgAMGbkP7XrG1n GotMdW7SkIZ2+P1r5nAw8dfydUZO4AABrgCtJiSLiIUZ2bg4XYrpEB0ChFvW6GAkvIXF e+Z45TxRZR5NG1eHA9eEg2AaK+VdQ4rdi2KY+bgQVK43omaWKcWD0nxriP7FkSfYhPAv abCA== X-Gm-Message-State: APjAAAVKP1L8elYYZzwpi3+CDM3w21/pKRoMaenevPPkGj4wEbxRqkEP 49WCZVRNUql8RX45YFjrf4gIczHEN5h7mNs0a9fQTA== X-Google-Smtp-Source: APXvYqyQ6eoEoVcpR/xbV96cbSTy0dNPpLdj0gQt1oJ++FGqgDPc8X6DViRqQ8kizDCDO6cg+XdDCeC8PkqVTf9p8Pg= X-Received: by 2002:aca:c396:: with SMTP id t144mr11367178oif.172.1566294967836; Tue, 20 Aug 2019 02:56:07 -0700 (PDT) MIME-Version: 1.0 References: <20190820024941.12640-1-dja@axtens.net> In-Reply-To: <20190820024941.12640-1-dja@axtens.net> From: Marco Elver Date: Tue, 20 Aug 2019 11:55:56 +0200 Message-ID: Subject: Re: [PATCH v2 1/2] kasan: support instrumented bitops combined with generic bitops To: Daniel Axtens Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Tue, 20 Aug 2019 20:49:42 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, the arch/x86 maintainers , kasan-dev , linux-arch , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, 20 Aug 2019 at 04:50, Daniel Axtens wrote: > > Currently bitops-instrumented.h assumes that the architecture provides > atomic, non-atomic and locking bitops (e.g. both set_bit and __set_bit). > This is true on x86 and s390, but is not always true: there is a > generic bitops/non-atomic.h header that provides generic non-atomic > operations, and also a generic bitops/lock.h for locking operations. > > powerpc uses the generic non-atomic version, so it does not have it's > own e.g. __set_bit that could be renamed arch___set_bit. > > Split up bitops-instrumented.h to mirror the atomic/non-atomic/lock > split. This allows arches to only include the headers where they > have arch-specific versions to rename. Update x86 and s390. > > (The generic operations are automatically instrumented because they're > written in C, not asm.) > > Suggested-by: Christophe Leroy > Reviewed-by: Christophe Leroy > Signed-off-by: Daniel Axtens Acked-by: Marco Elver Thanks!