From: Fabio Estevam <festevam@gmail.com>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux-ALSA <alsa-devel@alsa-project.org>,
Xiubo Li <Xiubo.Lee@gmail.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/7] ASoC: fsl_sai: Move res variable to be global
Date: Wed, 15 Jun 2022 11:22:38 -0300 [thread overview]
Message-ID: <CAOMZO5BRVBawK2PRvTazkQf-wExOuni9qD76Ha3FYmZZQyPRsg@mail.gmail.com> (raw)
In-Reply-To: <1655179884-12278-6-git-send-email-shengjiu.wang@nxp.com>
Hi Shengjiu,
On Tue, Jun 14, 2022 at 1:25 AM Shengjiu Wang <shengjiu.wang@nxp.com> wrote:
>
> The resource info need to be accessed by hw_params()
> function for multi fifo case, the start address may
> be not the FIFO0. So move it to be global first.
Actually, it is not global. It is being added as a member of struct fsl_sai.
Please rephrase the Subject to:
ASoC: fsl_sai: Make res a member of struct fsl_sai
and then in the commit log:
"So move it to be a member of struct fsl_sai."
next prev parent reply other threads:[~2022-06-15 14:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 4:11 [PATCH 0/7] Add PDM/DSD/dataline configuration support Shengjiu Wang
2022-06-14 4:11 ` [PATCH 1/7] ASoC: fsl_sai: Add PDM daifmt support Shengjiu Wang
2022-06-14 4:11 ` [PATCH 2/7] ASoC: fsl_sai: Add DSD bit format support Shengjiu Wang
2022-06-14 4:11 ` [PATCH 3/7] ASoC: fsl_sai: Add support for more sample rates Shengjiu Wang
2022-06-14 4:11 ` [PATCH 4/7] ASoc: fsl_sai: Add pinctrl operation for PDM and DSD Shengjiu Wang
2022-06-14 4:11 ` [PATCH 5/7] ASoC: fsl_sai: Move res variable to be global Shengjiu Wang
2022-06-15 14:22 ` Fabio Estevam [this message]
2022-06-16 7:53 ` Shengjiu Wang
2022-06-14 4:11 ` [PATCH 6/7] ASoC: dt-bindings: fsl-sai: Add new property to configure dataline Shengjiu Wang
2022-06-14 4:11 ` [PATCH 7/7] ASoC: fsl_sai: Configure dataline/FIFO information from dts property Shengjiu Wang
2022-06-28 10:31 ` [PATCH 0/7] Add PDM/DSD/dataline configuration support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5BRVBawK2PRvTazkQf-wExOuni9qD76Ha3FYmZZQyPRsg@mail.gmail.com \
--to=festevam@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=shengjiu.wang@nxp.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).