From: "Oliver O'Halloran" <oohall@gmail.com>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
Hulk Robot <hulkci@huawei.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] powerpc/powernv/sriov: Remove unused but set variable 'phb'
Date: Tue, 28 Jul 2020 09:58:49 +1000 [thread overview]
Message-ID: <CAOSf1CESE9tM_oJLwzfwx0AZfeJNXP719kJuo-Ba+NSY6BYhFg@mail.gmail.com> (raw)
In-Reply-To: <20200727171112.2781-1-weiyongjun1@huawei.com>
On Tue, Jul 28, 2020 at 3:01 AM Wei Yongjun <weiyongjun1@huawei.com> wrote:
>
> Gcc report warning as follows:
>
> arch/powerpc/platforms/powernv/pci-sriov.c:602:25: warning:
> variable 'phb' set but not used [-Wunused-but-set-variable]
> 602 | struct pnv_phb *phb;
> | ^~~
>
> This variable is not used, so this commit removing it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> arch/powerpc/platforms/powernv/pci-sriov.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/powernv/pci-sriov.c b/arch/powerpc/platforms/powernv/pci-sriov.c
> index 8404d8c3901d..7894745fd4f8 100644
> --- a/arch/powerpc/platforms/powernv/pci-sriov.c
> +++ b/arch/powerpc/platforms/powernv/pci-sriov.c
> @@ -599,10 +599,8 @@ static int pnv_pci_vf_resource_shift(struct pci_dev *dev, int offset)
> static void pnv_pci_sriov_disable(struct pci_dev *pdev)
> {
> u16 num_vfs, base_pe;
> - struct pnv_phb *phb;
> struct pnv_iov_data *iov;
>
> - phb = pci_bus_to_pnvhb(pdev->bus);
> iov = pnv_iov_get(pdev);
> num_vfs = iov->num_vfs;
> base_pe = iov->vf_pe_arr[0].pe_number;
>
Acked-by: Oliver O'Halloran <oohall@gmail.com>
next prev parent reply other threads:[~2020-07-28 0:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 17:11 [PATCH -next] powerpc/powernv/sriov: Remove unused but set variable 'phb' Wei Yongjun
2020-07-27 23:58 ` Oliver O'Halloran [this message]
2020-07-30 12:50 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOSf1CESE9tM_oJLwzfwx0AZfeJNXP719kJuo-Ba+NSY6BYhFg@mail.gmail.com \
--to=oohall@gmail.com \
--cc=aik@ozlabs.ru \
--cc=hulkci@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).