From: Lijun Pan <firstname.lastname@example.org> To: Rick Lindsley <email@example.com> Cc: Thomas Falcon <firstname.lastname@example.org>, email@example.com, Paul Mackerras <firstname.lastname@example.org>, Dany Madden <email@example.com>, Jakub Kicinski <firstname.lastname@example.org>, Sukadev Bhattiprolu <email@example.com>, firstname.lastname@example.org, "David S. Miller" <email@example.com> Subject: Re: [PATCH V2 net] ibmvnic: Continue with reset if set link down failed Date: Thu, 22 Apr 2021 12:01:30 -0500 Message-ID: <CAOhMmr6S2gZX9RSTVRhx-qS7QdeB4QAGCAVf3AyxpkP5ndOhAQ@mail.gmail.com> (raw) In-Reply-To: <firstname.lastname@example.org> On Thu, Apr 22, 2021 at 2:07 AM Rick Lindsley <email@example.com> wrote: > > On 4/21/21 10:30 PM, Lijun Pan wrote: > >> Fixes: ed651a10875f ("ibmvnic: Updated reset handling") > >> Signed-off-by: Dany Madden <firstname.lastname@example.org> > >> Reviewed-by: Rick Lindsley <email@example.com> > >> Reviewed-by: Sukadev Bhattiprolu <firstname.lastname@example.org> > > > > One thing I would like to point out as already pointed out by Nathan Lynch is > > that those review-by tags given by the same groups of people from the same > > company loses credibility over time if you never critique or ask > > questions on the list. > > > > Well, so far you aren't addressing either my critiques or questions. > > I have been asking questions but all I have from you are the above > attempts to discredit the reputation of myself and other people, and > non-technical statements like > > will make the code very difficult to manage > I think there should be a trade off between optimization and stability. > So I don't think you could even compare the two results > > On the other hand, from the original submission I see some very specific > details: > > If ibmvnic abandons the reset because of this failed set link > down and this is the last reset in the workqueue, then this > adapter will be left in an inoperable state. > > and from a followup discussion: > > We had a FATAL error and when handling it, we failed to > send a link-down message to the VIOS. So what we need > to try next is to reset the connection with the VIOS. For > this we must ... > > These are great technical points that could be argued or discussed. > Problem is, I agree with them. > > I will ask again: can you please supply some technical reasons for > your objections. Otherwise, your objections are meritless and at worst > simply an ad hominem attack. Well, from the beginning of v1, I started to provide technical inputs. Then I was not allowed to post anything in the community about this patch and VNIC via email@example.com except giving an ack-by/reviewed-by.
prev parent reply index Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-20 21:35 Dany Madden 2021-04-20 21:42 ` Lijun Pan 2021-04-21 6:45 ` Sukadev Bhattiprolu 2021-04-22 5:06 ` Lijun Pan 2021-04-22 6:58 ` Sukadev Bhattiprolu 2021-04-22 7:05 ` Rick Lindsley 2021-04-22 17:21 ` Michal Suchánek 2021-04-22 17:38 ` Lijun Pan 2021-04-23 2:26 ` Rick Lindsley 2021-05-04 19:05 ` Dany Madden 2021-04-21 7:54 ` Rick Lindsley 2021-04-22 5:12 ` Lijun Pan 2021-04-22 7:05 ` Rick Lindsley 2021-04-22 5:30 ` Lijun Pan 2021-04-22 7:07 ` Rick Lindsley 2021-04-22 17:01 ` Lijun Pan [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAOhMmr6S2gZX9RSTVRhx-qS7QdeB4QAGCAVf3AyxpkP5ndOhAQ@mail.gmail.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LinuxPPC-Dev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linuxppc-dev/0 linuxppc-dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linuxppc-dev linuxppc-dev/ https://lore.kernel.org/linuxppc-dev \ firstname.lastname@example.org email@example.com public-inbox-index linuxppc-dev Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.ozlabs.lists.linuxppc-dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git