From: Matt Brown <matthew.brown.dev@gmail.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org, Anton Blanchard <anton@samba.org>
Subject: Re: [PATCH 3/5] powerpc/lib/sstep: Add bpermd instruction emulation
Date: Fri, 14 Jul 2017 14:19:34 +1000 [thread overview]
Message-ID: <CAPoR37Ymuy95zzshsgwQwsCyMJwdc3MOzneL4=dq_xABY7o_dA@mail.gmail.com> (raw)
In-Reply-To: <20170713072821.GB13471@gate.crashing.org>
On Thu, Jul 13, 2017 at 5:28 PM, Segher Boessenkool
<segher@kernel.crashing.org> wrote:
> On Thu, Jul 13, 2017 at 01:25:46PM +1000, Matt Brown wrote:
>> +static nokprobe_inline void do_bpermd(struct pt_regs *regs, unsigned long v1,
>> + unsigned long v2, int ra)
>> +{
>> + unsigned int idx, i;
>> + unsigned char perm;
>> +
>> + perm = 0x0;
>> + for (i = 0; i < 8; i++) {
>> + idx = (v1 >> (i * 8)) & 0xff;
>> + if (idx < 64)
>> + perm |= (v2 & (1 << idx)) >> (idx - i);
>
> That doesn't work I think, the bit numbers ("idx") are big-endian?
Why would it be big-endian? Wouldn't it be in the same endian form as the arch?
>
>> + }
>> + regs->gpr[ra] = 0 | perm;
>
> And that is just silly :-)
>
Yep that is silly.
Thanks,
Matt
>> +}
>
>
> Segher
next prev parent reply other threads:[~2017-07-14 4:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 3:25 [PATCH 1/5] powerpc/lib/sstep: Add cmpb instruction emulation Matt Brown
2017-07-13 3:25 ` [PATCH 2/5] powerpc/lib/sstep: Add popcnt " Matt Brown
2017-07-13 3:25 ` [PATCH 3/5] powerpc/lib/sstep: Add bpermd " Matt Brown
2017-07-13 7:16 ` Gabriel Paubert
2017-07-13 7:28 ` Segher Boessenkool
2017-07-14 4:19 ` Matt Brown [this message]
2017-07-14 16:17 ` Segher Boessenkool
2017-07-13 3:25 ` [PATCH 4/5] powerpc/lib/sstep: Add prty " Matt Brown
2017-07-13 7:37 ` Segher Boessenkool
2017-07-14 0:46 ` Matt Brown
2017-07-14 19:02 ` kbuild test robot
2017-07-13 3:25 ` [PATCH 5/5] powerpc/lib/sstep: Add isel " Matt Brown
2017-07-13 7:47 ` Segher Boessenkool
2017-07-14 0:49 ` Matt Brown
2017-07-13 3:51 ` [PATCH 1/5] powerpc/lib/sstep: Add cmpb " Andrew Donnellan
2017-07-13 6:43 ` Segher Boessenkool
2017-07-13 7:10 ` Segher Boessenkool
2017-07-13 6:46 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPoR37Ymuy95zzshsgwQwsCyMJwdc3MOzneL4=dq_xABY7o_dA@mail.gmail.com' \
--to=matthew.brown.dev@gmail.com \
--cc=anton@samba.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).