Re: [PATCH 2/2] i2c: MPC8349E-mITX Power Management and GPIO expander driver

[Kumar Gala <galak@kernel.crashing.org>]

On Oct 10, 2008, at 9:45 AM, Anton Vorontsov wrote:

> On Fri, Oct 10, 2008 at 09:22:02AM -0500, Kumar Gala wrote:
>>
>> On Sep 23, 2008, at 9:13 AM, Anton Vorontsov wrote:
>>
>>> On MPC8349E-mITX, MPC8315E-RDB and MPC837x-RDB boards there is a
>>> Freescale MC9S08QG8 (MCU) chip with the custom firmware
>>> pre-programmed. The chip is used to power-off the board by the
>>> software, and to control some GPIO pins.
>>>
>>> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
>>> ---
>>> drivers/i2c/chips/Kconfig            |   11 ++
>>> drivers/i2c/chips/Makefile           |    1 +
>>> drivers/i2c/chips/mcu_mpc8349emitx.c |  209 +++++++++++++++++++++++ 
>>> ++
>>> +++++++++
>>> 3 files changed, 221 insertions(+), 0 deletions(-)
>>> create mode 100644 drivers/i2c/chips/mcu_mpc8349emitx.c
>>
>> is the plan to connect ppc_md.machine_shutdown() with this?
>
> You mean poweroff? It's already connected.
>
> +       /* XXX: this is potentially racy, but there is no lock for  
> ppc_md */
> +       if (!ppc_md.power_off) {
> +               glob_mcu = mcu;
> +               ppc_md.power_off = mcu_power_off;
> +               dev_info(&client->dev, "will provide power-off  
> service\n");
> +       }


uuh, yeah.. poweroff :)

and look at that.  Is this in Jean's queue?

- k