From: "Nicholas Piggin" <npiggin@gmail.com>
To: "Nathan Lynch" <nathanl@linux.ibm.com>, <linuxppc-dev@lists.ozlabs.org>
Cc: tyreld@linux.ibm.com, nnac123@linux.ibm.com,
ldufour@linux.ibm.com, ajd@linux.ibm.com
Subject: Re: [PATCH 12/13] powerpc/tracing: tracepoints for RTAS entry and exit
Date: Mon, 28 Nov 2022 12:54:19 +1000 [thread overview]
Message-ID: <CONL8SDELWSP.3V7G3F64356FI@bobo> (raw)
In-Reply-To: <20221118150751.469393-13-nathanl@linux.ibm.com>
On Sat Nov 19, 2022 at 1:07 AM AEST, Nathan Lynch wrote:
> Add two sets of tracepoints to be used around RTAS entry:
>
> * rtas_input/rtas_output, which emit the function name, its inputs,
> the returned status, and any other outputs. These produce an API-level
> record of OS<->RTAS activity.
>
> * rtas_ll_entry/rtas_ll_exit, which are lower-level and emit the
> entire contents of the parameter block (aka rtas_args) on entry and
> exit. Likely useful only for debugging.
>
> With uses of these tracepoints in do_enter_rtas() to be added in the
> following patch, examples of get-time-of-day and event-scan functions
> as rendered by trace-cmd (with some multi-line formatting manually
> imposed on the rtas_ll_* entries to avoid extremely long lines in the
> commit message):
>
> cat-36800 [059] 4978.518303: rtas_input: get-time-of-day arguments:
> cat-36800 [059] 4978.518306: rtas_ll_entry: token=3 nargs=0 nret=8
> params: [0]=0x00000000 [1]=0x00000000 [2]=0x00000000 [3]=0x00000000
> [4]=0x00000000 [5]=0x00000000 [6]=0x00000000 [7]=0x00000000
> [8]=0x00000000 [9]=0x00000000 [10]=0x00000000 [11]=0x00000000
> [12]=0x00000000 [13]=0x00000000 [14]=0x00000000 [15]=0x00000000
> cat-36800 [059] 4978.518366: rtas_ll_exit: token=3 nargs=0 nret=8
> params: [0]=0x00000000 [1]=0x000007e6 [2]=0x0000000b [3]=0x00000001
> [4]=0x00000000 [5]=0x0000000e [6]=0x00000008 [7]=0x2e0dac40
> [8]=0x00000000 [9]=0x00000000 [10]=0x00000000 [11]=0x00000000
> [12]=0x00000000 [13]=0x00000000 [14]=0x00000000 [15]=0x00000000
> cat-36800 [059] 4978.518366: rtas_output: get-time-of-day status: 0, other outputs: 2022 11 1 0 14 8 772648000
>
> kworker/39:1-336 [039] 4982.731623: rtas_input: event-scan arguments: 4294967295 0 80484920 2048
> kworker/39:1-336 [039] 4982.731626: rtas_ll_entry: token=6 nargs=4 nret=1
> params: [0]=0xffffffff [1]=0x00000000 [2]=0x04cc1a38 [3]=0x00000800
> [4]=0x00000000 [5]=0x0000000e [6]=0x00000008 [7]=0x2e0dac40
> [8]=0x00000000 [9]=0x00000000 [10]=0x00000000 [11]=0x00000000
> [12]=0x00000000 [13]=0x00000000 [14]=0x00000000 [15]=0x00000000
> kworker/39:1-336 [039] 4982.731676: rtas_ll_exit: token=6 nargs=4 nret=1
> params: [0]=0xffffffff [1]=0x00000000 [2]=0x04cc1a38 [3]=0x00000800
> [4]=0x00000001 [5]=0x0000000e [6]=0x00000008 [7]=0x2e0dac40
> [8]=0x00000000 [9]=0x00000000 [10]=0x00000000 [11]=0x00000000
> [12]=0x00000000 [13]=0x00000000 [14]=0x00000000 [15]=0x00000000
> kworker/39:1-336 [039] 4982.731677: rtas_output: event-scan status: 1, other outputs:
>
> Signed-off-by: Nathan Lynch <nathanl@linux.ibm.com>
> ---
> arch/powerpc/include/asm/trace.h | 116 +++++++++++++++++++++++++++++++
> 1 file changed, 116 insertions(+)
>
> diff --git a/arch/powerpc/include/asm/trace.h b/arch/powerpc/include/asm/trace.h
> index 08cd60cd70b7..e7a301c9eb95 100644
> --- a/arch/powerpc/include/asm/trace.h
> +++ b/arch/powerpc/include/asm/trace.h
> @@ -119,6 +119,122 @@ TRACE_EVENT_FN_COND(hcall_exit,
> );
> #endif
>
> +#ifdef CONFIG_PPC_RTAS
> +
> +#include <asm/rtas-types.h>
> +
> +/*
> + * Since stop-self is how CPUs go offline on RTAS platforms,
> + * these tracepoints are conditional.
> + */
> +
> +TRACE_EVENT_CONDITION(rtas_input,
> +
> + TP_PROTO(struct rtas_args *rtas_args, const char *name),
> +
> + TP_ARGS(rtas_args, name),
> +
> + TP_CONDITION(cpu_online(raw_smp_processor_id())),
> +
> + TP_STRUCT__entry(
> + __field(__u32, nargs)
> + __string(name, name)
> + __dynamic_array(__u32, inputs, be32_to_cpu(rtas_args->nargs))
> + ),
> +
> + TP_fast_assign(
> + __entry->nargs = be32_to_cpu(rtas_args->nargs);
> + __assign_str(name, name);
> + be32_to_cpu_array(__get_dynamic_array(inputs), rtas_args->args, __entry->nargs);
> + ),
> +
> + TP_printk("%s arguments: %s", __get_str(name),
> + __print_array(__get_dynamic_array(inputs), __entry->nargs, 4)
> + )
> +);
> +
> +TRACE_EVENT_CONDITION(rtas_output,
> +
> + TP_PROTO(struct rtas_args *rtas_args, const char *name),
> +
> + TP_ARGS(rtas_args, name),
> +
> + TP_CONDITION(cpu_online(raw_smp_processor_id())),
> +
> + TP_STRUCT__entry(
> + __field(__u32, nr_other)
> + __field(__s32, status)
> + __string(name, name)
> + __dynamic_array(__u32, other_outputs, be32_to_cpu(rtas_args->nret) - 1)
> + ),
> +
> + TP_fast_assign(
> + __entry->nr_other = be32_to_cpu(rtas_args->nret) - 1;
> + __entry->status = be32_to_cpu(rtas_args->rets[0]);
> + __assign_str(name, name);
> + be32_to_cpu_array(__get_dynamic_array(other_outputs),
> + &rtas_args->rets[1], __entry->nr_other);
> + ),
> +
> + TP_printk("%s status: %d, other outputs: %s", __get_str(name), __entry->status,
> + __print_array(__get_dynamic_array(other_outputs),
> + __entry->nr_other, 4)
> + )
> +);
> +
> +DECLARE_EVENT_CLASS(rtas_parameter_block,
> +
> + TP_PROTO(struct rtas_args *rtas_args),
> +
> + TP_ARGS(rtas_args),
> +
> + TP_STRUCT__entry(
> + __field(u32, token)
> + __field(u32, nargs)
> + __field(u32, nret)
> + __array(__u32, params, 16)
> + ),
> +
> + TP_fast_assign(
> + __entry->token = be32_to_cpu(rtas_args->token);
> + __entry->nargs = be32_to_cpu(rtas_args->nargs);
> + __entry->nret = be32_to_cpu(rtas_args->nret);
> + be32_to_cpu_array(__entry->params, rtas_args->args, ARRAY_SIZE(rtas_args->args));
> + ),
> +
> + TP_printk("token=%u nargs=%u nret=%u params:"
> + " [0]=0x%08x [1]=0x%08x [2]=0x%08x [3]=0x%08x"
> + " [4]=0x%08x [5]=0x%08x [6]=0x%08x [7]=0x%08x"
> + " [8]=0x%08x [9]=0x%08x [10]=0x%08x [11]=0x%08x"
> + " [12]=0x%08x [13]=0x%08x [14]=0x%08x [15]=0x%08x",
You could justify these since you went to the trouble to format them
nicely. Not a big deal though.
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
> + __entry->token, __entry->nargs, __entry->nret,
> + __entry->params[0], __entry->params[1], __entry->params[2], __entry->params[3],
> + __entry->params[4], __entry->params[5], __entry->params[6], __entry->params[7],
> + __entry->params[8], __entry->params[9], __entry->params[10], __entry->params[11],
> + __entry->params[12], __entry->params[13], __entry->params[14], __entry->params[15]
> + )
> +);
> +
> +DEFINE_EVENT_CONDITION(rtas_parameter_block, rtas_ll_entry,
> +
> + TP_PROTO(struct rtas_args *rtas_args),
> +
> + TP_ARGS(rtas_args),
> +
> + TP_CONDITION(cpu_online(raw_smp_processor_id()))
> +);
> +
> +DEFINE_EVENT_CONDITION(rtas_parameter_block, rtas_ll_exit,
> +
> + TP_PROTO(struct rtas_args *rtas_args),
> +
> + TP_ARGS(rtas_args),
> +
> + TP_CONDITION(cpu_online(raw_smp_processor_id()))
> +);
> +
> +#endif /* CONFIG_PPC_RTAS */
> +
> #ifdef CONFIG_PPC_POWERNV
> extern int opal_tracepoint_regfunc(void);
> extern void opal_tracepoint_unregfunc(void);
> --
> 2.37.1
next prev parent reply other threads:[~2022-11-28 3:00 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 15:07 [PATCH 00/13] RTAS maintenance Nathan Lynch
2022-11-18 15:07 ` [PATCH 01/13] powerpc/rtas: document rtas_call() Nathan Lynch
2022-11-22 2:46 ` Andrew Donnellan
2022-11-18 15:07 ` [PATCH 02/13] powerpc/rtasd: use correct OF API for event scan rate Nathan Lynch
2022-11-22 2:39 ` Andrew Donnellan
2022-11-18 15:07 ` [PATCH 03/13] powerpc/rtas: avoid device tree lookups in rtas_os_term() Nathan Lynch
2022-11-22 3:03 ` Andrew Donnellan
2022-11-28 18:08 ` Nathan Lynch
2022-11-28 2:29 ` Nicholas Piggin
2022-11-28 18:26 ` Nathan Lynch
2022-11-29 6:45 ` Nicholas Piggin
2022-11-29 15:37 ` Nathan Lynch
2022-11-18 15:07 ` [PATCH 04/13] powerpc/rtas: avoid scheduling " Nathan Lynch
2022-11-22 3:17 ` Andrew Donnellan
2022-11-28 2:34 ` Nicholas Piggin
2022-11-18 15:07 ` [PATCH 05/13] powerpc/pseries/eeh: use correct API for error log size Nathan Lynch
2022-11-22 3:21 ` Andrew Donnellan
2022-11-28 20:22 ` Nathan Lynch
2022-11-18 15:07 ` [PATCH 06/13] powerpc/rtas: clean up rtas_error_log_max initialization Nathan Lynch
2022-11-22 3:40 ` Andrew Donnellan
2022-11-18 15:07 ` [PATCH 07/13] powerpc/rtas: clean up includes Nathan Lynch
2022-11-22 4:45 ` Andrew Donnellan
2022-11-18 15:07 ` [PATCH 08/13] powerpc/rtas: define pr_fmt and convert printk call sites Nathan Lynch
2022-11-22 4:07 ` Andrew Donnellan
2022-11-18 15:07 ` [PATCH 09/13] powerpc/rtas: mandate RTAS syscall filtering Nathan Lynch
2022-11-22 4:20 ` Andrew Donnellan
2022-11-18 15:07 ` [PATCH 10/13] powerpc/rtas: improve function information lookups Nathan Lynch
2022-11-23 2:51 ` Andrew Donnellan
2022-11-23 19:32 ` Nick Child
2022-11-24 3:28 ` Andrew Donnellan
2022-11-28 21:19 ` Nathan Lynch
2022-11-29 0:08 ` Nathan Lynch
2022-11-29 7:23 ` Andrew Donnellan
2022-11-29 15:33 ` Nathan Lynch
2022-11-23 20:06 ` Nick Child
2022-11-28 21:57 ` Nathan Lynch
2022-11-18 15:07 ` [PATCH 11/13] powerpc/rtas: strengthen do_enter_rtas() type safety, drop inline Nathan Lynch
2022-11-23 3:23 ` Andrew Donnellan
2022-11-28 2:37 ` Nicholas Piggin
2022-11-18 15:07 ` [PATCH 12/13] powerpc/tracing: tracepoints for RTAS entry and exit Nathan Lynch
2022-11-28 2:54 ` Nicholas Piggin [this message]
2022-11-18 15:07 ` [PATCH 13/13] powerpc/rtas: place tracepoints in do_enter_rtas() Nathan Lynch
2022-11-28 3:07 ` Nicholas Piggin
2022-11-28 23:44 ` Nathan Lynch
2022-11-29 0:49 ` Michael Ellerman
2022-11-29 20:24 ` Nathan Lynch
2022-11-30 7:43 ` Michael Ellerman
2022-11-29 6:47 ` Nicholas Piggin
2022-12-08 12:40 ` [PATCH 00/13] RTAS maintenance Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CONL8SDELWSP.3V7G3F64356FI@bobo \
--to=npiggin@gmail.com \
--cc=ajd@linux.ibm.com \
--cc=ldufour@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nathanl@linux.ibm.com \
--cc=nnac123@linux.ibm.com \
--cc=tyreld@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).