From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Lukas Wunner" <lukas@wunner.de>,
"Stefan Berger" <stefanb@linux.ibm.com>
Cc: devicetree@vger.kernel.org, rnsastry@linux.ibm.com,
Nayna Jain <nayna@linux.ibm.com>,
jsnitsel@redhat.com, linux-kernel@vger.kernel.org,
linux-integrity@vger.kernel.org, viparash@in.ibm.com,
linuxppc-dev@lists.ozlabs.org, peterhuewe@gmx.de
Subject: Re: [RFC PATCH v2 2/3] dt-bindings: tpm: Add linux,sml-log to ibm,vtpm.yaml
Date: Tue, 12 Mar 2024 17:52:57 +0200 [thread overview]
Message-ID: <CZRW4ZZEH3BK.80W6O7YT5HH5@kernel.org> (raw)
In-Reply-To: <ZfA4TZspY7oOQ4vz@wunner.de>
On Tue Mar 12, 2024 at 1:11 PM EET, Lukas Wunner wrote:
> On Mon, Mar 11, 2024 at 09:20:29AM -0400, Stefan Berger wrote:
> > Add linux,sml-log, which carries the firmware TPM log in a uint8-array, to
> > the properties. Either this property is required or both linux,sml-base and
> > linux,sml-size are required. Add a test case for verification.
> >
> > Fixes: 82003e0487fb ("Documentation: tpm: add the IBM Virtual TPM device tree binding documentation")
>
> The Fixes tag is confusing. The patch won't even apply cleanly to the
> v4.10 commit referenced here as the conversion to yaml happened only
> recently with v6.8.
>
> Why is the Fixes tag necessary in the first place? Same question for
> the other patches in the series. This looks like feature work rather
> than a fix. Not sure whether it satisfies the "obviously correct"
> rule per Documentation/process/stable-kernel-rules.rst.
I'm not yet sure whether these are bug fixes and or improvements because
I did not fully understand the scenario where TPM corrupts the event log
so that part reminds to be seen.
Probably once I fully understand what is going on, it is possible to
argue on that.
BR, Jarkko
next prev parent reply other threads:[~2024-03-12 15:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 13:20 [RFC PATCH v2 0/3] Preserve TPM log across kexec Stefan Berger
2024-03-11 13:20 ` [RFC PATCH v2 1/3] powerpc/prom_init: Replace linux,sml-base/sml-size with linux,sml-log Stefan Berger
2024-03-11 17:24 ` Christophe Leroy
2024-03-11 19:10 ` Stefan Berger
2024-03-11 17:47 ` Jerry Snitselaar
2024-03-11 20:21 ` Jarkko Sakkinen
2024-03-11 13:20 ` [RFC PATCH v2 2/3] dt-bindings: tpm: Add linux,sml-log to ibm,vtpm.yaml Stefan Berger
2024-03-12 11:11 ` Lukas Wunner
2024-03-12 14:12 ` Stefan Berger
2024-03-12 15:52 ` Jarkko Sakkinen [this message]
2024-03-11 13:20 ` [RFC PATCH v2 3/3] tpm: of: If available use linux,sml-log to get the log and its size Stefan Berger
2024-03-11 20:25 ` Jarkko Sakkinen
2024-03-11 20:33 ` Stefan Berger
2024-03-12 15:43 ` Jarkko Sakkinen
2024-03-12 19:37 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CZRW4ZZEH3BK.80W6O7YT5HH5@kernel.org \
--to=jarkko@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jsnitsel@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukas@wunner.de \
--cc=nayna@linux.ibm.com \
--cc=peterhuewe@gmx.de \
--cc=rnsastry@linux.ibm.com \
--cc=stefanb@linux.ibm.com \
--cc=viparash@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).