From: Kumar Gala <galak@kernel.crashing.org>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org, Vivek Mahajan <vivek.mahajan@freescale.com>
Subject: Re: [PATCH v3 3/3] powerpc/fsl: 85xx: add cache-sram support
Date: Thu, 19 Nov 2009 12:51:38 -0600 [thread overview]
Message-ID: <D88B1DB0-B4ED-4695-B81A-1A7C77B11A86@kernel.crashing.org> (raw)
In-Reply-To: <20091119174546.GB6845@b07421-ec1.am.freescale.net>
On Nov 19, 2009, at 11:45 AM, Scott Wood wrote:
> On Thu, Nov 19, 2009 at 08:29:19AM -0600, Kumar Gala wrote:
>>>> +config FSL_85XX_CACHE_SRAM_BASE
>>>> + hex
>>>> + depends on FSL_85XX_CACHE_SRAM
>>>> + default "0xfff00000"
>>>> +
>>>
>>> I really don't like setting the physical address this way, can we
>>> not do this via the device tree?
>>
>> At a high level I think we should add something like the following in
>> the .dts:
>>
>> sram@fff00000 {
>> fsl,sram-ctrl-handle = <&L2>;
>> reg = <0xfff00000 0xNNNN>;
>> compatible = "fsl,mpc85xx-l2-sram";
>> }
>>
>> the NNNN can be the size the sram is configured as.
>
> I don't see why this needs to go in the device tree, if it's the
> kernel
> that is setting it up. The kernel can pick any address and size it
> wants.
It can, we just don't normally do physical address allocation in the
kernel. I just dont want it as a compile time thing. Either .dts or
make it runtime allocated by the kernel.
- k
next prev parent reply other threads:[~2009-11-19 18:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-21 12:50 [PATCH v3 1/3] powerpc/fsl: 85xx: document cache-sram size as a kernel parametric option Vivek Mahajan
2009-10-21 12:50 ` [PATCH v3 2/3] powerpc/fsl: 85xx: document cache-sram Vivek Mahajan
2009-10-21 12:50 ` [PATCH v3 3/3] powerpc/fsl: 85xx: add cache-sram support Vivek Mahajan
2009-11-19 14:21 ` Kumar Gala
2009-11-19 14:29 ` Kumar Gala
2009-11-19 17:45 ` Scott Wood
2009-11-19 18:51 ` Kumar Gala [this message]
2009-11-20 6:45 ` Mahajan Vivek-B08308
2009-11-20 17:38 ` Scott Wood
2009-12-01 5:36 ` Mahajan Vivek-B08308
2009-12-01 17:04 ` Scott Wood
2009-12-02 3:26 ` Kumar Gala
2009-10-21 17:50 ` [PATCH v3 2/3] powerpc/fsl: 85xx: document cache-sram Wolfgang Denk
2009-10-21 18:01 ` Scott Wood
2009-10-22 5:42 ` Mahajan Vivek-B08308
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D88B1DB0-B4ED-4695-B81A-1A7C77B11A86@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
--cc=vivek.mahajan@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).