From: Kumar Gala <galak@kernel.crashing.org>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 1/4] fsl_rio: fix compile errors
Date: Thu, 5 Aug 2010 13:00:53 -0500 [thread overview]
Message-ID: <EAC48836-5544-41DB-BBCA-E3DF27DAB572@kernel.crashing.org> (raw)
In-Reply-To: <20100805125415.3a939502@schlenkerla.am.freescale.net>
On Aug 5, 2010, at 12:54 PM, Scott Wood wrote:
> On Thu, 5 Aug 2010 12:39:48 -0500
> Kumar Gala <galak@kernel.crashing.org> wrote:
>=20
>>=20
>> On Jun 18, 2010, at 1:24 AM, Li Yang wrote:
>>=20
>>> Fixes the following compile problem on E500 platforms:
>>> arch/powerpc/sysdev/fsl_rio.c: In function =
'fsl_rio_mcheck_exception':
>>> arch/powerpc/sysdev/fsl_rio.c:248: error: 'MCSR_MASK' undeclared =
(first use in this function)
>>>=20
>>> Also fixes the compile problem on non-E500 platforms.
>>>=20
>>> Signed-off-by: Li Yang <leoli@freescale.com>
>>> ---
>>> arch/powerpc/sysdev/fsl_rio.c | 6 +++++-
>>> 1 files changed, 5 insertions(+), 1 deletions(-)
>>=20
>> I'm confused is this handler not relevant for e500MC? The 2nd patch =
makes me thing it is.
>=20
> It is, though it needs to use a different MCSR bit on e500mc.
>=20
> Are you referring to the #ifdef CONFIG_E500? CONFIG_PPC_E500MC =
depends
> on CONFIG_E500...
Ah, that makes a bit more sense now.
- k=
next prev parent reply other threads:[~2010-08-05 18:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-18 6:24 [PATCH v2 1/4] fsl_rio: fix compile errors Li Yang
2010-06-18 6:24 ` [PATCH v2 2/4] fsl_rio: fix machine check exception for e500mc Li Yang
2010-06-18 6:24 ` [PATCH v2 3/4] powerpc: add e500 HID1 bit definition Li Yang
2010-06-18 6:24 ` [PATCH v2 4/4] fsl_rio: fix non-standard HID1 register access Li Yang
2010-08-05 17:39 ` [PATCH v2 1/4] fsl_rio: fix compile errors Kumar Gala
2010-08-05 17:54 ` Scott Wood
2010-08-05 18:00 ` Kumar Gala [this message]
2010-08-31 21:39 ` Kumar Gala
2010-09-01 3:40 ` Li Yang
2010-09-01 6:44 ` Kumar Gala
2010-09-01 7:43 ` Li Yang-R58472
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EAC48836-5544-41DB-BBCA-E3DF27DAB572@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).