linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
To: David Miller <davem@davemloft.net>
Cc: linuxppc-dev@ozlabs.org, leoli@freescale.com, netdev@vger.kernel.org
Subject: Re: [PATCH] ucc_geth: Convert to net_device_ops
Date: Wed, 25 Mar 2009 00:35:16 +0100	[thread overview]
Message-ID: <OF3500930F.BEAC23ED-ONC1257583.008165CC-C1257583.0081924C@transmode.se> (raw)
In-Reply-To: <20090324.162913.226453070.davem@davemloft.net>

David Miller <davem@davemloft.net> wrote on 25/03/2009 00:29:13:
> From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> Date: Wed, 25 Mar 2009 00:08:53 +0100
> 
> > David Miller <davem@davemloft.net> wrote on 24/03/2009 23:49:02:
> > > 
> > > From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> > > Date: Tue, 24 Mar 2009 23:45:13 +0100
> > > 
> > > > I don't follow. Are these mandatory now? They were not in the old
> > > > impl. either.
> > > 
> > > See ether_setup() which is called indirectly via alloc_etherdev().
> > > 
> > > Yawn...
> > 
> > Same here, getting tiered. Should have seen that. Here goes,
> > attatched as well as explained earlier.
> 
> I'll apply this, thanks.

Thanks.
> 
> Please provide a proper "Signed-off-by:" line with future
> patch submissions, thanks.

Yep, getting tiered ...
Hopefully I will have something more coming your way the next few days.

  reply	other threads:[~2009-03-24 23:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-23 10:17 [PATCH] ucc_geth: Convert to net_device_ops Joakim Tjernlund
2009-03-23 18:49 ` David Miller
2009-03-24 10:37   ` Joakim Tjernlund
2009-03-24 21:22     ` David Miller
2009-03-24 22:45       ` Joakim Tjernlund
2009-03-24 22:49         ` David Miller
2009-03-24 23:08           ` Joakim Tjernlund
2009-03-24 23:29             ` David Miller
2009-03-24 23:35               ` Joakim Tjernlund [this message]
2009-03-27 18:50             ` Timur Tabi
2009-03-28 11:27               ` Joakim Tjernlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OF3500930F.BEAC23ED-ONC1257583.008165CC-C1257583.0081924C@transmode.se \
    --to=joakim.tjernlund@transmode.se \
    --cc=davem@davemloft.net \
    --cc=leoli@freescale.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).